Seems reasonable. I'll commit it once I've fixed the 32 files now being tested that have Pod errrors.
-J -- On Wed, Feb 15, 2006 at 06:44:12PM -0500, Will Coleda wrote: > Looks good. I note that it doesn't include something I thought I had > already committed. Here's a suggested alternative that fails fast > instead of slow if *either* module isn't installed, and includes your > changes. > > > > > > On Feb 15, 2006, at 5:41 PM, Joshua Hoblitt wrote: > > >On Tue, Feb 14, 2006 at 11:52:55PM -1000, Joshua Hoblitt wrote: > >>On Tue, Feb 14, 2006 at 05:23:39PM -0800, Will Coleda wrote: > >>>2) checks every file with pod in that directory hierarchy. > >>> > >>>It should only check those files that are in MANIFEST. (And > >>>*possibly* MANIFEST.generated) > >> > >>It's trivial to parse those files but is there a pre-existing parser > >>module I don't know about? There's no point in getting locked > >>into the > >>current format if we don't have to. > > > >It turns out there is a 'maniread()' function in ExtUtils::Manifest > >that > >I'd overlooked. > > > >Attached is a patch to t/doc/pod.t that changes it to only test > >files in > >MANIFEST & MANIFEST.generated. It also induces a change in what's > >considered a 'Pod' file. Currently only files named 'foo.pod', > >'foo.pl', 'foo.pm' are being tested for containing pod. This patch > >tests all files in MANIFEST, including '.c' files, to see if they > >contain pod. I'd like to get some feedback about this change before > >committing the patch. > > > >Cheers, > > > >-J > > > >-- > ><parrot-r11558-test_all_pod.patch> >
pgp5flwCdzyU1.pgp
Description: PGP signature
