On Tue, Feb 14, 2006 at 02:48:41PM +0100, Leopold Toetsch wrote:
> Tim Bunce wrote:
> >What's the difference between 'v' and '' for NCI function parameters?
> 
> There isn't any, except the extra 'v' char.
> 
> >I ask because both 'fv' and 'f' are in src/call_list.txt
> 
> Yeah.
> 
> >In fact there are several 'duplicated' signatures:
> 
> [ ... ]
> 
> I'd say, we should drop all the '?v' variants. The extra 'v' doesn't 
> cover any information, it's just causing an init call to the argument 
> passing code.
> 
> >Those warnings come from a version of tools/build/nativecall.pl I've
> >modified to 'normalize' the signatures to use 'v' and detect duplicates.
> >(As a side effect the nci.o file dropped from 354K to 347K.)
> 
> Good. But as said, I'd prefer the shorter signature.
> 
> >Also, what's the protocol for adding signatures to call_list.txt?
> >I've at least one I want to add ('p ttttitl' for mysql_real_connect)
> >and may have more soon. Should I just post a patch here?
> 
> Yep.
> 
> >Tim.
> 
> Thanks for looking into this,

I'll aim to work up a patch this week.

The runtime dlfunc code will need to be altered to normalize away the
trailing v so old code won't break. Should it warn about that?

Tim.

Reply via email to