On 1/18/06, Jonathan Worthington <[EMAIL PROTECTED]> wrote: > "Bob Rogers (via RT)" <[EMAIL PROTECTED]> wrote: > > > > The attached code compiles to byte code OK in r11235, until you > > comment out the push_eh indicated by the patch, which makes > > compute_dominance_frontiers take forever. (Sorry; I wish I had time to > > try to make it smaller.) TIA, > > > I hit upon this the other day, but with a 4,500 line PIR file which I've > also failed to get to a better test case. I'll see what I can do. > > In the meantime, we don't actually need compute_dominance_frontiers unless > we are optimizing so far as I can see, so I have ci'd a change to only do > that when the optimize flag is set.
In fact, the dominance frontier information is only useful for SSA, which is not completed, so you would be just as well off commenting out the entire compute_dominance_frontiers call in reg_alloc.c until it is needed. > I've cc'd in Curtis Rawls who I believe implemented the routine - Curtis, > any chance you may have time to have a quick look at this? I don't see that any changes have been made to the algorithm itself, so I guess the dominator tree input has been altered in some way that was assumed to be stable. If there was a smaller failing test case I could try to debug it and see what's going on. -Curtis > > Thanks, > > Jonathan
