On Wednesday 14 December 2005 12:09, Alberto Simoes wrote:

> +       printf STDERR "$stats{ok} OK from $stats{tests} tests (%.2f%%
> ok)\n\n",

Interpolating into a sprintf() string apart from %s is a minor security 
oopsie.  In this case, it's not so bad if you trust the data coming back from 
Test::Harness::Straps, but switching this is still good style, in my opinion.

Otherwise the rest looks useful, so I'll apply it with that tweak in a bit.

-- c

Reply via email to