Joshua Hoblitt via RT wrote:
As a general comment, 36119 makes me a little nervous as 'chmod' isn't
something you can count on unless your on a POSIX like system and osname
ne 'MSWin32' certainly would encompass non-POSIX systems. Are you
planning on retool this patch to be more pedantic about platforms?
The easiest thing to do is resubmit the patch, as suggested, with
specific platforms listed. We can then tweak them should more come along.
Thanks,
Nick
Index: config/gen/makefiles/dynclasses_pl.in
===================================================================
--- config/gen/makefiles/dynclasses_pl.in (revision 9438)
+++ config/gen/makefiles/dynclasses_pl.in (working copy)
@@ -153,6 +153,13 @@
foreach (@ungrouped_pmcs, keys %$group_files) {
copy("$_$LOAD_EXT", $dest) or die "Copy $_$LOAD_EXT failed ($?)\n";
+
+ # Execute permissions on libraries is especially important on
+ # some platforms
+ if ($^O eq 'hpux' or $^O eq 'cygwin') {
+ chmod 0755, "$dest${slash}$_$LOAD_EXT";
+ }
+
}
}
else {
