On Fri, 2005-07-15 at 08:27 -0700, Andy Dougherty wrote:

> After running 'make test', Parrot leaves the following files lying around
> in /tmp.  I think there's from t/perl/Parrot_Docs.t.

> There are two problems:
>     1.  Parrot should clean up after itself.
>     2.  Parrot should probably pick directory names less 
>       likely to collide with other legitimate uses of /tmp.

Agreed.  This patch appears to fix #1.  If there are no objections in a
day or two, I'll apply it.

I have an idea on how to fix #2 too.

-- c


Index: t/perl/Parrot_Docs.t
===================================================================
--- t/perl/Parrot_Docs.t	(revision 8629)
+++ t/perl/Parrot_Docs.t	(working copy)
@@ -121,9 +121,9 @@
 
 sub teardown
 {
-    Parrot::Docs::File->new(tmp_file_path('file.pod'))->delete;
-    Parrot::Docs::Directory->new(tmp_dir_path('src'));
-    Parrot::Docs::Directory->new(tmp_dir_path('tgt'));
+    Parrot::Docs::File->new(tmp_file_path('file.pod'))->delete();
+    Parrot::Docs::Directory->new(tmp_dir_path('src'))->delete();
+    Parrot::Docs::Directory->new(tmp_dir_path('tgt'))->delete();
 }
 
 # tmp_dir_path(@dirs)

Reply via email to