Dino Morelli (via RT) wrote:

As per discussions with Leo and Jerry, new allocation code for
resizablebooleanarray to support...

I've looked at the patch (but not yet applied it) and it seems to be quite ok. OTOH I'm a bit uncomfortable about the amount of tests. These do cover the basic operations but not the corner cases with error messages and not a more extended range of indices.

I'd would be really great if the tests would be extended to cover a much broader range of indices, like e.g. the tests in t/pmc/intlist.t These should be easily adaptable to boolean too, by just taking the lo bit of the values as test results.

Thanks,
leo

Reply via email to