> Yves Orton  wrote:
>
> >>http://svn.schwern.org/svn/CPAN/Test-Simple/trunk
> >>or
> >>svn://svn.schwern.org/CPAN/Test-Simple/trunk
> >>or
> >>http://www.pobox.com/~schwern/src/Test-Simple-0.54.tar.gz
> >>or
> >>a CPAN near you.
> >>
> >>
> >
> >Should the t/fork.t tests should still be skipped on Win32? Win32 Perl
has
> >been able to fork since at least 5.6...
> >
> But only if you build it with ithreads, which I don't generally do.  It
> would still need to skip for unthreaded builds.

Ok, patch is below (im curious why you dont use the threaded build if youd
care to explain :-)

diff -wurd Test-Simple-0.54/t/fork.t Test-Simple-0.54-Patched/t/fork.t
--- Test-Simple-0.54/t/fork.t   2004-12-04 21:06:30.000000000 +0100
+++ Test-Simple-0.54-Patched/t/fork.t   2004-12-15 13:43:00.478750000 +0100
@@ -10,7 +10,7 @@
 use Test::More;
 use Config;

-if( !$Config{d_fork} ) {
+unless( $Config{d_fork} or ($^O=~/win32/i && $Config{useithreads}) ) {
     plan skip_all => "This system cannot fork";
 }
 else {


Also Schwern, ive been trying to get it to build from the zip file linked
above. The first time I build i get the following test failure:

  t\00signature.............WARNING: This key is not certified with a
trusted signature!
  Primary key fingerprint: B484 04B8 E9D5 93A2 5CA8  F1AA 4F82 E2DC 2C3F
3F34
  ==> SKIPPED CHECKING 'Makefile'! (run Makefile.PL to ensure its integrity)
<===
  Not in MANIFEST: pmfiles.dat
  ==> MISMATCHED content between MANIFEST and distribution files! <==
  t\00signature.............NOK 1
  #     Failed test (t\00signature.t at line 30)
  #          got: -5
  #     expected: 0
  # Looks like you failed 1 test of 1.
  t\00signature.............dubious
          Test returned status 1 (wstat 256, 0x100)
  DIED. FAILED test 1
          Failed 1/1 tests, 0.00% okay
  t\00test_harness_check....ok

The next time I build:

  t\00signature.............WARNING: This key is not certified with a
trusted signature!
  Primary key fingerprint: B484 04B8 E9D5 93A2 5CA8  F1AA 4F82 E2DC 2C3F
3F34
  ==> SKIPPED CHECKING 'Makefile'! (run Makefile.PL to ensure its integrity)
<===
  Not in MANIFEST: foo
  ==> MISMATCHED content between MANIFEST and distribution files! <==
  t\00signature.............NOK 1
  #     Failed test (t\00signature.t at line 30)
  #          got: -5
  #     expected: 0
  # Looks like you failed 1 test of 1.
  t\00signature.............dubious
          Test returned status 1 (wstat 256, 0x100)
  DIED. FAILED test 1
          Failed 1/1 tests, 0.00% okay
  t\00test_harness_check....ok

When i remove "foo" and rerun again:

  t\00signature.............WARNING: This key is not certified with a
trusted signature!
  Primary key fingerprint: B484 04B8 E9D5 93A2 5CA8  F1AA 4F82 E2DC 2C3F
3F34
  ==> SKIPPED CHECKING 'Makefile'! (run Makefile.PL to ensure its integrity)
<===

And now it thinks its happy to install.....

Yves

Reply via email to