At 8:37 AM -0700 9/1/04, [EMAIL PROTECTED] (via RT) wrote:
On Solaris 8, asctime_r takes 3 parameters instead of 2.  The
prototype looks like this:

char *asctime_r(const struct tm *tm, char *buf, int buflen);

This patch adds a time.c file to the solaris platform directory.  The
only change in this time.c file and the stock generic/time.c is that
the call to asctime_r passes 26 as the buflen.

The Solaris man page for asctime_r says that the result will always be
26 characters exactly.  I'm guessing the POSIX asctime assumes that
the buffer is at least 26  characters, so assuming the buffer that
Parrot_asctime_r gets is at least 26 characters isn't a new risk.

Without this patch, the latest version of parrot from CVS will not
compile on Solaris 8.

Applied, thanks -- Dan

--------------------------------------it's like this-------------------
Dan Sugalski                          even samurai
[EMAIL PROTECTED]                         have teddy bears and even
                                      teddy bears get drunk

Reply via email to