On Fri, 25 Jun 2004, Nicholas Clark wrote: > On Fri, Jun 25, 2004 at 02:43:14PM +0200, Leopold Toetsch wrote: > > Nicholas Clark <[EMAIL PROTECTED]> wrote: > > > On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: > > >> > > >> Yep. I'd swap function names as well as argument order, so that > > >> everything matches the vtable prototype. > > > > > > > void Parrot_PMC_set_intkey_intval(Parrot_INTERP interp, Parrot_PMC > > > pmc, Parrot_Int value, Parrot_Int key) > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > "as well as argument order" > > D'oh. Silly me. > > > But I don't care, as long as vtables remain ;) > > I committed the change I suggested (change parameter order so that value > is always last) and then committed the change to ponie to keep it in sync, > and then realised I'd not checked the entire parrot source tree for any > other instances of these functions. > > docs/pdds/pdd11_extending.pod:7 > > Er. I'm changing the design here. I guess I had better ask Dan - is this > OK?
Yes. Fix up the PDD, though, to match the change. Dan --------------------------------------"it's like this"------------------- Dan Sugalski even samurai [EMAIL PROTECTED] have teddy bears and even teddy bears get drunk