On Mon 10 May 2004 19:40, stevan little <[EMAIL PROTECTED]> wrote: > I have committed my first set of changes to the DBI svn repository. I > am mostly still working on converting the scripts to use Test::More, > but I have managed to slip in some additional tests here and there. The > changes are as follows:
All looks great. Once you're done (or think you are), can we please have a snapshot (I don't do cvs), so I can test on the usual bunch of OS's and perls I have available. I think this rocks, certainly now I did the same for my DBD::Unify less than a month ago :) > 01basics.t > > - Changed file from custom "ok" routine to use Test::More. > - Increased number of tests from 47 to 109, this is mostly because I > added tests for *all* the sql_types and sql_cursor_types constants, > rather than just spot checks as they were previously > - Changed all if blocks to be Test::More style SKIP blocks > - made sure all tests had a test name > - re-organized the tests into logical groupings and added comments > > 02dbidrv.t > > - Changed file from using Test to using Test::More > - Increased the number of tests from 36 to 48, mostly this is just > doing 'isa_ok' tests on all returned objects. > - Changed all if blocks to be Test::More style SKIP blocks > - made sure all tests had a test name > > Still to do: > > - improve organization of tests in the file and add comments > > 07kids.t > > - Changed file from using Test to using Test::More > - Increased the number of tests from 9 to 11 > - Changed all if blocks to be Test::More style SKIP blocks > - made sure all tests had a test name > > Still to do: > > - I am sure there is more I can test here, I will see what i can find > - change it to a skip_all for DBI::PurePerl > - add comments > > 10example.t > > - Changed file from custom "ok" routine to use Test::More. > - Added one more test to bring it to 247 > - Changed all if blocks to be Test::More style SKIP blocks > > Still to do: > > - make sure all tests have a test name > - clean up this file, likely by break this up probably into several > smaller test files and maybe into re-usable functions as well > > 15array.t > > - Changed file from using Test to using Test::More > - Increased the number of tests from 39 to 41, mostly just 'isa_ok' > tests > > Still to do: > > - make sure all tests have a test name > - improve organization of tests in the file and add comments > > 30subclass.t > > - Changed file from custom "ok" routine to use Test::More. > > Still to do: > > - clean up the existing test orgainization > - make sure all tests have a test name > - add 'isa_ok' tests where appropriate > > There of course, is still more to come. But I thought I would commit my > changes thus far. > > Thanks, > > Stevan Little > [EMAIL PROTECTED] > --------------------------------------------------------------- > On two occasions I have been asked by members of Parliament, > "Pray, Mr. Babbage, if you put into the machine wrong figures, > will the right answers come out?" I am not able rightly to > apprehend the kind of confusion of ideas that could provoke > such a question. > -- Charles Babbage, 1792-1871 > -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using perl-5.6.1, 5.8.3, & 5.9.x, and 809 on HP-UX 10.20 & 11.00, 11i, AIX 4.3, SuSE 9.0, and Win2k. http://www.cmve.net/~merijn/ http://archives.develooper.com/[EMAIL PROTECTED]/ [EMAIL PROTECTED] send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org