Abhijit A. Mahabal wrote:
> this is my first patch ever (not just p6i: ever). So do tell me
> what I have done wrong.
Sorry not to respond before the patch was applied. Crazy week.
> This is a patch for one of the ToDo items in languages/perl6/Todo. I have
> updated the calling conventions in a bunch of places, but may have missed
> some.
It looks great Abhijit. My one change would be this: We're gradually
moving towards using the real symbol table. Those places where you see
"find_lex" will eventually be calls to the dispatch mechanism (look for
a lexical subroutine with that name, failing that look for a global
subroutine of that name, multiple dispatch, etc.) I'd rather not take a
step back to calls based on the PIR name of the subroutine.
> - find_lex $P2, "&die"
> - .pcc_begin non_prototyped
> - .arg $P0
> - .pcc_call $P2
> -substr_ret_label:
> - .pcc_end
> + _die($P0)
If syntax like this:
find_lex $P2, "&die"
$P2($P0)
isn't possible yet, it probably should be.
> BTW, should I keep working on P6C? As A12 has just come out P6C may be
> heavily under construction, and I don't want to be in the way...
Please do. I'm working on a first rough implementation of classes, but
it shouldn't interfere with general patches.
Send your patches to [EMAIL PROTECTED] so they show up in the
perl6 RT queue.
Thanks,
Allison
