On Apr 9, 2004, at 3:26 PM, Jonathan Worthington wrote:

I'm having a crack at getting the ICU changes building on Win32.

Great--thanks!


Here's the first step. string.c did some C99 stuff:-

* Declared variables at places other than the top of a block

Sorry about that.


* Used uint8_t, uint16_t, uint32_t, which we don't exists in MS VC++

The attached patch fixes these plus another warning. For the /uint\d+_t/
ones, I used Parrot_UInt2 and Parrot_UInt4, and added a Parrot_UInt1 in
config.h.in, which is hard-coded to be an unsigned char for now. I'm not
sure if this was the Right Thing to do, but it works. ;-)

I think it's the right thing. I figured that the uintX_t would need to be changed to something config-able, but I didn't realize we already had types in place (or most of them) which would do the job. So thanks again for taking care of that!


JEff

Reply via email to