Leopold Toetsch writes:
> Matt Fowles <[EMAIL PROTECTED]> wrote:
> 
> > This patch make the problem case submitted by Jeff Clites work.  All
> > tests pass, and his sample has been added to the tests.
> 
> >      struct RegisterChunkBuf* top = stack->top;
> >      if (top->used > 1) {
> > +        top->used--;
> 
> Thanks for the patch *but*:
> 
> That's changing the COWed copy. It does the right thing for the test
> case but is still wrong.
> 
> As already stated:
> - COWed buffers need distinct buffer headers pointing to the same
>   buffer memory
> - unCOWing (regstack_copy_chunk) allocates new buffer memory and
>   resets the COW flag

I headed in to fix this when I saw some new stuff in there.   Has this
been fixed?

Luke

Reply via email to