On Sunday, January 25, 2004, at 07:08 , Leopold Toetsch wrote:

Gordon Henriksen <[EMAIL PROTECTED]> wrote:

Speaking of cleaning and uniting, what is with this?

#define bufstart obj.u.b.bufstart
#define buflen   obj.u.b.buflen

These are *currently* necessary macros, until the PMC/PObj layout is really carved in stones. You had in your proposal a different PMC structure layout. Testing such things is vastly simplified by having accessor macros.

Yes, I know. ;) I was going to test a real layout change, but the macros were so tangled up that I wound up just appending 4 ints to struct PMC to simulate.


I'm not a friend of such macros. But they are needed as long as the actual structure might change. I did introduce all pobj.h related macros. They can go away, when *all* issues are resolved.

I know what they are, and have no problem with them. I don't think they should be removed. But this particular batch are a mess. I just submitted a couple of patches to clean them up a little, though I didn't get through the entire source tree yet.




Gordon Henriksen
[EMAIL PROTECTED]

Reply via email to