Hi,
I'm currently working on some bugs in the PIO_seek code, and i find
the current return-code of Seek impractical: it just returns 0 on
success and -1 on error. I found myself writing code like
PIO_seek_down(...);
pos = PIO_tell_down(...);
but in the layer implementations typically is this code:
return pos == -1 ? -1 : 0;
So i think it would be better to let PIO_seek return the current
offset. So I purpose a change of the prototype of PIO_seek to
PIOOFF_T PIO_seek(theINTERP, PMC *io, PIOFF_T offset, INTVAL whence);
The error checking can still be done by
if (PIO_seek(...) < 0) {
/* an error occured */
}
Comments?
boe
--
Juergen Boemmels [EMAIL PROTECTED]
Fachbereich Physik Tel: ++49-(0)631-205-2817
Universitaet Kaiserslautern Fax: ++49-(0)631-205-3906
PGP Key fingerprint = 9F 56 54 3D 45 C1 32 6F 23 F6 C7 2F 85 93 DD 47
