"vcv" <[EMAIL PROTECTED]> writes:

> Granted I haven't gotten my hands dirty with the guts of parrot yet, but it
> looks good to me, and makes sense.
> 
> Thanks for the fix though, it works great now :)
> 
> However, it did introduce a warning (on Win32):
> 
> io.ops(59) : warning C4022: 'PIO_fdopen' : pointer mismatch for actual
> parameter
> 2

Ah, this line was ifdefed out on windows until now. Try following
patch. It adds a cast for the INTVAL parrameter. This is only a
temporary hack because this abuses an INTVAL to carry a pointer, which
is not guaranteed to work. Moving fdopen away from INTVAL to PMCs will
solve this but this is a drastic change in feature-freeze.

bye
boe

Index: io.ops
===================================================================
RCS file: /cvs/public/parrot/io.ops,v
retrieving revision 1.34
diff -u -r1.34 io.ops
--- io.ops      17 Sep 2003 17:34:01 -0000      1.34
+++ io.ops      17 Sep 2003 18:26:21 -0000
@@ -56,7 +56,7 @@
   const char * mode;
   mode = string_to_cstring(interpreter, $3);
 
-  $1 = PIO_fdopen(interpreter, $2, mode);
+  $1 = PIO_fdopen(interpreter, (PIOHANDLE)$2, mode);
   if (!$1) {
     $1 = pmc_new(interpreter, enum_class_PerlUndef);
   }

-- 
Juergen Boemmels                        [EMAIL PROTECTED]
Fachbereich Physik                      Tel: ++49-(0)631-205-2817
Universitaet Kaiserslautern             Fax: ++49-(0)631-205-3906
PGP Key fingerprint = 9F 56 54 3D 45 C1 32 6F  23 F6 C7 2F 85 93 DD 47

Reply via email to