# New Ticket Created by Steve Clark
# Please include the string: [perl #23819]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=23819 >
Attached is a patch file of a couple of trivial janitorial-type fixes
to pdump-related files:
- packdump.c was giving a compiler warning about an unrecognized trigraph
- made packdump.c consistent in its use of 'struct Parrot_Interp*' -- in
a couple of places it was using the
typedef of Parrot_Interp.
- pdump.c contained declarations for functions in packdump.c. I have
moved these to packfile.h.
Steve
-- attachment 1 ------------------------------------------------------
url: http://rt.perl.org/rt2/attach/64620/47335/886172/pdump.patch
Index: packdump.c
===================================================================
RCS file: /cvs/public/parrot/packdump.c,v
retrieving revision 1.16
diff -u -r1.16 packdump.c
--- packdump.c 28 Aug 2003 08:11:08 -0000 1.16
+++ packdump.c 16 Sep 2003 16:08:51 -0000
@@ -24,7 +24,8 @@
struct PackFile_ConstTable *);
static void PackFile_Constant_dump(struct Parrot_Interp *,
struct PackFile_Constant *);
-void PackFile_Fixup_dump(Parrot_Interp , struct PackFile_FixupTable *ft);
+void PackFile_Fixup_dump(struct Parrot_Interp *,
+ struct PackFile_FixupTable *ft);
void
PackFile_ConstTable_dump(struct Parrot_Interp *interpreter,
@@ -99,14 +100,15 @@
PIO_printf(interpreter, " } ],\n");
break;
default:
- PIO_printf(interpreter, " [ 'PFC_????', type '0x%x' ],\n",
+ PIO_printf(interpreter, " [ 'PFC_\?\?\?', type '0x%x' ],\n",
self->type);
break;
}
}
void
-PackFile_Fixup_dump(Parrot_Interp interpreter, struct PackFile_FixupTable *ft)
+PackFile_Fixup_dump(struct Parrot_Interp *interpreter,
+ struct PackFile_FixupTable *ft)
{
opcode_t i;
Index: packfile.c
===================================================================
RCS file: /cvs/public/parrot/packfile.c,v
retrieving revision 1.110
diff -u -r1.110 packfile.c
--- packfile.c 28 Aug 2003 08:11:08 -0000 1.110
+++ packfile.c 16 Sep 2003 16:08:53 -0000
@@ -1812,7 +1812,7 @@
}
struct PackFile_FixupEntry *
-PackFile_find_fixup_entry(Parrot_Interp interpreter, enum_fixup_t type,
+PackFile_find_fixup_entry(struct Parrot_Interp *interpreter, enum_fixup_t type,
char * name)
{
/* TODO make a hash of all fixups */
Index: pdump.c
===================================================================
RCS file: /cvs/public/parrot/pdump.c,v
retrieving revision 1.27
diff -u -r1.27 pdump.c
--- pdump.c 28 Aug 2003 15:26:21 -0000 1.27
+++ pdump.c 16 Sep 2003 16:08:53 -0000
@@ -13,11 +13,6 @@
#include "parrot/parrot.h"
#include "parrot/embed.h"
-/* s. packdump.c */
-void PackFile_ConstTable_dump(struct Parrot_Interp *,
- struct PackFile_ConstTable *);
-void PackFile_Fixup_dump(Parrot_Interp , struct PackFile_FixupTable *ft);
-
static void
const_dump (struct Parrot_Interp *interpreter, struct PackFile_Segment *segp)
{
Index: include/parrot/packfile.h
===================================================================
RCS file: /cvs/public/parrot/include/parrot/packfile.h,v
retrieving revision 1.49
diff -u -r1.49 packfile.h
--- include/parrot/packfile.h 18 Aug 2003 11:30:39 -0000 1.49
+++ include/parrot/packfile.h 16 Sep 2003 16:08:56 -0000
@@ -281,6 +281,9 @@
void PackFile_FixupTable_pack(struct PackFile_FixupTable * self,
opcode_t * packed);
+void PackFile_Fixup_dump(struct Parrot_Interp *,
+ struct PackFile_FixupTable *ft);
+
/* create new fixup entry */
void PackFile_FixupTable_new_entry(struct Parrot_Interp *, char *label,
enum_fixup_t, opcode_t offs);
@@ -306,6 +309,8 @@
void PackFile_ConstTable_clear(struct PackFile_ConstTable * self);
+void PackFile_ConstTable_dump(struct Parrot_Interp *,
+ struct PackFile_ConstTable *);
size_t PackFile_ConstTable_pack_size(struct PackFile_Segment * self);
opcode_t * PackFile_ConstTable_pack(struct PackFile_Segment *, opcode_t *);
