At 3:58 PM +0100 11/25/02, Leopold Toetsch wrote:
Gopal V wrote:

Thanks for the patch. I'll add some config methods and apply it after polishing.

DISCLAIMER: I don't know anything about how parrot opcodes should be
written .. So all errors are accidental and I would like somebody to
point them out to me ..

Pretty well done, modulo minor typos, which a *test* would have catched ;-) hint, hint t/op/*.t ...

Ok, here we go.

inline op conv_i1(inout INT) {
  $1= (int)((char)($1));

  $1 = (INTVAL)((char)($1));

The INTVAL could be a "long long".
That one needs a sizeof(char) check. chars are *not* 8 bits everywhere.

inline op conv_i2(inout INT) {
  $1= (int)((short)($1));

$1 = (INTVAL)((Parrot_int2)($1));

Parrot_Int2 will be generated by a test in config/auto/somewhere and will be "short".
Same here. shorts may not be 16 bits.
--
                                        Dan

--------------------------------------"it's like this"-------------------
Dan Sugalski                          even samurai
[EMAIL PROTECTED]                         have teddy bears and even
                                      teddy bears get drunk

Reply via email to