# New Ticket Created by  Andy Dougherty 
# Please include the string:  [perl #17691]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=17691 >


This patch fixes a tiny problem in trace.c when sizeof(opcode_t) !=
sizeof(long).

More generally, though, rather than sprinkling the sources with INTVAL_FMT
and other ugly (but correct and portable things), should we be trying to 
funnel everything through a central printf-like engine and have it
automatically provide the correct formats?  perl-5.8.0 somewhat belatedly
introduced something like that, and it seems like a good idea.
 
--- parrot-orig/trace.c Mon Aug 26 10:15:45 2002
+++ parrot-andy/trace.c Mon Sep 30 11:19:43 2002
@@ -80,7 +80,7 @@
     INTVAL i;
     char *escaped;
 
-    fprintf(stderr, "PC=%ld; OP=%ld (%s)", (long)(pc - code_start), *pc,
+    fprintf(stderr, "PC=%ld; OP=%ld (%s)", (long)(pc - code_start), (long) *pc,
             interpreter->op_info_table[*pc].full_name);
 
     if (interpreter->op_info_table[*pc].arg_count > 1) {

-- 
    Andy Dougherty              [EMAIL PROTECTED]



Reply via email to