Hey, I was going throuh the RT system looking to resolve issues.
It looks like the offending lines of code are still there. A quick look at
the problem, and I see the following patch:
Index: hash.c
===================================================================
RCS file: /cvs/public/parrot/hash.c,v
retrieving revision 1.10
diff -u -r1.10 hash.c
--- hash.c 2 Aug 2002 02:58:27 -0000 1.10
+++ hash.c 4 Aug 2002 07:09:33 -0000
@@ -437,7 +437,7 @@
HASHBUCKET * b = table[i];
while (b) {
/* XXX: does b->key need to be copied? */
- hash_put(interp, ret, b->key, key_clone(interp,
&(b->value)));
+ hash_put(interp, ret, b->key, b->value);
b = b->next;
}
}
Unfortunately, this causes different semantics for whether you are storing
primitives or pointers (primitives copy, whereas pointers are shallow). Of
course, one could argue that the previous one didn't work at all. :)
Thoughts?
Mike Lambert
Sean O'Rourke wrote:
> Date: Fri, 2 Aug 2002 08:20:58 -0700 (PDT)
> From: Sean O'Rourke <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Cc: [EMAIL PROTECTED]
> Subject: Re: [perl #15942] UNICOS/mk new unhappiness: hash.c
>
> That's me. Will fix.
>
> /s
>
> On Fri, 2 Aug 2002, Jarkko Hietaniemi wrote:
>
> > # New Ticket Created by Jarkko Hietaniemi
> > # Please include the string: [perl #15942]
> > # in the subject line of all future correspondence about this issue.
> > # <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=15942 >
> >
> >
> > The subroutine.pmc and sub.pmc problems ([perl #15920]) are gone now
> > that Dan checked in the patches but now new discontent has appeared:
> >
> > CC-167 cc: ERROR File = hash.c, Line = 440
> > Argument of type "KEY_ATOM *" is incompatible with parameter of type "KEY *".
> >
> > hash_put(interp, ret, b->key, key_clone(interp, &(b->value)));
> > ^
> >
> > CC-167 cc: ERROR File = hash.c, Line = 440
> > Argument of type "KEY *" is incompatible with parameter of type "KEY_ATOM *".
> >
> > hash_put(interp, ret, b->key, key_clone(interp, &(b->value)));
> > ^
> >
> > 2 errors detected in the compilation of "hash.c".
> >
> > --
> > $jhi++; # http://www.iki.fi/jhi/
> > # There is this special biologist word we use for 'stable'.
> > # It is 'dead'. -- Jack Cohen
> >
> >
>
>
