On Wed, Jul 31, 2002 at 11:43:39PM +0000, Jürgen Bömmels wrote:
> In the quest for removing warnings, I added an option --ccwarn to
> Configure.pl. With this option I could selectivly turn on and off
> warnings, and especially compile with -Werror, so I don't miss any
> warnings. The simple warnings (the missing return values) were already
> fixed before I was able to submit a patch.


> -- attachment  1 ------------------------------------------------------
> url: http://rt.perl.org/rt2/attach/32512/26823/c6326a/remove_warnings.diff
> 
Did this bit mean to get in?

Index: lib/Parrot/Configure/Step.pm
===================================================================
RCS file: /cvs/public/parrot/lib/Parrot/Configure/Step.pm,v
retrieving revision 1.3
diff -u -r1.3 Step.pm
--- lib/Parrot/Configure/Step.pm        19 Jul 2002 08:28:02 -0000      1.3
+++ lib/Parrot/Configure/Step.pm        31 Jul 2002 19:17:40 -0000
@@ -99,7 +99,9 @@
 }
 
 sub cc_clean {
+       my $exe=Configure::Data->get('exe');
        unlink glob "test.*";
+       unlink "test$exe" 
 }
 
 1;


Apart from that, looks good to me. (but I'm leaving it to the Configure
pumpking to actually commit (maybe without the above bit))

Nicholas Clark
-- 
Even better than the real thing:        http://nms-cgi.sourceforge.net/

Reply via email to