Looks good to me. Couple of quick things, when I applied the patch locally, it indented the end bracket of the invoke op in core.ops which breaks ops2c.pl. Also the patch removed the yield op from core.ops, was this intentional? More comments below.
On Tue, 2002-07-30 at 22:07, Sean O'Rourke wrote: > This patch implements native extensions and continuations as pmcs. It also > cleans up the existing Sub and Coroutine types, and removes the following > now-obsolete ops: > > callco > callcc > capturecc > call > callnative > > These are all handled through various uses of "invoke" (see t/pmc/sub.t > for simple examples). I like this, then the code generator does not need to know what type of sub it is dealing with. While I am thinking about it, would it make sense to distinguish between a sub and a closure? A sub would be a little more efficient in cases where a closure is not needed. [skipping] > - not integrated with lexicals. Parrot is a fast-moving target nowadays! Current discussion on the list makes me wonder if this is still up in the air a bit. However I would be happy work on this, once I feel like I understand what the consensus is for lexicals ... -- Jonathan Sillito
