My suggestion is to add on vtable.tbl comment like

void set_integer_native(INTVAL value)  # example: set P0, I0
void set_number_native(FLOATVAL value)  # example: set P0, N0

and so on. Of course the content of the comment can be more descritive.
Then, I changed parse_vtable and genclass.pl to create comments with this
just before each pmclass method.

I send the patch in attatchment.

Alberto

-- 
Alberto Manuel B. Simoes
Departamento de Informática - Universidade do Minho
http://alfarrabio.di.uminho.pt/~albie - http://numexp.sf.net
Index: vtable.tbl
===================================================================
RCS file: /cvs/public/parrot/vtable.tbl,v
retrieving revision 1.25
diff -r1.25 vtable.tbl
62c62
< void set_integer_native(INTVAL value)
---
> void set_integer_native(INTVAL value)  # example: set P0, I0
68c68
< void set_number_native(FLOATVAL value)
---
> void set_number_native(FLOATVAL value)  # example: set P0, N0
80c80
< void set_string_native(STRING* value)
---
> void set_string_native(STRING* value)   # example: set P0, S0
87c87
< void set_pmc(PMC* value)
---
> void set_pmc(PMC* value)   # example: set P0, P1
Index: classes/genclass.pl
===================================================================
RCS file: /cvs/public/parrot/classes/genclass.pl,v
retrieving revision 1.11
diff -r1.11 genclass.pl
38,39c38,40
<     my ($retval, $methname, $args) = @{$_};
<     
---
>     my ($retval, $methname, $args, $comment) = @{$_};
> 
>     print "    /* $comment */\n" if $comment;
Index: lib/Parrot/Vtable.pm
===================================================================
RCS file: /cvs/public/parrot/lib/Parrot/Vtable.pm,v
retrieving revision 1.16
diff -r1.16 Vtable.pm
31c31
<         
---
> 
37,39c37,39
<         
<         if (/^\s*($type_re)\s+($ident_re)\s*\(($arglist_re)\)\s*$/) {
<             push @{$vtable}, [ $1, $2, $3 ];
---
> 
>         if (/^\s*($type_re)\s+($ident_re)\s*\(($arglist_re)\)\s*(?:#(.*))?$/) {
>             push @{$vtable}, [ $1, $2, $3, $4 || "" ];

Reply via email to