There are, at least native size issues, maybe not alignment issues; but
thats why I left that fixme warning in packfile to remind us to go back and
fix floats.
At least the fetch routines do it per-byte so they don't care.

-Melvin Smith

IBM :: Atlanta Innovation Center
[EMAIL PROTECTED] :: 770-835-6984


                                                                                       
                                               
                      Andy Dougherty                                                   
                                               
                      <doughera@lafayet        To:       Mike Lambert <[EMAIL PROTECTED]> 
                                               
                      te.edu>                  cc:       Perl6 Internals 
<[EMAIL PROTECTED]>                                   
                                               Subject:  Re: [PATCH] Warnings cleanup  
                                               
                      05/20/2002 10:55                                                 
                                               
                      AM                                                               
                                               
                                                                                       
                                               
                                                                                       
                                               



On Sun, 19 May 2002, Mike Lambert wrote:

> > This patch removes a bunch of warnings that have accumulated with MSVC
> > recently.

Thanks.  I'm down to 934 warnings now :-).

Index: packfile.c

-    self->number = PackFile_fetch_nv(pf, (unsigned char *)cursor);
+    self->number = PackFile_fetch_nv(pf, (opcode_t *)cursor);


That cast shouldn't be necessary.  cursor is already opcode_t *. (I also
gather there are still alignment issues, since it isn't guaranteed that
sizeof(FLOATVAL)/sizeof(opcode_t) is even an integer :-).

--
    Andy Dougherty                         [EMAIL PROTECTED]
    Dept. of Physics
    Lafayette College, Easton PA 18042






Reply via email to