Applied, thanks.  Had to change the chartype.h part a bit, as it didn't 
want to apply on its own.  I am not sure why.

Anyway, it's in.   Is there a reason not to include -Wredundant_decls in 
our default warnings flags?

--Josh

At 22:54 on 04/16/2002 EDT, Simon Glover <[EMAIL PROTECTED]> wrote:

> 
>  Compiling parrot with gcc's -Wredundant_decls option shows up a few
>  places where we're declaring functions twice in the same header file.
>  Patch below fixes.
> 
>  Simon
> 
> --- include/parrot/chartype.h.old     Tue Apr 16 22:33:46 2002
> +++ include/parrot/chartype.h Tue Apr 16 22:31:56 2002
> @@ -48,9 +48,6 @@
> 
>  #define chartype_lookup Parrot_chartype_lookup
> 
> -CHARTYPE_TRANSCODER chartype_lookup_transcoder(const CHARTYPE *from,
> -                                               const CHARTYPE *to);
> -
>  #endif
> 
>  #endif
> 
> 
> --- include/parrot/packfile.h.old     Tue Apr 16 22:32:52 2002
> +++ include/parrot/packfile.h Tue Apr 16 22:32:58 2002
> @@ -119,8 +119,6 @@
>                                           opcode_t *packed,
>                                           opcode_t packed_size);
> 
> -opcode_t PackFile_Constant_pack_size(struct PackFile_Constant *self);
> -
>  #endif /* PACKFILE_H */
> 
>  /*
> 
> 
> --- include/parrot/embed.h.old        Tue Apr 16 22:38:01 2002
> +++ include/parrot/embed.h    Tue Apr 16 22:38:07 2002
> @@ -32,8 +32,6 @@
> 
>  Parrot_PackFile Parrot_readbc(Parrot, char *);
> 
> -void Parrot_setwarnings(Parrot, Parrot_warnclass);
> -
>  void Parrot_loadbc(Parrot, Parrot_PackFile);
> 
>  void Parrot_runcode(Parrot, int argc, char *argv[]);
> 
> 
> --- runops_cores.c.old        Tue Apr 16 22:48:36 2002
> +++ runops_cores.c    Tue Apr 16 22:48:42 2002
> @@ -47,9 +47,6 @@
>   * With bounds checking.
>   */
> 
> -void trace_op(struct Parrot_Interp *interpreter, opcode_t *code_start,
> -              opcode_t *code_end, opcode_t *pc);
> -
>  opcode_t *
>  runops_slow_core(struct Parrot_Interp *interpreter, opcode_t *pc)
>  {
> 


Reply via email to