At 11:21 PM +0200 4/15/02, Peter Gibbs wrote:
>  > Is this still needed with the update to Parrot_allocate to use
>>  buffers? I think I took care of that.
>
>No, Parrot_allocate still sets buflen to the original requested 'size'; not
>the inflated 'req_size' - I'm not sure what you intended.

I intended it to return the inflated size. I just checked in a patch 
to do that.

>as the COW code depends on it - it needs to allocate a flag byte 
>within the buffer but outside the used space

This feels excessively hackish. It's OK if we were welding in COW to 
an existing code base, but we're not--if we put it in, we put it in 
right.

Right, in this case, is using the COW flag bit in the Buffer 
structure and making the changes to the appropriate string_* 
functions to use it, I think.
-- 
                                         Dan

--------------------------------------"it's like this"-------------------
Dan Sugalski                          even samurai
[EMAIL PROTECTED]                         have teddy bears and even
                                       teddy bears get drunk

Reply via email to