I've applied portions of this patch.  I omitted the parts which use the 
"byte" type, which isn't going to work on all platforms.

--Josh

At 1:46 on 03/28/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote:

> Attached patch fixes many of the warnings you see on MSVC level 4.  The
> ones listed below, this patch does *not* handle.
> 
> core.ops and rx.ops have some warnings about the use of MAKE_KEY, and the
> non-use of the variables returned by MAKE_KEY. I believe Steve Fink's
> patch fixes these.
> 
> 
> io_win32.c has the following problems:
> 
> PIO_win32_open's:
> int err = GetLastError();
> C:\p\parrot8\parrot\io\io_win32.c(157) :
> warning C4189: 'err' : local variable is initialized but not referenced
> 
> PIO_win32_read's:
> return -1;
> C:\p\parrot8\parrot\io\io_win32.c(224) : warning C4245: 'return' :
> conversion from 'const int ' to 'unsigned int ', signed/unsigned mismatch
> 
> PIO_win32_write's:
> return -1;
> C:\p\parrot8\parrot\io\io_win32.c(237) : warning C4245: 'return' :
> conversion from 'const int ' to 'unsigned int ', signed/unsigned mismatch
> 
> PIO_win32_read's:
> return -1;
> C:\p\parrot8\parrot\io\io_win32.c(224) : warning C4702: unreachable code
> 
> 
> Finally, the other, but less severe warnings, are:
> 
> key.c has an unreferenced function, debug_key.
> 
> misc.c has an unreferenced function, Pad_it.
> 
> resources.c has an unreferenced function, find_dead_strings. (I thought
> Dan said this wasn't needed anymore?)
> 
> Finally, we have parrot.c, a completely empty file. Does it have a
> purpose, or can it be removed?
> 
> Mike Lambert
> 


Reply via email to