Melvin Smith: # At 02:02 PM 3/10/2002 -0800, Brent Dax wrote: # >[EMAIL PROTECTED]: # ># cvsuser 02/03/10 13:15:50 # ># # ># Modified: lib/Parrot Assembler.pm # ># Log: # ># Minor patch to the assembler for the new_p_ic_ic opcode to # ># work same as new_p_ic (looks up a named class). # >Did Dan, Simon, or someone else ever approve these changes? # This isn't # >exactly just a little maintenence patch... # # To answer your question, no. I did mail the patch last night # in request for # response. # # I do disagree however, it is actually a very small patch. # # Did you read through it? # # Single line changes to add a size argument to a the constructors.
Small diff, big changes. A one-line diff in the right place can increase or decrease size or speed a thousandfold. This alters the design of PMCs in a way I think one of the designers should look at. # Dan and/or Simon or anyone else are welcome to roll them back, I felt # it was a light enough patch to commit, and if if someone screamed # at me at least it was better than the usual silence. :) Heh. --Brent Dax <[EMAIL PROTECTED]> @roles=map {"Parrot $_"} qw(embedding regexen Configure) #define private public --Spotted in a C++ program just before a #include