On Sun, Jan 13, 2002 at 02:14:08PM -0500, Dan Sugalski wrote: > So, I'm turning off the unused parameter warning for now to shut the .ops > file compiles up. After that point, all submitted patches must generate no > more warnings than were currently being generated, and all submitted > patches must *not* generate warnings in the areas they patch.
According to the letter of that, this patch isn't acceptable because it causes warnings not previously seen to appear. All the C files in classes/ weren't being compiled with an of the gcc warnings flags. With this patch they are, and there are an awful lot of warnings, more than I could hope to understand and clear up (within any sensible time period before submitting a rash of patches, by which time everyone else would have moved the code on) Pragmatically I believe it's better to apply it than not, but the raft of warnings it now creates will obscure any "real" new ones. Nicholas Clark -- ENOJOB http://www.ccl4.org/~nick/CV.html --- classes/Makefile.in.orig Sun Jan 13 20:21:41 2002 +++ classes/Makefile.in Mon Jan 14 22:34:44 2002 @@ -12,7 +12,7 @@ #DO NOT ADD C COMPILER FLAGS HERE #Add them in Configure.pl--look for the #comment 'ADD C COMPILER FLAGS HERE' -CFLAGS = ${ccflags} ${cc_debug} -I../include +CFLAGS = ${ccflags} ${cc_warn} ${cc_debug} -I../include C_LIBS = ${libs}
