At 1:30 on 09/18/2001 BST, Simon Cozens <[EMAIL PROTECTED]> wrote: > On Mon, Sep 17, 2001 at 10:38:35AM -0500, Jonathan Scott Duff wrote: > > Parrot/Opcode.pm only uses Digest::MD5 for fingerprinting the opcode > > file which could be done without Digest::MD5 IMHO. For instance, > > using unpack() to checksum the file. > > This is much cleaner. Thanks, applied.
Minor doc patch to that: Index: Parrot/Opcode.pm =================================================================== RCS file: /home/perlcvs/parrot/Parrot/Opcode.pm,v retrieving revision 1.6 diff -u -r1.6 Opcode.pm --- Parrot/Opcode.pm 2001/09/18 00:32:15 1.6 +++ Parrot/Opcode.pm 2001/09/18 01:17:52 @@ -54,6 +54,7 @@ sub fingerprint { _load(@_) unless defined $fingerprint; + print "FINGERPRINT IS $fingerprint\n"; return $fingerprint; } @@ -106,8 +107,9 @@ read_ops() takes an optional argument: the file to read the opcode table from. -The fingerprint() function returns the MD5 signature (in hex) of the -opcode table. +The fingerprint() function returns a checksum for the opcode table. It is +used to ensure that bytecode is only executed if it was generated for +a version of parrot supporting the appropriate opcodes. =cut package Parrot::Opcode;