Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 5b21271e64c2abe31f6f4d7663a6f2bd2b9e5936
      
https://github.com/Perl/perl5/commit/5b21271e64c2abe31f6f4d7663a6f2bd2b9e5936
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M regen/unicode_constants.pl
    M unicode_constants.h

  Log Message:
  -----------
  regen/unicode_constants: Create one for SHY

The soft hypen is treated specially in toke.c


  Commit: 2d683ad27b94ec683bdd6838978d13e913370792
      
https://github.com/Perl/perl5/commit/2d683ad27b94ec683bdd6838978d13e913370792
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M embed.fnc
    M proto.h
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Convert to flags parameter

This is in preparation for passing other options to this function


  Commit: 845e6ce6813232ff285a4ad8cf2da2040e3a38f7
      
https://github.com/Perl/perl5/commit/845e6ce6813232ff285a4ad8cf2da2040e3a38f7
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Add some comments, white space, braces

This function is complicated, without enough documentation for me to
understand the subtleties; I only studied it enough to change things I
needed to, or which became obvious to me in the process.  Other things
remain undocumented by this commit.

Some of the white space gives improper indentation which will fit a
future commit.

This commit also remove redundant parentheses in one statement


  Commit: e8be3b6fbc67382c18b5f625a655169f4ccdd7e2
      
https://github.com/Perl/perl5/commit/e8be3b6fbc67382c18b5f625a655169f4ccdd7e2
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Use mnemonic for soft hyphen code point


  Commit: ba37dad5ef51c7ccb19ce03177733ab94b8464b1
      
https://github.com/Perl/perl5/commit/ba37dad5ef51c7ccb19ce03177733ab94b8464b1
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Add a mnemonic instead of using -1

This makes things clearer.


  Commit: af8856a0a1d644d6bbb808215b8f49e37a9f693b
      
https://github.com/Perl/perl5/commit/af8856a0a1d644d6bbb808215b8f49e37a9f693b
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Add an assertion

That this had to be true was not obvious to me without studying closely
the code before it.  Adding an assertion will result in others deciding
they don't have to figure it out.


  Commit: 68eafa222256c10ea959f5b5bd5ac5739f6de472
      
https://github.com/Perl/perl5/commit/68eafa222256c10ea959f5b5bd5ac5739f6de472
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Swap conditionals order

It's clearer to handle the short case first, and put the much longer
case afterwards.


  Commit: 069cf82f437faacb478313d299bb0f8ac597e584
      
https://github.com/Perl/perl5/commit/069cf82f437faacb478313d299bb0f8ac597e584
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Swap another set of conditionals order

It's clearer to handle the short case first, and put the much longer
case afterwards.


  Commit: 26e7ae070f7041f869396c13b6c89923cdba747d
      
https://github.com/Perl/perl5/commit/26e7ae070f7041f869396c13b6c89923cdba747d
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Move declaractions close to first use

These were declared far above, due to C89 that is no longer a
constraint.


  Commit: 02ae424d11c11f3441147777ec3c1aa30ff1c13e
      
https://github.com/Perl/perl5/commit/02ae424d11c11f3441147777ec3c1aa30ff1c13e
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Remove unnecessary complexity

This check that the code just below won't look beyond the end of the
buffer, is rendered redundant by the "_safe" macro which does the
check itself.


  Commit: d35940abcceefca478c75f93b0cf8f2aee7f5dcb
      
https://github.com/Perl/perl5/commit/d35940abcceefca478c75f93b0cf8f2aee7f5dcb
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Collapse two loops

By setting a variable in advance, we can merge two loops into one.


  Commit: 10561716dc085c4733978598d678d7c4e7bbb644
      
https://github.com/Perl/perl5/commit/10561716dc085c4733978598d678d7c4e7bbb644
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Avoid a recalculation

Save the value from the first time into a variable


  Commit: 710a06ec9fb677d26a6aa1fb9caacaa1503562e3
      
https://github.com/Perl/perl5/commit/710a06ec9fb677d26a6aa1fb9caacaa1503562e3
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_parse_ident: Swap order of conditionals

I don't know what I was thinking when I recently thought these needed to
be in a different order.  The conjuctions are all &&, so might as well
do the simpler things first


  Commit: 3ee55a2097bd5d1f10c3b25c2e7900d3db72969e
      
https://github.com/Perl/perl5/commit/3ee55a2097bd5d1f10c3b25c2e7900d3db72969e
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_parse_ident: Add ability to start parse in middle

S_scan_ident would like to call this function, already having looked at
the first character of an identifier, and deciding it is legal.  It
wants this function to finish the scan.

This commit adds a flag to S_parse_ident to accommodate this.


  Commit: c0ca4c8d49699e4f071fa483f0027689f380cde6
      
https://github.com/Perl/perl5/commit/c0ca4c8d49699e4f071fa483f0027689f380cde6
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M t/comp/parser.t
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Char in middle needt not be IDStart

This fixes a bug in this function, in which it required the second
character in an identifier to be IDStart, instead of IDCont.  This
hasn't been caught because most identifiers are ASCII, and generally for
the purposes of this function in the ASCII range, all \w characters can
be IDStart.


  Commit: 3667766472f4cb5eb371ee767f5390bf7c4d6e68
      
https://github.com/Perl/perl5/commit/3667766472f4cb5eb371ee767f5390bf7c4d6e68
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_scan_ident: Add a check-only option

There is a bug here in which this function is called from S_intuit_more
just to see if there is an identifier in the string it is looking at.
But that call can have "subtle implications on parsing" (according to
the long-standing comments in it).  We need a way to call scan_ident
without side-effects.

This commit adds that capability.  The next will use it.


  Commit: 4eadf9a62fce11decdf054588c040ae20cbfb0ad
      
https://github.com/Perl/perl5/commit/4eadf9a62fce11decdf054588c040ae20cbfb0ad
  Author: Karl Williamson <[email protected]>
  Date:   2025-10-26 (Sun, 26 Oct 2025)

  Changed paths:
    M toke.c

  Log Message:
  -----------
  S_intuit_more:  Call scan_ident in check-only mode

This fixes the bug that examining the parse buffer had side-effects.  I
don't know what the implications of that were.


Compare: https://github.com/Perl/perl5/compare/4222a600225a...4eadf9a62fce

To unsubscribe from these emails, change your notification settings at 
https://github.com/Perl/perl5/settings/notifications

Reply via email to