Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: d83bd2549fce92d161cd621b02e1f3c83162a718
https://github.com/Perl/perl5/commit/d83bd2549fce92d161cd621b02e1f3c83162a718
Author: Lukas Mai <lukasmai....@gmail.com>
Date: 2025-07-23 (Wed, 23 Jul 2025)
Changed paths:
M regcomp_trie.c
Log Message:
-----------
regcomp_trie: stringify *tmp before accessing string fields
... such as SvCUR(*tmp) and SvUTF8(*tmp).
Fixes Coverity ID 582459: Evaluation order violation (EVALUATION_ORDER)
> read_write_order: In argument #3 of `Perl_pv_pretty(my_perl, sv, (char const
> *)Perl_SvPV_helper(my_perl, *tmp, NULL, 2U, SvPVnormal_type_,
> Perl_sv_2pv_flags, false, 32U), *({...; &((XPV *)({...; p_;}))->xpv_cur;}),
> colwidth, my_perl->Icolors[0], my_perl->Icolors[1], (((*tmp)->sv_flags &
> 0x20000000U) ? 256 : 0) | 0x800)`, a call is made to
> `Perl_SvPV_helper(my_perl, *tmp, NULL, 2U, SvPVnormal_type_,
> Perl_sv_2pv_flags, false, 32U)`. In argument #2 of this function, the object
> `(*tmp)->sv_flags` is modified. This object is also used in
> `(((*tmp)->sv_flags & 0x20000000U) ? 256 : 0) | 0x800`, the argument #8 of
> the outer function call. The order in which these arguments are evaluated is
> not specified, and will vary between platforms.
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
