Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 6a4f62c873462f8ef28a274bf807898fea203813
https://github.com/Perl/perl5/commit/6a4f62c873462f8ef28a274bf807898fea203813
Author: Lukas Mai <[email protected]>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M pod/perldiag.pod
M t/porting/diag.t
Log Message:
-----------
t/porting/diag.t: fix oversights in message extraction regex
- recognize the short form() as well as Perl_form()
- accept/ignore spaces between `Perl_croak(` and `aTHX_`
With this change, diag.t now recognizes several diagnostic messages that
went undetected previously (note the space before `aTHX_`):
- perlio.c
Perl_croak( aTHX_
"%s (%" UVuf ") does not match %s (%" UVuf ")",
Perl_croak( aTHX_
"%s (%" UVuf ") smaller than %s (%" UVuf ")",
- regcomp_trie.c
Perl_croak( aTHX_ "error creating/fetching widecharmap
entry for 0x%" UVXf, uvc );
default: Perl_croak( aTHX_ "panic! In trie construction, unknown
node type %u %s", (unsigned) flags, REGNODE_NAME(flags) );
Perl_croak( aTHX_ "panic! In trie construction, no
char mapping for %" IVdf, uvc );
This PR partially overlaps with #23017. Merging either will cause
conflicts in the other that will have to be resolved manually.
(In particular, if this PR is merged first, the diag.t changes from
#23017 can be dropped, as can some of the perldiag.pod additions. But
that PR also modifies the perlio.c messages, so their old forms added
here ("%s (%d) does not match %s (%d)", "%s (%d) smaller than %s (%d)")
will have to be deleted.)
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
