Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 4fe758bf0850369ae3e20d854070cd10b6f391b4
https://github.com/Perl/perl5/commit/4fe758bf0850369ae3e20d854070cd10b6f391b4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: bc958e319de484f61188912eae2574ab08c6c5a9
https://github.com/Perl/perl5/commit/bc958e319de484f61188912eae2574ab08c6c5a9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 09187ab6886ef6fdfe8eb0779d719056802e6699
https://github.com/Perl/perl5/commit/09187ab6886ef6fdfe8eb0779d719056802e6699
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 76d34fcbbf970821917f6c8fbde86a128774f307
https://github.com/Perl/perl5/commit/76d34fcbbf970821917f6c8fbde86a128774f307
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 290a528ae40be6428c218b90fda73f2aa857acb0
https://github.com/Perl/perl5/commit/290a528ae40be6428c218b90fda73f2aa857acb0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: a76ab83aac6a29bd50db37a9fafbc47653f0021c
https://github.com/Perl/perl5/commit/a76ab83aac6a29bd50db37a9fafbc47653f0021c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 1b05f15da3e7e45c6513d4e460780a731b2e60ea
https://github.com/Perl/perl5/commit/1b05f15da3e7e45c6513d4e460780a731b2e60ea
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: e14f2fee0a939d9da319a2f7b63c54ecc4a47093
https://github.com/Perl/perl5/commit/e14f2fee0a939d9da319a2f7b63c54ecc4a47093
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 65662074745d3e6788c16b5f58bab1ce9a67bcb7
https://github.com/Perl/perl5/commit/65662074745d3e6788c16b5f58bab1ce9a67bcb7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 1a97a1b811f9e177637e0a39d8d1b84b2f2ae191
https://github.com/Perl/perl5/commit/1a97a1b811f9e177637e0a39d8d1b84b2f2ae191
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 8b8d4b21c4d5804f9de6deb341605a1dc412eb76
https://github.com/Perl/perl5/commit/8b8d4b21c4d5804f9de6deb341605a1dc412eb76
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 81c71f71c1829f734cfec4d448caa4e79101e6e1
https://github.com/Perl/perl5/commit/81c71f71c1829f734cfec4d448caa4e79101e6e1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a19c500875a3c248befb926c0f343df3e3996a3b
https://github.com/Perl/perl5/commit/a19c500875a3c248befb926c0f343df3e3996a3b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 61018644071211b0e587b4e16c593b2d9529e927
https://github.com/Perl/perl5/commit/61018644071211b0e587b4e16c593b2d9529e927
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 835046384ec21185d6436a38078ee40d08f92b9d
https://github.com/Perl/perl5/commit/835046384ec21185d6436a38078ee40d08f92b9d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 73fcd6575b03bee37af8c3937a47f784116d314e
https://github.com/Perl/perl5/commit/73fcd6575b03bee37af8c3937a47f784116d314e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 8c20d4f5caa1e00011a6276fc25440add8eae219
https://github.com/Perl/perl5/commit/8c20d4f5caa1e00011a6276fc25440add8eae219
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: fffbfbc6b1f898a1e01793b5ac146c03a5654863
https://github.com/Perl/perl5/commit/fffbfbc6b1f898a1e01793b5ac146c03a5654863
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: cce57f88fd5d553263dd5aa40626925a4ebda44e
https://github.com/Perl/perl5/commit/cce57f88fd5d553263dd5aa40626925a4ebda44e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: da4725022e6204f64cd6a2700fbf1588d5c9992d
https://github.com/Perl/perl5/commit/da4725022e6204f64cd6a2700fbf1588d5c9992d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: caa87c20582a1c7ff777745422e579e29bf7fe9e
https://github.com/Perl/perl5/commit/caa87c20582a1c7ff777745422e579e29bf7fe9e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 265257e319747ae3c6979dad0afd50798f0974bc
https://github.com/Perl/perl5/commit/265257e319747ae3c6979dad0afd50798f0974bc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 53594e6aea2ea1ed7e821a5ca5c719a700ead98a
https://github.com/Perl/perl5/commit/53594e6aea2ea1ed7e821a5ca5c719a700ead98a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 1c8ad13b0b48fefce4f48a45fe362c60de7be7fc
https://github.com/Perl/perl5/commit/1c8ad13b0b48fefce4f48a45fe362c60de7be7fc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 7cb24dcb5a4446931efa33bc4d4478fb40af8cc0
https://github.com/Perl/perl5/commit/7cb24dcb5a4446931efa33bc4d4478fb40af8cc0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 466d78f961128fbbbb51a7bcc293bdb748043ab4
https://github.com/Perl/perl5/commit/466d78f961128fbbbb51a7bcc293bdb748043ab4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 4a901d045b963db78ea61c0d3ee9a2c8be1c95fe
https://github.com/Perl/perl5/commit/4a901d045b963db78ea61c0d3ee9a2c8be1c95fe
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: ae480fee43c841d67324fa57f97a73b1d09a9bc7
https://github.com/Perl/perl5/commit/ae480fee43c841d67324fa57f97a73b1d09a9bc7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 1ed32cbee1c6e59ce2e124b245e1086973b8eb09
https://github.com/Perl/perl5/commit/1ed32cbee1c6e59ce2e124b245e1086973b8eb09
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 38fa34fff5bd097dbf42bbfd2310e106b474f344
https://github.com/Perl/perl5/commit/38fa34fff5bd097dbf42bbfd2310e106b474f344
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: a2a7dcb65653dadc9a45d604cc9f1429af4d478a
https://github.com/Perl/perl5/commit/a2a7dcb65653dadc9a45d604cc9f1429af4d478a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 7ef5e25f82fca7f813a4cea1e4ce3c824e4f2f62
https://github.com/Perl/perl5/commit/7ef5e25f82fca7f813a4cea1e4ce3c824e4f2f62
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 013af96611697fcebd104d71dce55b978e38aeb7
https://github.com/Perl/perl5/commit/013af96611697fcebd104d71dce55b978e38aeb7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: b70ece7a08967564a29aa498e64dcab3cd80a6da
https://github.com/Perl/perl5/commit/b70ece7a08967564a29aa498e64dcab3cd80a6da
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: d1790e147fe4aef564fbfa1b4d518feae257d4cc
https://github.com/Perl/perl5/commit/d1790e147fe4aef564fbfa1b4d518feae257d4cc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a9bd8e36a2a0e68c26e4885315ffc837283cf375
https://github.com/Perl/perl5/commit/a9bd8e36a2a0e68c26e4885315ffc837283cf375
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 443f76de47111f57ee4984c86ec7b79379cb55e9
https://github.com/Perl/perl5/commit/443f76de47111f57ee4984c86ec7b79379cb55e9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: bd00f6f524594923a6705e22de4eef81a52cd6c7
https://github.com/Perl/perl5/commit/bd00f6f524594923a6705e22de4eef81a52cd6c7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 33d6a1cece128d40d6df68b839863ec85ee3b39a
https://github.com/Perl/perl5/commit/33d6a1cece128d40d6df68b839863ec85ee3b39a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: a37d187fe9ab80be419a37e00ed35f686e393d80
https://github.com/Perl/perl5/commit/a37d187fe9ab80be419a37e00ed35f686e393d80
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 76e3be23122c7bc638f5aea2bcee4b12b7cf9b78
https://github.com/Perl/perl5/commit/76e3be23122c7bc638f5aea2bcee4b12b7cf9b78
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 18c4145e8c7d67fbac992ca98d66826ad54318dc
https://github.com/Perl/perl5/commit/18c4145e8c7d67fbac992ca98d66826ad54318dc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: e106daf0dddff5bbfdfef12b22cfeef9f284e116
https://github.com/Perl/perl5/commit/e106daf0dddff5bbfdfef12b22cfeef9f284e116
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 0b9f93240635c8d4abe203dc32371dfda09e4a82
https://github.com/Perl/perl5/commit/0b9f93240635c8d4abe203dc32371dfda09e4a82
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: a3993d8a7f498dca4f554e2434e2040241a6d2a3
https://github.com/Perl/perl5/commit/a3993d8a7f498dca4f554e2434e2040241a6d2a3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: ea4b2c7bf08eb6c928d8a3516dde3f29b5c49a27
https://github.com/Perl/perl5/commit/ea4b2c7bf08eb6c928d8a3516dde3f29b5c49a27
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 7625f34ec57f2dde65d61913383fa1e005a60413
https://github.com/Perl/perl5/commit/7625f34ec57f2dde65d61913383fa1e005a60413
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 0f8de6b183ee9d058bdd1754ee5c9f74a744fcd7
https://github.com/Perl/perl5/commit/0f8de6b183ee9d058bdd1754ee5c9f74a744fcd7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: d3215e985f3360a06e9ac73c31b8903e9e875939
https://github.com/Perl/perl5/commit/d3215e985f3360a06e9ac73c31b8903e9e875939
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: b1ea487cc3751adcc2086a3825e6aafd587a84f7
https://github.com/Perl/perl5/commit/b1ea487cc3751adcc2086a3825e6aafd587a84f7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 6b1b595156d42703c13a4d2fa981d8fd8f456e21
https://github.com/Perl/perl5/commit/6b1b595156d42703c13a4d2fa981d8fd8f456e21
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: a35f5c2938888c16efeb3cc797ee9cb3a2168f53
https://github.com/Perl/perl5/commit/a35f5c2938888c16efeb3cc797ee9cb3a2168f53
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 8096dc95557e2c0419e52e817bb7791904a2069b
https://github.com/Perl/perl5/commit/8096dc95557e2c0419e52e817bb7791904a2069b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 6f9373821f18f19910b7da287286d4d3b01f6225
https://github.com/Perl/perl5/commit/6f9373821f18f19910b7da287286d4d3b01f6225
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 53030a60eadd4f8f225235bc5f0616c836dfe317
https://github.com/Perl/perl5/commit/53030a60eadd4f8f225235bc5f0616c836dfe317
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 2638e45279bb241a7589795095b92db904221e3e
https://github.com/Perl/perl5/commit/2638e45279bb241a7589795095b92db904221e3e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 3e58f7740dbb1af8ebae21234add85da9ab30712
https://github.com/Perl/perl5/commit/3e58f7740dbb1af8ebae21234add85da9ab30712
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 836f3febbf0f5756230c287206aa42c01822436c
https://github.com/Perl/perl5/commit/836f3febbf0f5756230c287206aa42c01822436c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: eabb3793bb657fd6abfb88b7033dd87884b4a25f
https://github.com/Perl/perl5/commit/eabb3793bb657fd6abfb88b7033dd87884b4a25f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: de9b21537fcff5c9ed2cd84ec521e802f15382a1
https://github.com/Perl/perl5/commit/de9b21537fcff5c9ed2cd84ec521e802f15382a1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 302ad400b16ffcfd00d08611b578ef6c646c1d88
https://github.com/Perl/perl5/commit/302ad400b16ffcfd00d08611b578ef6c646c1d88
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c7aee79b6c079e24d10f913cb1ad004bb9eda1c1
https://github.com/Perl/perl5/commit/c7aee79b6c079e24d10f913cb1ad004bb9eda1c1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 66c30980a6f442560b2f5f4fcb5792702ade4064
https://github.com/Perl/perl5/commit/66c30980a6f442560b2f5f4fcb5792702ade4064
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: fe58165c34bce33247da36e8f1e933074b253bd3
https://github.com/Perl/perl5/commit/fe58165c34bce33247da36e8f1e933074b253bd3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: acedd1c74516e57985d13890974c88ba97268a86
https://github.com/Perl/perl5/commit/acedd1c74516e57985d13890974c88ba97268a86
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: a92156e15f05b670e06df42d62617eca452832d4
https://github.com/Perl/perl5/commit/a92156e15f05b670e06df42d62617eca452832d4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: bbe11a28aae316f1cebeb68e1c92451fbc8bbe8e
https://github.com/Perl/perl5/commit/bbe11a28aae316f1cebeb68e1c92451fbc8bbe8e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: f6547b3be747faa86da9935bfd20482a0226e077
https://github.com/Perl/perl5/commit/f6547b3be747faa86da9935bfd20482a0226e077
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 1f1a0a5056d11abf0d77199f2da79ce1d480d74b
https://github.com/Perl/perl5/commit/1f1a0a5056d11abf0d77199f2da79ce1d480d74b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 00e1a1e21885164ac203f9c6f67dee1a4c3e97d3
https://github.com/Perl/perl5/commit/00e1a1e21885164ac203f9c6f67dee1a4c3e97d3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 0166c5af17ac1b950e2209164bcc17e1c7da446f
https://github.com/Perl/perl5/commit/0166c5af17ac1b950e2209164bcc17e1c7da446f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: a6dc654299efbba1fde7a9f515595f44f7f1aa0f
https://github.com/Perl/perl5/commit/a6dc654299efbba1fde7a9f515595f44f7f1aa0f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 8eb49df7c72ac30ebf256ed0b5611a8c92d5d94d
https://github.com/Perl/perl5/commit/8eb49df7c72ac30ebf256ed0b5611a8c92d5d94d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 249f462bbccb6b76b8379fa71d1af7a25ee1f035
https://github.com/Perl/perl5/commit/249f462bbccb6b76b8379fa71d1af7a25ee1f035
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 414aa12810af9462129837a0a736d461fb850cb0
https://github.com/Perl/perl5/commit/414aa12810af9462129837a0a736d461fb850cb0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: ac629e8f75e90c5a23fa1a5267d6de9ebc085e82
https://github.com/Perl/perl5/commit/ac629e8f75e90c5a23fa1a5267d6de9ebc085e82
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 73347a634dde8de077d690800b087eb0c787b85b
https://github.com/Perl/perl5/commit/73347a634dde8de077d690800b087eb0c787b85b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9c93a9afdf870983e47df569997d0218d772c73a
https://github.com/Perl/perl5/commit/9c93a9afdf870983e47df569997d0218d772c73a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 79a98f8dd0d17468ad45a229d107bd09cda98e2c
https://github.com/Perl/perl5/commit/79a98f8dd0d17468ad45a229d107bd09cda98e2c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: a62b16b85cde8e31a73ccc0d10625435d1f63260
https://github.com/Perl/perl5/commit/a62b16b85cde8e31a73ccc0d10625435d1f63260
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 38dcee855f022987e70cec4b06bd1208ea86af09
https://github.com/Perl/perl5/commit/38dcee855f022987e70cec4b06bd1208ea86af09
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 7afb8a29e1b7dfcab93655088118e198eb1f122c
https://github.com/Perl/perl5/commit/7afb8a29e1b7dfcab93655088118e198eb1f122c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: e21e8223a0c47aec6d9e812ad8d1eb6544656e48
https://github.com/Perl/perl5/commit/e21e8223a0c47aec6d9e812ad8d1eb6544656e48
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: d6bac4dec382981ff24ce8dbafcc0bb8f4126686
https://github.com/Perl/perl5/commit/d6bac4dec382981ff24ce8dbafcc0bb8f4126686
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: a1902748bf4872a13f36efe8c2e5fd97ad2814ed
https://github.com/Perl/perl5/commit/a1902748bf4872a13f36efe8c2e5fd97ad2814ed
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: c62c038a01bddd0307da3d3981fc999d74917cf7
https://github.com/Perl/perl5/commit/c62c038a01bddd0307da3d3981fc999d74917cf7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: ee3fbda4aec4107f053340e15bfaa28f398983fa
https://github.com/Perl/perl5/commit/ee3fbda4aec4107f053340e15bfaa28f398983fa
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 4136c835a6e30a9ff4e67406ab801561ef593753
https://github.com/Perl/perl5/commit/4136c835a6e30a9ff4e67406ab801561ef593753
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 0cbc6361fa9bf89d75f358ba977425dde6feeab2
https://github.com/Perl/perl5/commit/0cbc6361fa9bf89d75f358ba977425dde6feeab2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 51c6fc1989e8eba2d15a6dc29e3885d4f5891933
https://github.com/Perl/perl5/commit/51c6fc1989e8eba2d15a6dc29e3885d4f5891933
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 2ef091f279135a28de539728f8b88dbc5fb4db16
https://github.com/Perl/perl5/commit/2ef091f279135a28de539728f8b88dbc5fb4db16
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: ea49eeb1763ee7722f16bb196e678601e9e836c1
https://github.com/Perl/perl5/commit/ea49eeb1763ee7722f16bb196e678601e9e836c1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: a0a7d23966ec3006d2b45af43577355add0d9d1e
https://github.com/Perl/perl5/commit/a0a7d23966ec3006d2b45af43577355add0d9d1e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: a224eff1e9f9063649c51d1c0a002992c117dce9
https://github.com/Perl/perl5/commit/a224eff1e9f9063649c51d1c0a002992c117dce9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 6886991f2ac65468bee3a26c6168d81603ee7617
https://github.com/Perl/perl5/commit/6886991f2ac65468bee3a26c6168d81603ee7617
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: b39dbf4736580cfc4d399f99dfa114eedf88e633
https://github.com/Perl/perl5/commit/b39dbf4736580cfc4d399f99dfa114eedf88e633
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: d89a68b3be1add59f0e3e83030159fce1dcbc0b5
https://github.com/Perl/perl5/commit/d89a68b3be1add59f0e3e83030159fce1dcbc0b5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: b2f0e8310d3602c2ed80d0b07a8bac317ea2766f
https://github.com/Perl/perl5/commit/b2f0e8310d3602c2ed80d0b07a8bac317ea2766f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: de2e7fd6f546ecd24add6143c256a2922b87e565
https://github.com/Perl/perl5/commit/de2e7fd6f546ecd24add6143c256a2922b87e565
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 73b146d238e73fea42c5d8fb09a7bc02cf8797c5
https://github.com/Perl/perl5/commit/73b146d238e73fea42c5d8fb09a7bc02cf8797c5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 745910a6d5c37d7896296e08223051c8313ab887
https://github.com/Perl/perl5/commit/745910a6d5c37d7896296e08223051c8313ab887
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: cf53ed03aa03c79c0fa85505e8b682fd39605e02
https://github.com/Perl/perl5/commit/cf53ed03aa03c79c0fa85505e8b682fd39605e02
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: a9ce62eddffd2dc6737acaf3c4e2dcd1dcaa1fc4
https://github.com/Perl/perl5/commit/a9ce62eddffd2dc6737acaf3c4e2dcd1dcaa1fc4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 17de113a040a986c46c1f3aac0cbeca51137b684
https://github.com/Perl/perl5/commit/17de113a040a986c46c1f3aac0cbeca51137b684
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 5d8dd030a7b07f5ea8e37a449e293e761b455606
https://github.com/Perl/perl5/commit/5d8dd030a7b07f5ea8e37a449e293e761b455606
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 5ae1ade7db102aba1480fd839f2c8cadc751e90c
https://github.com/Perl/perl5/commit/5ae1ade7db102aba1480fd839f2c8cadc751e90c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: cfeeff90216ab2945f61ca71a34f0928775191c1
https://github.com/Perl/perl5/commit/cfeeff90216ab2945f61ca71a34f0928775191c1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: cdb165627b7d8c7cb6e18c9f6d8f9d29c6bc8474
https://github.com/Perl/perl5/commit/cdb165627b7d8c7cb6e18c9f6d8f9d29c6bc8474
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: ce280500ef4e54793a937ce26929bafc53389feb
https://github.com/Perl/perl5/commit/ce280500ef4e54793a937ce26929bafc53389feb
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 92f945650585501780bf32107ea8b0863fc9b90a
https://github.com/Perl/perl5/commit/92f945650585501780bf32107ea8b0863fc9b90a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: fcf422923e2ddece9cc86b2a57b6c6e695ee5621
https://github.com/Perl/perl5/commit/fcf422923e2ddece9cc86b2a57b6c6e695ee5621
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 461921d25f5158a5878dcc302dca71d614e926c5
https://github.com/Perl/perl5/commit/461921d25f5158a5878dcc302dca71d614e926c5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 240a9b766a749a11ed7a6666909e06d437de41e1
https://github.com/Perl/perl5/commit/240a9b766a749a11ed7a6666909e06d437de41e1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 072531ea7d25f2157cba73b684419052643792ff
https://github.com/Perl/perl5/commit/072531ea7d25f2157cba73b684419052643792ff
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 7fd0636fc50a542ca5e4f3cdb1960218ad8ec5e2
https://github.com/Perl/perl5/commit/7fd0636fc50a542ca5e4f3cdb1960218ad8ec5e2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: c28bfa9513debe95a9ba2e079345bc8abfdeff76
https://github.com/Perl/perl5/commit/c28bfa9513debe95a9ba2e079345bc8abfdeff76
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 12465ba7b78a5b1732bec1e1487695d68ed97041
https://github.com/Perl/perl5/commit/12465ba7b78a5b1732bec1e1487695d68ed97041
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 645f7fcabadf3dabfadea2ccedce29eb267de7bd
https://github.com/Perl/perl5/commit/645f7fcabadf3dabfadea2ccedce29eb267de7bd
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 8cd0355d50229ee87108d1fab929914688a42eec
https://github.com/Perl/perl5/commit/8cd0355d50229ee87108d1fab929914688a42eec
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 63b9a0430cf929eda5ccd8e8bc54f5e96155f2df
https://github.com/Perl/perl5/commit/63b9a0430cf929eda5ccd8e8bc54f5e96155f2df
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 21b7116d2c55c6e545383ae548759466e4178e78
https://github.com/Perl/perl5/commit/21b7116d2c55c6e545383ae548759466e4178e78
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: fccb8eaa8854b96390cec27032b933a2cb897d1f
https://github.com/Perl/perl5/commit/fccb8eaa8854b96390cec27032b933a2cb897d1f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: b98f102a0745464bfe54b349c9260d63fd9d39b5
https://github.com/Perl/perl5/commit/b98f102a0745464bfe54b349c9260d63fd9d39b5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: f8ba1d1e165f40c602bc6282d2e9cbb3e71c1349
https://github.com/Perl/perl5/commit/f8ba1d1e165f40c602bc6282d2e9cbb3e71c1349
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 41428beaf8056b65d47903e55f401769398f738c
https://github.com/Perl/perl5/commit/41428beaf8056b65d47903e55f401769398f738c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: fc893d75a4a9e069fd3ed66e02d84abd9638aa8a
https://github.com/Perl/perl5/commit/fc893d75a4a9e069fd3ed66e02d84abd9638aa8a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 21bcbe5eecc0c3b3899f2fd5d51d1e494a96b5ee
https://github.com/Perl/perl5/commit/21bcbe5eecc0c3b3899f2fd5d51d1e494a96b5ee
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 58d41f1856b998dd1e48552b3926e00e80b9279f
https://github.com/Perl/perl5/commit/58d41f1856b998dd1e48552b3926e00e80b9279f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: e22e48d3983a8f236a875055a25d1d60a1b57604
https://github.com/Perl/perl5/commit/e22e48d3983a8f236a875055a25d1d60a1b57604
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 280238256d6bab49e80af3e006928b2f597e59b8
https://github.com/Perl/perl5/commit/280238256d6bab49e80af3e006928b2f597e59b8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 69129fc8435b7d7ff96f65b4645af9882e9f062d
https://github.com/Perl/perl5/commit/69129fc8435b7d7ff96f65b4645af9882e9f062d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 6aa59b574587160d8e4d7d35f3e60cdc84779989
https://github.com/Perl/perl5/commit/6aa59b574587160d8e4d7d35f3e60cdc84779989
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 1e4c699a0e3be12068058f4ce57558854f288f5f
https://github.com/Perl/perl5/commit/1e4c699a0e3be12068058f4ce57558854f288f5f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 6bb2352bf5c732241c0592cee4e3ded443d3b480
https://github.com/Perl/perl5/commit/6bb2352bf5c732241c0592cee4e3ded443d3b480
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 19ffb2eedb9bd64e68e05734aa5fc8cfb5992aaf
https://github.com/Perl/perl5/commit/19ffb2eedb9bd64e68e05734aa5fc8cfb5992aaf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 29606883e9a4d7814664ce04b040ae27e85f95e8
https://github.com/Perl/perl5/commit/29606883e9a4d7814664ce04b040ae27e85f95e8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 88cb604abef12e3018ed4108bfd4c67247d9754a
https://github.com/Perl/perl5/commit/88cb604abef12e3018ed4108bfd4c67247d9754a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 52cf475b1e60a3d18aea60362ce8e1fa5b258b8b
https://github.com/Perl/perl5/commit/52cf475b1e60a3d18aea60362ce8e1fa5b258b8b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 8a75898867dcb2dc416a151169b5eca1c37ca75e
https://github.com/Perl/perl5/commit/8a75898867dcb2dc416a151169b5eca1c37ca75e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: c476447117591d9d04986add04a19af895091f60
https://github.com/Perl/perl5/commit/c476447117591d9d04986add04a19af895091f60
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: c324c15534fbcce5979f4c681740251925980182
https://github.com/Perl/perl5/commit/c324c15534fbcce5979f4c681740251925980182
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 61a3eccb91775be6c2fd428418fa7dc3abc5f8ff
https://github.com/Perl/perl5/commit/61a3eccb91775be6c2fd428418fa7dc3abc5f8ff
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 7d21546a9b4984e8010ae734b606b7f3981a7e3a
https://github.com/Perl/perl5/commit/7d21546a9b4984e8010ae734b606b7f3981a7e3a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 7b883d60c4e4fbb4c9287b0336dd6a90e324d305
https://github.com/Perl/perl5/commit/7b883d60c4e4fbb4c9287b0336dd6a90e324d305
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: c8d8d6073af4bd38f846b88c1ba114287ca1efad
https://github.com/Perl/perl5/commit/c8d8d6073af4bd38f846b88c1ba114287ca1efad
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 44715c8ebdecda87b313f8c87d8a3ebd0c28c4b4
https://github.com/Perl/perl5/commit/44715c8ebdecda87b313f8c87d8a3ebd0c28c4b4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 1b5e3fbce54359e095f0d0b066b300a1a22baa06
https://github.com/Perl/perl5/commit/1b5e3fbce54359e095f0d0b066b300a1a22baa06
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: c92669d2be5c05fe8296107a16456244ea4d7eeb
https://github.com/Perl/perl5/commit/c92669d2be5c05fe8296107a16456244ea4d7eeb
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 90dc8819f17ec34389341f2a59912ffa3c901bdd
https://github.com/Perl/perl5/commit/90dc8819f17ec34389341f2a59912ffa3c901bdd
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 9ad89c4591383ccee6d20fd4eab3dd6d91fa3a62
https://github.com/Perl/perl5/commit/9ad89c4591383ccee6d20fd4eab3dd6d91fa3a62
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 0ad46b54cf85a84ffad5bd45be82f6f561e198af
https://github.com/Perl/perl5/commit/0ad46b54cf85a84ffad5bd45be82f6f561e198af
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 812b543abc61e932f02df740c4f221f4ad23dc61
https://github.com/Perl/perl5/commit/812b543abc61e932f02df740c4f221f4ad23dc61
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 85b2e330769874dc6505b9cac5912da9468a9cc6
https://github.com/Perl/perl5/commit/85b2e330769874dc6505b9cac5912da9468a9cc6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: ac1f0b2b287f431dba3091f98828d2307f1aa5c4
https://github.com/Perl/perl5/commit/ac1f0b2b287f431dba3091f98828d2307f1aa5c4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: de9fbe09847a755d9e6af506f3d11a151227ef32
https://github.com/Perl/perl5/commit/de9fbe09847a755d9e6af506f3d11a151227ef32
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: fd736b67207b4e01b8ef072fa9d295edc602977e
https://github.com/Perl/perl5/commit/fd736b67207b4e01b8ef072fa9d295edc602977e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: ccff49d4260897ef64ea2ba9104e4b45cdf99e03
https://github.com/Perl/perl5/commit/ccff49d4260897ef64ea2ba9104e4b45cdf99e03
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: ab586191ef59d70fef94eccd10fb25279ff43fa2
https://github.com/Perl/perl5/commit/ab586191ef59d70fef94eccd10fb25279ff43fa2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 668f9ea60bcbfd4e18f2821ba2657435656673b4
https://github.com/Perl/perl5/commit/668f9ea60bcbfd4e18f2821ba2657435656673b4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 2a54057248d0010672d155ea0cb94398b4e62c55
https://github.com/Perl/perl5/commit/2a54057248d0010672d155ea0cb94398b4e62c55
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 34f442f00881cd5c9e06cfec5bdfee674913a08b
https://github.com/Perl/perl5/commit/34f442f00881cd5c9e06cfec5bdfee674913a08b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 75e5670a140542e83ee2d31dd51d7143e3cbdde9
https://github.com/Perl/perl5/commit/75e5670a140542e83ee2d31dd51d7143e3cbdde9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: f582fef5575a7733b59d6e4a984f34a21197fdb4
https://github.com/Perl/perl5/commit/f582fef5575a7733b59d6e4a984f34a21197fdb4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: cad501339951bac8067503324ecd9c470813ec29
https://github.com/Perl/perl5/commit/cad501339951bac8067503324ecd9c470813ec29
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 7d04d0361c22d76f5c071611d11e357dc1f1681e
https://github.com/Perl/perl5/commit/7d04d0361c22d76f5c071611d11e357dc1f1681e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 332ffa55a4d10e38e937a9e1b345ba3b0a483587
https://github.com/Perl/perl5/commit/332ffa55a4d10e38e937a9e1b345ba3b0a483587
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 1080621ae2d5ad29fefc44c5fe97ff7c18ad96ce
https://github.com/Perl/perl5/commit/1080621ae2d5ad29fefc44c5fe97ff7c18ad96ce
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: b6d8914d089d3abefcc463044f499d2ef2e252e2
https://github.com/Perl/perl5/commit/b6d8914d089d3abefcc463044f499d2ef2e252e2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: af10712cbabf4265485c906b351ede61bc9eceaf
https://github.com/Perl/perl5/commit/af10712cbabf4265485c906b351ede61bc9eceaf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 13803a87823058c47bbc4a89e6f98d8b8013dceb
https://github.com/Perl/perl5/commit/13803a87823058c47bbc4a89e6f98d8b8013dceb
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 34027a3f4c1fcaa70c467186fb6812758f5e415d
https://github.com/Perl/perl5/commit/34027a3f4c1fcaa70c467186fb6812758f5e415d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 6f25e0faf0605dc9aeacc261f6802200675b1df7
https://github.com/Perl/perl5/commit/6f25e0faf0605dc9aeacc261f6802200675b1df7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 14cde76340e2edae5ff355ec43011c675bc1e0fb
https://github.com/Perl/perl5/commit/14cde76340e2edae5ff355ec43011c675bc1e0fb
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: a57be0f28d9c0bd01af836e0972559f8e7f8200d
https://github.com/Perl/perl5/commit/a57be0f28d9c0bd01af836e0972559f8e7f8200d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 96f0bd0bcdc20fbc491e3bbb464239c7e1c02dfc
https://github.com/Perl/perl5/commit/96f0bd0bcdc20fbc491e3bbb464239c7e1c02dfc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: b647259a7f1d620e6750007f8945e3b3e0164477
https://github.com/Perl/perl5/commit/b647259a7f1d620e6750007f8945e3b3e0164477
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: bbf3858069461df53ef3c7bb3c8c91660d4ca72f
https://github.com/Perl/perl5/commit/bbf3858069461df53ef3c7bb3c8c91660d4ca72f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: b181d75f4d0fd8320104203d574a89e3e29e8284
https://github.com/Perl/perl5/commit/b181d75f4d0fd8320104203d574a89e3e29e8284
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: d7acc57449643d7e290193825eedd1be19a22547
https://github.com/Perl/perl5/commit/d7acc57449643d7e290193825eedd1be19a22547
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 0445123280a831df83948f8e12e3d990e111fce3
https://github.com/Perl/perl5/commit/0445123280a831df83948f8e12e3d990e111fce3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 7cca2298b845936bd86ed7c561aaedb942ee18ce
https://github.com/Perl/perl5/commit/7cca2298b845936bd86ed7c561aaedb942ee18ce
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: b5f933d8fcfec2319da75b770a57d6b37a406973
https://github.com/Perl/perl5/commit/b5f933d8fcfec2319da75b770a57d6b37a406973
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: c5c2bf134945cb8b50eb4db0be9b31dc606e723b
https://github.com/Perl/perl5/commit/c5c2bf134945cb8b50eb4db0be9b31dc606e723b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: c356f627ffebd1bf17cc8a112ab41be2715718e9
https://github.com/Perl/perl5/commit/c356f627ffebd1bf17cc8a112ab41be2715718e9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 5a102018bc59dde2491bfab21c935ba09f58836b
https://github.com/Perl/perl5/commit/5a102018bc59dde2491bfab21c935ba09f58836b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 3c62d21dd9e854b3c26a214159272e92ce8d4542
https://github.com/Perl/perl5/commit/3c62d21dd9e854b3c26a214159272e92ce8d4542
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: fb0fe3a1a7e90cf396df5e27e0575a6557100ce3
https://github.com/Perl/perl5/commit/fb0fe3a1a7e90cf396df5e27e0575a6557100ce3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e50556b129d721acc5fde3ea705f0f4369b16fe6
https://github.com/Perl/perl5/commit/e50556b129d721acc5fde3ea705f0f4369b16fe6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5b640d9a97c5e7449c80a200ff80af2a664daa6a
https://github.com/Perl/perl5/commit/5b640d9a97c5e7449c80a200ff80af2a664daa6a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 8a8efa6772fceeb7f252ca0f8fdc3c6188e9bd6d
https://github.com/Perl/perl5/commit/8a8efa6772fceeb7f252ca0f8fdc3c6188e9bd6d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: f79053a8258a440b623d686bfabffe7a171a7522
https://github.com/Perl/perl5/commit/f79053a8258a440b623d686bfabffe7a171a7522
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 4d23c73f6ef9ebaf9af2673d6516f6573b3bff1d
https://github.com/Perl/perl5/commit/4d23c73f6ef9ebaf9af2673d6516f6573b3bff1d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: eef91b49804112e4195de793bfd29b2468fa5fde
https://github.com/Perl/perl5/commit/eef91b49804112e4195de793bfd29b2468fa5fde
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: d8307d9f91ae1fcc0c61542febc878001fa9827c
https://github.com/Perl/perl5/commit/d8307d9f91ae1fcc0c61542febc878001fa9827c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 28f529616454c5053896e2e4fb8b189cacd1951a
https://github.com/Perl/perl5/commit/28f529616454c5053896e2e4fb8b189cacd1951a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 740ab58cee7fb18a63dbdef3c2077a8e1af4ae51
https://github.com/Perl/perl5/commit/740ab58cee7fb18a63dbdef3c2077a8e1af4ae51
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 445b20ed6fd2f00e81a425f54bea96e3a35d5fbf
https://github.com/Perl/perl5/commit/445b20ed6fd2f00e81a425f54bea96e3a35d5fbf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 3970983e9847ba8d514bd6054694a3c47346f2be
https://github.com/Perl/perl5/commit/3970983e9847ba8d514bd6054694a3c47346f2be
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 3a6b11d253ff5a1f97af1e29d8699d7519bc4a3c
https://github.com/Perl/perl5/commit/3a6b11d253ff5a1f97af1e29d8699d7519bc4a3c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 853a57ba7cd4bb414277a6712e8d14dd86c6e508
https://github.com/Perl/perl5/commit/853a57ba7cd4bb414277a6712e8d14dd86c6e508
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c5f6cbc1b1b7473bd6b471379b52c5e82c6edfa5
https://github.com/Perl/perl5/commit/c5f6cbc1b1b7473bd6b471379b52c5e82c6edfa5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 85e03076749495aa4049bdc39e863139e7419d9b
https://github.com/Perl/perl5/commit/85e03076749495aa4049bdc39e863139e7419d9b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 2eed530afe1eb04c17a25d931926a6eb93f28532
https://github.com/Perl/perl5/commit/2eed530afe1eb04c17a25d931926a6eb93f28532
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 72fafcfdcb26633f07354a9d408d1f4533c3e3b9
https://github.com/Perl/perl5/commit/72fafcfdcb26633f07354a9d408d1f4533c3e3b9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 5178e05f92b5849bb9714b0f4e28968f9935bc0c
https://github.com/Perl/perl5/commit/5178e05f92b5849bb9714b0f4e28968f9935bc0c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 1a15e1a9374d0ded5317c003223635efedb06664
https://github.com/Perl/perl5/commit/1a15e1a9374d0ded5317c003223635efedb06664
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 16818975cdee91ba9635d43ddf522dfd4862f374
https://github.com/Perl/perl5/commit/16818975cdee91ba9635d43ddf522dfd4862f374
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 391af4a3f53ecbcc2b7c791c2618ac5abfd9ef88
https://github.com/Perl/perl5/commit/391af4a3f53ecbcc2b7c791c2618ac5abfd9ef88
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: f699c1191c7a0054c41964032d671a20ee65a15d
https://github.com/Perl/perl5/commit/f699c1191c7a0054c41964032d671a20ee65a15d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: dc90451199a068858bb8f612e2e4d4d9f3897c76
https://github.com/Perl/perl5/commit/dc90451199a068858bb8f612e2e4d4d9f3897c76
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 8d142b025ecf5ace4af128ba3bc85307a29cd6a0
https://github.com/Perl/perl5/commit/8d142b025ecf5ace4af128ba3bc85307a29cd6a0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c2c55f635b3489a45fc2241915516b9c679d33ad
https://github.com/Perl/perl5/commit/c2c55f635b3489a45fc2241915516b9c679d33ad
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 14343bc47bae679321addb7f1039f38ae7f75b7f
https://github.com/Perl/perl5/commit/14343bc47bae679321addb7f1039f38ae7f75b7f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 50d8ebc98a6af14bf471d6ea891c0164b036fc1c
https://github.com/Perl/perl5/commit/50d8ebc98a6af14bf471d6ea891c0164b036fc1c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 1ed645ded41ac57992f971216f280046df2213a6
https://github.com/Perl/perl5/commit/1ed645ded41ac57992f971216f280046df2213a6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 8c1e2f8b9aeda5ea12539da5d655be267fe6e540
https://github.com/Perl/perl5/commit/8c1e2f8b9aeda5ea12539da5d655be267fe6e540
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: f974171b99b884c0ac4082281e3448d7b23ca1e6
https://github.com/Perl/perl5/commit/f974171b99b884c0ac4082281e3448d7b23ca1e6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: f2db29e335ef033c6f7b24b2e4b4d3be91e697ea
https://github.com/Perl/perl5/commit/f2db29e335ef033c6f7b24b2e4b4d3be91e697ea
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: a606d90e6f690392f0d5fb598706f3a0f58e90de
https://github.com/Perl/perl5/commit/a606d90e6f690392f0d5fb598706f3a0f58e90de
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 36808a2ddc315acedeb9a73ed53df38407fcedb7
https://github.com/Perl/perl5/commit/36808a2ddc315acedeb9a73ed53df38407fcedb7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 611371fcabd52b645c0264bb03b9e56e5a43ff6f
https://github.com/Perl/perl5/commit/611371fcabd52b645c0264bb03b9e56e5a43ff6f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 5aecce31648c27e369359a036a1cd0b5ea009d8c
https://github.com/Perl/perl5/commit/5aecce31648c27e369359a036a1cd0b5ea009d8c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 878b0f7d1d4c7597140a3f64227c6e247e388d79
https://github.com/Perl/perl5/commit/878b0f7d1d4c7597140a3f64227c6e247e388d79
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 725c8be1caedd7be5261c0d862f7c47d91b3c0d9
https://github.com/Perl/perl5/commit/725c8be1caedd7be5261c0d862f7c47d91b3c0d9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 3105b37cee9334a063b9d00e2f978cc7b2be080e
https://github.com/Perl/perl5/commit/3105b37cee9334a063b9d00e2f978cc7b2be080e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: e22a2a6d58f8db07b2e1b1e15df54852880c9fe3
https://github.com/Perl/perl5/commit/e22a2a6d58f8db07b2e1b1e15df54852880c9fe3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: b8fdcb87fcc72661f9a47b0f51b2c9b0f44a5235
https://github.com/Perl/perl5/commit/b8fdcb87fcc72661f9a47b0f51b2c9b0f44a5235
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: e708781bcc475bbe9a5f9d168ef37308c746e229
https://github.com/Perl/perl5/commit/e708781bcc475bbe9a5f9d168ef37308c746e229
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: e5d7d1d4d4dc3a1d086af2bf1d5ef0fbaab141eb
https://github.com/Perl/perl5/commit/e5d7d1d4d4dc3a1d086af2bf1d5ef0fbaab141eb
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 544b6f422b103885d2a892843cf33d6f3145a9aa
https://github.com/Perl/perl5/commit/544b6f422b103885d2a892843cf33d6f3145a9aa
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 04afed24fdcd35c50ae855ad7018f19ad9389c6b
https://github.com/Perl/perl5/commit/04afed24fdcd35c50ae855ad7018f19ad9389c6b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: ffd5fdc36fa818c1b4d20a6a809d250bc78b7ee8
https://github.com/Perl/perl5/commit/ffd5fdc36fa818c1b4d20a6a809d250bc78b7ee8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: d0d43f3bf18e41649f4a6bca331eec7f2875d3e5
https://github.com/Perl/perl5/commit/d0d43f3bf18e41649f4a6bca331eec7f2875d3e5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 2a4fa2257b37fe8e71e08c65e0549de3f174f659
https://github.com/Perl/perl5/commit/2a4fa2257b37fe8e71e08c65e0549de3f174f659
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 820a0be1364494aa4a3a227b9bd9ab117eafa6c2
https://github.com/Perl/perl5/commit/820a0be1364494aa4a3a227b9bd9ab117eafa6c2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: e63ff2f35a335782ea67e595dd14877fc874fa7c
https://github.com/Perl/perl5/commit/e63ff2f35a335782ea67e595dd14877fc874fa7c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: af1313a7615ec168a67be7fdf03f085f721e5a54
https://github.com/Perl/perl5/commit/af1313a7615ec168a67be7fdf03f085f721e5a54
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 7b5b2df0a87257e2fa4026484d63f7ccc146c054
https://github.com/Perl/perl5/commit/7b5b2df0a87257e2fa4026484d63f7ccc146c054
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 4fef3a17a4701959aedf14eeb6ff66df8960562d
https://github.com/Perl/perl5/commit/4fef3a17a4701959aedf14eeb6ff66df8960562d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 5ae2f1c2f509fc7826f5bb37b73f89e03dcab288
https://github.com/Perl/perl5/commit/5ae2f1c2f509fc7826f5bb37b73f89e03dcab288
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 802128afccd0783418b79aa8745b17346d844aa8
https://github.com/Perl/perl5/commit/802128afccd0783418b79aa8745b17346d844aa8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: f0c42cbf11f6aa120ae03d8b65c3e73569b34053
https://github.com/Perl/perl5/commit/f0c42cbf11f6aa120ae03d8b65c3e73569b34053
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: a8e30d6fc1caf2f1f079511e17318d5d321c9435
https://github.com/Perl/perl5/commit/a8e30d6fc1caf2f1f079511e17318d5d321c9435
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: cb98881baebb4d0e836221402c0ad788d1cc8451
https://github.com/Perl/perl5/commit/cb98881baebb4d0e836221402c0ad788d1cc8451
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 6f3d87aef4a031c1d48edce339beb37b194f96f3
https://github.com/Perl/perl5/commit/6f3d87aef4a031c1d48edce339beb37b194f96f3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: e4ef4703f0fba0e325f825f2351e5f99248ca864
https://github.com/Perl/perl5/commit/e4ef4703f0fba0e325f825f2351e5f99248ca864
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 2b77c6547901de570ee0a3dbfb518ef24328ea6e
https://github.com/Perl/perl5/commit/2b77c6547901de570ee0a3dbfb518ef24328ea6e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: f67cddf8515071854ed73a321114a6588ac6d9bc
https://github.com/Perl/perl5/commit/f67cddf8515071854ed73a321114a6588ac6d9bc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: ed5e3e9576f9f90213ba8ddd9c25d793fbe4000b
https://github.com/Perl/perl5/commit/ed5e3e9576f9f90213ba8ddd9c25d793fbe4000b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 9450dae4d3562f984962e3486f3d2a1c99688624
https://github.com/Perl/perl5/commit/9450dae4d3562f984962e3486f3d2a1c99688624
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 130c644cd6945088473b5d6f5af8f85a90e951ee
https://github.com/Perl/perl5/commit/130c644cd6945088473b5d6f5af8f85a90e951ee
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: b1d1ac5afe6b574d4ad0dbedc784e8a72c0f6af9
https://github.com/Perl/perl5/commit/b1d1ac5afe6b574d4ad0dbedc784e8a72c0f6af9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: c530a570700e5167a2860f45dc8853c21c545fe0
https://github.com/Perl/perl5/commit/c530a570700e5167a2860f45dc8853c21c545fe0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 0bdb9514382f765a1a049d1004dafc20886068b0
https://github.com/Perl/perl5/commit/0bdb9514382f765a1a049d1004dafc20886068b0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 4f058670d24e5b451f9f1555f88702e2a6457aa1
https://github.com/Perl/perl5/commit/4f058670d24e5b451f9f1555f88702e2a6457aa1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: b5ce0ee6adb6f820d30dde1b80c59b41b5ab5fb3
https://github.com/Perl/perl5/commit/b5ce0ee6adb6f820d30dde1b80c59b41b5ab5fb3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 058819bac7e8e823f0cf71048dddfd9461653b9f
https://github.com/Perl/perl5/commit/058819bac7e8e823f0cf71048dddfd9461653b9f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M mg.c
M perl.c
M perl.h
M proto.h
M regexec.c
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
57
Commit: 8f5f29fee11bbfbaccd070661e0f2cdd00870ca8
https://github.com/Perl/perl5/commit/8f5f29fee11bbfbaccd070661e0f2cdd00870ca8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
M perl.h
M pp.c
Log Message:
-----------
62
Compare: https://github.com/Perl/perl5/compare/e685bc26c3ff...8f5f29fee11b
