Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 44fff93ec601adc0f38055daaf4c2a5741459122
https://github.com/Perl/perl5/commit/44fff93ec601adc0f38055daaf4c2a5741459122
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: a9bcd11ca685ca2fb845804dab39a82ae85288f8
https://github.com/Perl/perl5/commit/a9bcd11ca685ca2fb845804dab39a82ae85288f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 4b71eba868ee4b296f8b0086e8fb6883d83d9e6a
https://github.com/Perl/perl5/commit/4b71eba868ee4b296f8b0086e8fb6883d83d9e6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: dc3e951ca25d1d1374eeee8958c93795a0235529
https://github.com/Perl/perl5/commit/dc3e951ca25d1d1374eeee8958c93795a0235529
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: c8259bc49c54f66e97a3774c90c7c50e1f429cde
https://github.com/Perl/perl5/commit/c8259bc49c54f66e97a3774c90c7c50e1f429cde
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 7782bc33813aca80790dcf8be2e3c6bd9fd4e6c7
https://github.com/Perl/perl5/commit/7782bc33813aca80790dcf8be2e3c6bd9fd4e6c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 9d6b26ff57ca3786380060a86ba7d5a51c0d5805
https://github.com/Perl/perl5/commit/9d6b26ff57ca3786380060a86ba7d5a51c0d5805
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 983b6a7498125fa9ff58ee305a48b491dcb5e0f5
https://github.com/Perl/perl5/commit/983b6a7498125fa9ff58ee305a48b491dcb5e0f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: ad46e5cfa353891e165fb488e871bc5a0551d3e8
https://github.com/Perl/perl5/commit/ad46e5cfa353891e165fb488e871bc5a0551d3e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 73184ec7a6d320b645f5290f52590a6141aa8c52
https://github.com/Perl/perl5/commit/73184ec7a6d320b645f5290f52590a6141aa8c52
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: ce85af7ef48606af8c23e5a37f50ed3fcd07f4f3
https://github.com/Perl/perl5/commit/ce85af7ef48606af8c23e5a37f50ed3fcd07f4f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 0699bd774bbc72085fa19ca7d8c0c71ddcedef17
https://github.com/Perl/perl5/commit/0699bd774bbc72085fa19ca7d8c0c71ddcedef17
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: f02a1c4ba7f37f68cce9c5cc8894f6a6291ed61b
https://github.com/Perl/perl5/commit/f02a1c4ba7f37f68cce9c5cc8894f6a6291ed61b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: fb594324587df04bed5f2b118119aa71b7e7919b
https://github.com/Perl/perl5/commit/fb594324587df04bed5f2b118119aa71b7e7919b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 98a14edbaedc576ad6de6087815701c5a964b40d
https://github.com/Perl/perl5/commit/98a14edbaedc576ad6de6087815701c5a964b40d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 93fa849380c14429a6cf71f5518e9e3a113ef4f4
https://github.com/Perl/perl5/commit/93fa849380c14429a6cf71f5518e9e3a113ef4f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: f43551f4a3a8ceeaeb6efc807787bfe19714c646
https://github.com/Perl/perl5/commit/f43551f4a3a8ceeaeb6efc807787bfe19714c646
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: b7e257fe70b3029ddf9c9d45c0f83bacebf6b393
https://github.com/Perl/perl5/commit/b7e257fe70b3029ddf9c9d45c0f83bacebf6b393
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 020ec8501c236adbc2d0c8808cab0a4321e6c9e2
https://github.com/Perl/perl5/commit/020ec8501c236adbc2d0c8808cab0a4321e6c9e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: dd332d3e4e59b41f8b84e5b03fb88ea3aab278eb
https://github.com/Perl/perl5/commit/dd332d3e4e59b41f8b84e5b03fb88ea3aab278eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: ed2470b7f2abdb57122bef29aa9fde9188a91c27
https://github.com/Perl/perl5/commit/ed2470b7f2abdb57122bef29aa9fde9188a91c27
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 585ba31c60a5bcc1e6099c10d04b475bdc004730
https://github.com/Perl/perl5/commit/585ba31c60a5bcc1e6099c10d04b475bdc004730
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: a095ee7f7f64b6fbe70a83db03709bb78a2bb2ab
https://github.com/Perl/perl5/commit/a095ee7f7f64b6fbe70a83db03709bb78a2bb2ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 5372b3a98cdc0c0945da90ef6335431f1e3f8ae3
https://github.com/Perl/perl5/commit/5372b3a98cdc0c0945da90ef6335431f1e3f8ae3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: a1952146074ac0f7f2f81b2d17e48a72618d7712
https://github.com/Perl/perl5/commit/a1952146074ac0f7f2f81b2d17e48a72618d7712
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 2c602f36e69064e3e2fdbc16b9572494641fa3a5
https://github.com/Perl/perl5/commit/2c602f36e69064e3e2fdbc16b9572494641fa3a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 65cec8d72a062e173624a56694380ae806ec3b35
https://github.com/Perl/perl5/commit/65cec8d72a062e173624a56694380ae806ec3b35
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: a50126f95b1fc63b26ff4f9bc9462c614780cc95
https://github.com/Perl/perl5/commit/a50126f95b1fc63b26ff4f9bc9462c614780cc95
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 540cbdf77f7523a39a8c095301f37a57140a70bc
https://github.com/Perl/perl5/commit/540cbdf77f7523a39a8c095301f37a57140a70bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 84a823ae6b3935a69009b6683c96466009f09392
https://github.com/Perl/perl5/commit/84a823ae6b3935a69009b6683c96466009f09392
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 3f4894212876cf2a61fc434e1484af7c6237cc9f
https://github.com/Perl/perl5/commit/3f4894212876cf2a61fc434e1484af7c6237cc9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 98178926e441d734879823739bff81da0f10b26c
https://github.com/Perl/perl5/commit/98178926e441d734879823739bff81da0f10b26c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 4af4d784179712cecd0f0cc6061e82e0e3e6bd5b
https://github.com/Perl/perl5/commit/4af4d784179712cecd0f0cc6061e82e0e3e6bd5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: a94e0035dc39a9f879d32fc3d1651689ed20477e
https://github.com/Perl/perl5/commit/a94e0035dc39a9f879d32fc3d1651689ed20477e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a0641da2bc7a441209b35a068b1216dcadabc417
https://github.com/Perl/perl5/commit/a0641da2bc7a441209b35a068b1216dcadabc417
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 13bfac2cc2f3ab0da077955dedbfb1c5eb0cafb6
https://github.com/Perl/perl5/commit/13bfac2cc2f3ab0da077955dedbfb1c5eb0cafb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 2d3899bece488d796c87a264d0aeafe096c708fd
https://github.com/Perl/perl5/commit/2d3899bece488d796c87a264d0aeafe096c708fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: b3300249ea874b41d708d68b5982a7d9eaab3f1b
https://github.com/Perl/perl5/commit/b3300249ea874b41d708d68b5982a7d9eaab3f1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 8b57ba2c6a8ba66d2f7a0e05f872b0e6ec9300d9
https://github.com/Perl/perl5/commit/8b57ba2c6a8ba66d2f7a0e05f872b0e6ec9300d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 3115f6aec74107881626aa586ea1ba18c1131817
https://github.com/Perl/perl5/commit/3115f6aec74107881626aa586ea1ba18c1131817
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 3c11ead49df9e76905a3a6c6c7f4c2a6fbf2741f
https://github.com/Perl/perl5/commit/3c11ead49df9e76905a3a6c6c7f4c2a6fbf2741f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: f079cf8be595854f114fb346305a814806a8ee33
https://github.com/Perl/perl5/commit/f079cf8be595854f114fb346305a814806a8ee33
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: cc5617b4e8a334028e9d634fe3b5155b29026927
https://github.com/Perl/perl5/commit/cc5617b4e8a334028e9d634fe3b5155b29026927
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: f3944584a926c0395c55848d973737637615fc8d
https://github.com/Perl/perl5/commit/f3944584a926c0395c55848d973737637615fc8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 2ac5059aff276bbf4421551f5c77d269c7e99661
https://github.com/Perl/perl5/commit/2ac5059aff276bbf4421551f5c77d269c7e99661
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 596da38696bdcd88d415c8c972be4c2a405f0122
https://github.com/Perl/perl5/commit/596da38696bdcd88d415c8c972be4c2a405f0122
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 9eda755d429bfaf4ddc6f6ac90cdb0a5a97ba5cc
https://github.com/Perl/perl5/commit/9eda755d429bfaf4ddc6f6ac90cdb0a5a97ba5cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 2184d3b7acc6fc12951de6c463232b4a0dd5bde9
https://github.com/Perl/perl5/commit/2184d3b7acc6fc12951de6c463232b4a0dd5bde9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: c4faf9b5c3634d1a5092bf130aaeb012190cfb3c
https://github.com/Perl/perl5/commit/c4faf9b5c3634d1a5092bf130aaeb012190cfb3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 4052c5a1503e370aba36743c8635227e725330eb
https://github.com/Perl/perl5/commit/4052c5a1503e370aba36743c8635227e725330eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 898657f6e5a7f1204edbc4461fcb2218362ef9df
https://github.com/Perl/perl5/commit/898657f6e5a7f1204edbc4461fcb2218362ef9df
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5ce028d0072b5e3261089183421579ada542b52f
https://github.com/Perl/perl5/commit/5ce028d0072b5e3261089183421579ada542b52f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 6853d75c0e7fe1fb560b61aaff9a0c3d2f959a8e
https://github.com/Perl/perl5/commit/6853d75c0e7fe1fb560b61aaff9a0c3d2f959a8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 888c4b08bdff9c064146eba4bb6e96e074bd97ec
https://github.com/Perl/perl5/commit/888c4b08bdff9c064146eba4bb6e96e074bd97ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: f1172f6b269653f29f4ca792b696f88b32782080
https://github.com/Perl/perl5/commit/f1172f6b269653f29f4ca792b696f88b32782080
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 3006b9eb341b006cb9b7b91a24b735f2035ec523
https://github.com/Perl/perl5/commit/3006b9eb341b006cb9b7b91a24b735f2035ec523
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: ff9097518ecea7c7fcdf3d580fc72e13aeef0abf
https://github.com/Perl/perl5/commit/ff9097518ecea7c7fcdf3d580fc72e13aeef0abf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: adccf9ced766eedf44ea88e23967352d8d067046
https://github.com/Perl/perl5/commit/adccf9ced766eedf44ea88e23967352d8d067046
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 24d400653e8b10680f91deae8f8338b948e6bdbc
https://github.com/Perl/perl5/commit/24d400653e8b10680f91deae8f8338b948e6bdbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 6377949c1ff90ddda88c53e1c3821aa14f4f398a
https://github.com/Perl/perl5/commit/6377949c1ff90ddda88c53e1c3821aa14f4f398a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c45906841ceb5f52a62f6acf98cd19e2f5744dce
https://github.com/Perl/perl5/commit/c45906841ceb5f52a62f6acf98cd19e2f5744dce
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 2e0582cd00b4735a9cf87307fa786790322f368c
https://github.com/Perl/perl5/commit/2e0582cd00b4735a9cf87307fa786790322f368c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 9d4039a22bc16aa34496279bdae676e81094e779
https://github.com/Perl/perl5/commit/9d4039a22bc16aa34496279bdae676e81094e779
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 8195234bddee5cb716beaeae19114ab5e8c03a00
https://github.com/Perl/perl5/commit/8195234bddee5cb716beaeae19114ab5e8c03a00
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 66eed1400caec8204e972957c5df88d5f345a9d2
https://github.com/Perl/perl5/commit/66eed1400caec8204e972957c5df88d5f345a9d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: f03ac302236a618f5172a568f01b4c06ade35e3f
https://github.com/Perl/perl5/commit/f03ac302236a618f5172a568f01b4c06ade35e3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 61fbee97a52b05c257d8162e45130623f58c0469
https://github.com/Perl/perl5/commit/61fbee97a52b05c257d8162e45130623f58c0469
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: bfe3412ce7f43b15c6aa357e57a23ff424153250
https://github.com/Perl/perl5/commit/bfe3412ce7f43b15c6aa357e57a23ff424153250
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: bde2ff717c47a633861b3085844c491b22e7a9b4
https://github.com/Perl/perl5/commit/bde2ff717c47a633861b3085844c491b22e7a9b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 3f56b3972709d672548dac8a7fc21630c04737c6
https://github.com/Perl/perl5/commit/3f56b3972709d672548dac8a7fc21630c04737c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 650064c0d93262614e8e7709f162e853060ebd1f
https://github.com/Perl/perl5/commit/650064c0d93262614e8e7709f162e853060ebd1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 546ff01146e545b4b1f6aac6cfc70f7d5d15bc7a
https://github.com/Perl/perl5/commit/546ff01146e545b4b1f6aac6cfc70f7d5d15bc7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 472346c124ecfbd23b0397e12436c246087d7d23
https://github.com/Perl/perl5/commit/472346c124ecfbd23b0397e12436c246087d7d23
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 5848b35d3713463bb01e752febaa4f26590a0cdf
https://github.com/Perl/perl5/commit/5848b35d3713463bb01e752febaa4f26590a0cdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: e27beb78effe78605941813405675f16e951376e
https://github.com/Perl/perl5/commit/e27beb78effe78605941813405675f16e951376e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 0c8b4107f6376acab6ec62f15b824c7ecd94aada
https://github.com/Perl/perl5/commit/0c8b4107f6376acab6ec62f15b824c7ecd94aada
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: b6a2528be80a1a49017e060417d1750c2fc5faa5
https://github.com/Perl/perl5/commit/b6a2528be80a1a49017e060417d1750c2fc5faa5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: a84f79ca856cb11d34be5603ae3f3f74bb0e1c94
https://github.com/Perl/perl5/commit/a84f79ca856cb11d34be5603ae3f3f74bb0e1c94
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 47ebcbb6cf308c263f7c02379f6f935540b0f269
https://github.com/Perl/perl5/commit/47ebcbb6cf308c263f7c02379f6f935540b0f269
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 70c4c77805cb216ea595349de6c7790955ffe1cb
https://github.com/Perl/perl5/commit/70c4c77805cb216ea595349de6c7790955ffe1cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 796bc859b41ecd59be349b2ce18a9c4f167c3292
https://github.com/Perl/perl5/commit/796bc859b41ecd59be349b2ce18a9c4f167c3292
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: aa7cc580307faa1240e67483c37c6e1f7bad7e9b
https://github.com/Perl/perl5/commit/aa7cc580307faa1240e67483c37c6e1f7bad7e9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 76b8e6af73d59113d72cdcdf155190d1bd27f689
https://github.com/Perl/perl5/commit/76b8e6af73d59113d72cdcdf155190d1bd27f689
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: aedc44826e638af42d14fdd7f5ba051c635aa9b5
https://github.com/Perl/perl5/commit/aedc44826e638af42d14fdd7f5ba051c635aa9b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 3daeda2616b2c7c9bf354c80cba266f42b690986
https://github.com/Perl/perl5/commit/3daeda2616b2c7c9bf354c80cba266f42b690986
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 246c1686e09792339b770f0478afe9d0b659b305
https://github.com/Perl/perl5/commit/246c1686e09792339b770f0478afe9d0b659b305
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 9a2dacfd2d48238cfb30c70bd56c1797b5b6bee4
https://github.com/Perl/perl5/commit/9a2dacfd2d48238cfb30c70bd56c1797b5b6bee4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: d57dd59ac3357845da26fea092c85f76ca4d1187
https://github.com/Perl/perl5/commit/d57dd59ac3357845da26fea092c85f76ca4d1187
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 0122e97799eb9bd248f63ee87fb93d44ed2d3b70
https://github.com/Perl/perl5/commit/0122e97799eb9bd248f63ee87fb93d44ed2d3b70
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: f6570f7e666dfb1d0a9ea10a2dde0a669e2442e4
https://github.com/Perl/perl5/commit/f6570f7e666dfb1d0a9ea10a2dde0a669e2442e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 176717674efdf87b8924a29f53ce434bd9c5b0f8
https://github.com/Perl/perl5/commit/176717674efdf87b8924a29f53ce434bd9c5b0f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: a3d72604874c0f7e03a8f033fb706b32b21bd65e
https://github.com/Perl/perl5/commit/a3d72604874c0f7e03a8f033fb706b32b21bd65e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: c00e0760e71c9a6d0b27aab93b5262c1d96203ba
https://github.com/Perl/perl5/commit/c00e0760e71c9a6d0b27aab93b5262c1d96203ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: f3edd63599357c4d660ee5c16929886777a670ca
https://github.com/Perl/perl5/commit/f3edd63599357c4d660ee5c16929886777a670ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 98d0bfb486bc9be7414f041e02f701c25591ce38
https://github.com/Perl/perl5/commit/98d0bfb486bc9be7414f041e02f701c25591ce38
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 4f9d6be2f650fda01f01ec1ffbda190a1a4885cf
https://github.com/Perl/perl5/commit/4f9d6be2f650fda01f01ec1ffbda190a1a4885cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 09fb22a9aa63a1a466403314051f9c6a5dc48a72
https://github.com/Perl/perl5/commit/09fb22a9aa63a1a466403314051f9c6a5dc48a72
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: f4f1e913b9838e111e933350306d410729fd6e8e
https://github.com/Perl/perl5/commit/f4f1e913b9838e111e933350306d410729fd6e8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: eb7201c5def042699774bd5019f97dbf5bbdbd22
https://github.com/Perl/perl5/commit/eb7201c5def042699774bd5019f97dbf5bbdbd22
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 5fc51cdff2a5bfb28728930248c910a925d4dde6
https://github.com/Perl/perl5/commit/5fc51cdff2a5bfb28728930248c910a925d4dde6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: fe52f17ebcdf89d9ba22f62d76910b79d2a0b823
https://github.com/Perl/perl5/commit/fe52f17ebcdf89d9ba22f62d76910b79d2a0b823
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 03a2d62fb10ef9e59e495dee2479f79794f75248
https://github.com/Perl/perl5/commit/03a2d62fb10ef9e59e495dee2479f79794f75248
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: b63e54495ab548d48430904a4782bed8e21eb8c5
https://github.com/Perl/perl5/commit/b63e54495ab548d48430904a4782bed8e21eb8c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: d6d1235aba790e6b48a83567d2ddf502f9fc6b07
https://github.com/Perl/perl5/commit/d6d1235aba790e6b48a83567d2ddf502f9fc6b07
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: b5f561202078d5c34b790af5b4c88e5d57c67080
https://github.com/Perl/perl5/commit/b5f561202078d5c34b790af5b4c88e5d57c67080
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: d233f39816968c5659b27fefa6033a3d3b4d8d1f
https://github.com/Perl/perl5/commit/d233f39816968c5659b27fefa6033a3d3b4d8d1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 053f93b5851f30087d8b8b35b0f0dea2187f00a8
https://github.com/Perl/perl5/commit/053f93b5851f30087d8b8b35b0f0dea2187f00a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 131b73a7ae25286e4c2e110ea1cc41e09271293c
https://github.com/Perl/perl5/commit/131b73a7ae25286e4c2e110ea1cc41e09271293c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 02a4c7f02b04d51b775de098a6ed99e86d1764f1
https://github.com/Perl/perl5/commit/02a4c7f02b04d51b775de098a6ed99e86d1764f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 57fa1160f35c72e0e2a79c316d62de2e8ac1c105
https://github.com/Perl/perl5/commit/57fa1160f35c72e0e2a79c316d62de2e8ac1c105
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: ae92a42088c268248a9929ebc3630d650bceb791
https://github.com/Perl/perl5/commit/ae92a42088c268248a9929ebc3630d650bceb791
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 841e749a72586f04fed5eae5f146b6de5e07f947
https://github.com/Perl/perl5/commit/841e749a72586f04fed5eae5f146b6de5e07f947
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 8f06e13185caefbfbc43c966261227d1e1e1fbad
https://github.com/Perl/perl5/commit/8f06e13185caefbfbc43c966261227d1e1e1fbad
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 84486b02d8cc08aaecde2b63894c7ab5b189e9c3
https://github.com/Perl/perl5/commit/84486b02d8cc08aaecde2b63894c7ab5b189e9c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 3bd32412d8b14ca9dc42313f69c0b9e81a033d68
https://github.com/Perl/perl5/commit/3bd32412d8b14ca9dc42313f69c0b9e81a033d68
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 41991f866013d8d22593f2cff3fa1ba1ef0a753d
https://github.com/Perl/perl5/commit/41991f866013d8d22593f2cff3fa1ba1ef0a753d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 465c34683444ce7f00bde728dbdce22a699939d9
https://github.com/Perl/perl5/commit/465c34683444ce7f00bde728dbdce22a699939d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: bbd69bdd808f3f58130720da8c62d6e082a3d2a5
https://github.com/Perl/perl5/commit/bbd69bdd808f3f58130720da8c62d6e082a3d2a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 799b4e23c919d87dc37a0958ece331599452f072
https://github.com/Perl/perl5/commit/799b4e23c919d87dc37a0958ece331599452f072
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: d0722f93f6712d08afa9c732794520127f91d497
https://github.com/Perl/perl5/commit/d0722f93f6712d08afa9c732794520127f91d497
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 81b7cf5e78ff6b12776a9f285f10ecbfdfecc48a
https://github.com/Perl/perl5/commit/81b7cf5e78ff6b12776a9f285f10ecbfdfecc48a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: ee678777ccf8ec39d2245e774dc3123d6d77503b
https://github.com/Perl/perl5/commit/ee678777ccf8ec39d2245e774dc3123d6d77503b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 7aa2db6ded1a622ee40c466bce893a83411824b8
https://github.com/Perl/perl5/commit/7aa2db6ded1a622ee40c466bce893a83411824b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: c297fd72d3132ee9aee3cc6fb1e9a3885944c5a5
https://github.com/Perl/perl5/commit/c297fd72d3132ee9aee3cc6fb1e9a3885944c5a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 96d398ac9fce24d18816072d436e9add983f95dc
https://github.com/Perl/perl5/commit/96d398ac9fce24d18816072d436e9add983f95dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 8ce63dfd3bdfd6d96146e8260391b2cb7cc2b232
https://github.com/Perl/perl5/commit/8ce63dfd3bdfd6d96146e8260391b2cb7cc2b232
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 6b695ebc987ae96690c2bde4b88741c03d65e89f
https://github.com/Perl/perl5/commit/6b695ebc987ae96690c2bde4b88741c03d65e89f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 18cca25bbfcf80e6ed09ddc05c4562c31cf63e51
https://github.com/Perl/perl5/commit/18cca25bbfcf80e6ed09ddc05c4562c31cf63e51
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: c7af3e4b9ce285d6bf515af221c043556665a0af
https://github.com/Perl/perl5/commit/c7af3e4b9ce285d6bf515af221c043556665a0af
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 5bd9368c28f532aa5b3bd5c34e783b4d75fddc57
https://github.com/Perl/perl5/commit/5bd9368c28f532aa5b3bd5c34e783b4d75fddc57
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: d0ae3c34177e62e71b4a160098e185e3b452f178
https://github.com/Perl/perl5/commit/d0ae3c34177e62e71b4a160098e185e3b452f178
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: f5595ad08ba776bb0396754fd2dd8a13cea4716b
https://github.com/Perl/perl5/commit/f5595ad08ba776bb0396754fd2dd8a13cea4716b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 23d756987c2981385be543b5d4b6a96d1fdbeecd
https://github.com/Perl/perl5/commit/23d756987c2981385be543b5d4b6a96d1fdbeecd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 8ddbb8a745987aee8461cbefc5b68b83d95bc817
https://github.com/Perl/perl5/commit/8ddbb8a745987aee8461cbefc5b68b83d95bc817
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: b03d3a2a54492ee95d91cc3dbd3e1d1ae89ffc47
https://github.com/Perl/perl5/commit/b03d3a2a54492ee95d91cc3dbd3e1d1ae89ffc47
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: a80b46b1acb76c4d84d89e2d51ed17ce5d03c7bd
https://github.com/Perl/perl5/commit/a80b46b1acb76c4d84d89e2d51ed17ce5d03c7bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 5af15e49900e35f739a450b0b8b45e5bc5381124
https://github.com/Perl/perl5/commit/5af15e49900e35f739a450b0b8b45e5bc5381124
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: f1700ebc079fda27185d8913b558030de7948396
https://github.com/Perl/perl5/commit/f1700ebc079fda27185d8913b558030de7948396
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 55c0c23d59401f2b549cb1de1336c93f34cbe35b
https://github.com/Perl/perl5/commit/55c0c23d59401f2b549cb1de1336c93f34cbe35b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 0e67a5450b035b591d5fac10e0a590c4eb97f57b
https://github.com/Perl/perl5/commit/0e67a5450b035b591d5fac10e0a590c4eb97f57b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 4403f001d0bec0974a6462941cd179ec91d203e9
https://github.com/Perl/perl5/commit/4403f001d0bec0974a6462941cd179ec91d203e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 0f8a688368599535461644d1a01c627d8796b34d
https://github.com/Perl/perl5/commit/0f8a688368599535461644d1a01c627d8796b34d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 472ecb1887edbc956ecbbc91378d31d1863c7978
https://github.com/Perl/perl5/commit/472ecb1887edbc956ecbbc91378d31d1863c7978
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 24653c8ca160d71af8efe0e36a8bf91ba77f3f43
https://github.com/Perl/perl5/commit/24653c8ca160d71af8efe0e36a8bf91ba77f3f43
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 6309cd1155dadfc35b67c81e43437a3ceb47c9b8
https://github.com/Perl/perl5/commit/6309cd1155dadfc35b67c81e43437a3ceb47c9b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: c11fab2281b13063e903313d39346d583e378b21
https://github.com/Perl/perl5/commit/c11fab2281b13063e903313d39346d583e378b21
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 46b16f63752434b14e205166729d5a707c736697
https://github.com/Perl/perl5/commit/46b16f63752434b14e205166729d5a707c736697
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: b9417c07528fc0baa280e360fa7cc0ced590a30f
https://github.com/Perl/perl5/commit/b9417c07528fc0baa280e360fa7cc0ced590a30f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: cc54def4f5e4db4110f09f614346bce0e103decb
https://github.com/Perl/perl5/commit/cc54def4f5e4db4110f09f614346bce0e103decb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 7d63cfd5dea39b67bbc97c8f21209dcbe947529e
https://github.com/Perl/perl5/commit/7d63cfd5dea39b67bbc97c8f21209dcbe947529e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 007970a6e98196dbd32d21f2dd8e29005de30fbd
https://github.com/Perl/perl5/commit/007970a6e98196dbd32d21f2dd8e29005de30fbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 9af030c3ae57940aa903a9fea3ba80236f84e874
https://github.com/Perl/perl5/commit/9af030c3ae57940aa903a9fea3ba80236f84e874
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: af01cef03a9b6da0c9399f37b9ebcb776a757754
https://github.com/Perl/perl5/commit/af01cef03a9b6da0c9399f37b9ebcb776a757754
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 961e64126aeac39edbdc2d702b09f0d392b6f8ef
https://github.com/Perl/perl5/commit/961e64126aeac39edbdc2d702b09f0d392b6f8ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 7158d50ac9cdd9a8ad3cfbb4107d0637e3be3163
https://github.com/Perl/perl5/commit/7158d50ac9cdd9a8ad3cfbb4107d0637e3be3163
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: c32f9c56d350b761136d6d7abc2c5c76d48a5833
https://github.com/Perl/perl5/commit/c32f9c56d350b761136d6d7abc2c5c76d48a5833
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: f1f5dfae02d04433da818aecfee374db013312b5
https://github.com/Perl/perl5/commit/f1f5dfae02d04433da818aecfee374db013312b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: de5fcfa2e440874c6954e547247f9d076548fece
https://github.com/Perl/perl5/commit/de5fcfa2e440874c6954e547247f9d076548fece
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 230586a2912e4e7c64d3360843c2942452964cc9
https://github.com/Perl/perl5/commit/230586a2912e4e7c64d3360843c2942452964cc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 423b1fe1514b61bbca61744d51eb28cda35f1235
https://github.com/Perl/perl5/commit/423b1fe1514b61bbca61744d51eb28cda35f1235
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 7ca2e145f5edbcf269cb695e66b53e0a78545147
https://github.com/Perl/perl5/commit/7ca2e145f5edbcf269cb695e66b53e0a78545147
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: e3272912d26d961304b161a9e59f13805076efa4
https://github.com/Perl/perl5/commit/e3272912d26d961304b161a9e59f13805076efa4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: fe27d97a4d3df67b3bf6509dbb6b58530e79d6ff
https://github.com/Perl/perl5/commit/fe27d97a4d3df67b3bf6509dbb6b58530e79d6ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 07cdb76ff22a308e06ff1ea53e02aaf06fe3615d
https://github.com/Perl/perl5/commit/07cdb76ff22a308e06ff1ea53e02aaf06fe3615d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 0659f7aea3e2c6179a60150b7b7497c3ec7fcddc
https://github.com/Perl/perl5/commit/0659f7aea3e2c6179a60150b7b7497c3ec7fcddc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 09384c1d0c106fc1b7569e61161e38c4e8bf1ef7
https://github.com/Perl/perl5/commit/09384c1d0c106fc1b7569e61161e38c4e8bf1ef7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5dd991c27e7d021b3b1c3e1856b667572bd9ac6a
https://github.com/Perl/perl5/commit/5dd991c27e7d021b3b1c3e1856b667572bd9ac6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 9e7fb96bd7d14b9a37a253a9dad4439adf6f3db6
https://github.com/Perl/perl5/commit/9e7fb96bd7d14b9a37a253a9dad4439adf6f3db6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 5b41b4aec0f1da3b85c36dbcfefcedaf910d60e8
https://github.com/Perl/perl5/commit/5b41b4aec0f1da3b85c36dbcfefcedaf910d60e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: f9ae57330a43b70d3c94b18c34ace43957f62908
https://github.com/Perl/perl5/commit/f9ae57330a43b70d3c94b18c34ace43957f62908
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 8a868eb6990f52cbb8d3e647f69e066adf1c52e1
https://github.com/Perl/perl5/commit/8a868eb6990f52cbb8d3e647f69e066adf1c52e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 7a861dcc42c7adf6e56507aa381a78a6f9431a55
https://github.com/Perl/perl5/commit/7a861dcc42c7adf6e56507aa381a78a6f9431a55
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 0c154bae74159e79548d01df31cd7289b8d139ec
https://github.com/Perl/perl5/commit/0c154bae74159e79548d01df31cd7289b8d139ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 6e3d812d170176605b6df13bc326a41f2d901661
https://github.com/Perl/perl5/commit/6e3d812d170176605b6df13bc326a41f2d901661
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 0182c5426e7274566a66f5a70562712ad571099d
https://github.com/Perl/perl5/commit/0182c5426e7274566a66f5a70562712ad571099d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: d3e50938220b54fb640fdca7d7e18540d6ff21ef
https://github.com/Perl/perl5/commit/d3e50938220b54fb640fdca7d7e18540d6ff21ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 98d1b93d13af072ab8a0a173067f92d773b083b9
https://github.com/Perl/perl5/commit/98d1b93d13af072ab8a0a173067f92d773b083b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 8ac26e24651079538805de2ba37237e56f3a8c24
https://github.com/Perl/perl5/commit/8ac26e24651079538805de2ba37237e56f3a8c24
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 7180658931ef9edefec7df801f895b4493c0c669
https://github.com/Perl/perl5/commit/7180658931ef9edefec7df801f895b4493c0c669
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: f7fb033f9b4c99dd2240b60507d693a73914777b
https://github.com/Perl/perl5/commit/f7fb033f9b4c99dd2240b60507d693a73914777b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 6d836808cbf42c844348bfe36183a5a3ed686768
https://github.com/Perl/perl5/commit/6d836808cbf42c844348bfe36183a5a3ed686768
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: d57c962bf3d81638177af258ef502c806dc5e088
https://github.com/Perl/perl5/commit/d57c962bf3d81638177af258ef502c806dc5e088
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: ed8b6801e6a93e0103b8c3cbbb9308ee37a04ca9
https://github.com/Perl/perl5/commit/ed8b6801e6a93e0103b8c3cbbb9308ee37a04ca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 15622593dc035552c7f1a5bb6bee3e755c0c8b75
https://github.com/Perl/perl5/commit/15622593dc035552c7f1a5bb6bee3e755c0c8b75
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: a72bf4c508922408dd12a067115f550ca10ff436
https://github.com/Perl/perl5/commit/a72bf4c508922408dd12a067115f550ca10ff436
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c2abdd96c2f9fb49bcede1cd81f88ee2e8195457
https://github.com/Perl/perl5/commit/c2abdd96c2f9fb49bcede1cd81f88ee2e8195457
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b46e0ec1119e5086128c13339e5bb0b7522d3200
https://github.com/Perl/perl5/commit/b46e0ec1119e5086128c13339e5bb0b7522d3200
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c2870b56670c2b2749ad399286b47d38c7f38702
https://github.com/Perl/perl5/commit/c2870b56670c2b2749ad399286b47d38c7f38702
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: a8dcf6289895f9bfa44c46a38628a8ac142f1f2f
https://github.com/Perl/perl5/commit/a8dcf6289895f9bfa44c46a38628a8ac142f1f2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 8d987fcc9401082829d94c4774bda136692ebec0
https://github.com/Perl/perl5/commit/8d987fcc9401082829d94c4774bda136692ebec0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 7d6a84b90f95e88284c599fcec80e73f2ba624af
https://github.com/Perl/perl5/commit/7d6a84b90f95e88284c599fcec80e73f2ba624af
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: bdaa6d627382f6ff43f3f2f41bfce283a5274f16
https://github.com/Perl/perl5/commit/bdaa6d627382f6ff43f3f2f41bfce283a5274f16
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 6c05a84bc8637d49fba640a715995bcff9a56fdb
https://github.com/Perl/perl5/commit/6c05a84bc8637d49fba640a715995bcff9a56fdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0d2fba21b737b193acc0c4b47622dab3296de529
https://github.com/Perl/perl5/commit/0d2fba21b737b193acc0c4b47622dab3296de529
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 21824042fb58fd73ba46165fbd3218cd15c065e7
https://github.com/Perl/perl5/commit/21824042fb58fd73ba46165fbd3218cd15c065e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 15c3420da836ecfc8d7fbf2053b6b9bc445ba2c6
https://github.com/Perl/perl5/commit/15c3420da836ecfc8d7fbf2053b6b9bc445ba2c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: dd5e4d7ae11c285af332bab88bfc98b3e2513995
https://github.com/Perl/perl5/commit/dd5e4d7ae11c285af332bab88bfc98b3e2513995
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 26fc8056f322a01afa69375edbb0cc65196acd3a
https://github.com/Perl/perl5/commit/26fc8056f322a01afa69375edbb0cc65196acd3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 013a6284f03ae6b8f8d7d74cdbd8ae18b6610205
https://github.com/Perl/perl5/commit/013a6284f03ae6b8f8d7d74cdbd8ae18b6610205
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: da3c8d5edad59d89c41cfc585c178697e703537c
https://github.com/Perl/perl5/commit/da3c8d5edad59d89c41cfc585c178697e703537c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: e6b18a79f9ca9e983c02fab7f0f9381dec586e91
https://github.com/Perl/perl5/commit/e6b18a79f9ca9e983c02fab7f0f9381dec586e91
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 6400f07596ff632775f2b52dcb99478a79f36cec
https://github.com/Perl/perl5/commit/6400f07596ff632775f2b52dcb99478a79f36cec
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: ca40a175919672a86b2dcb4dee4f4e0ece00b924
https://github.com/Perl/perl5/commit/ca40a175919672a86b2dcb4dee4f4e0ece00b924
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 61846021eb4951031274623276fa8db2bdf16a2d
https://github.com/Perl/perl5/commit/61846021eb4951031274623276fa8db2bdf16a2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: c23ff42f5da68de223bef743b704ebc374e7d957
https://github.com/Perl/perl5/commit/c23ff42f5da68de223bef743b704ebc374e7d957
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 76fb7a46abc1d1bb361b2abaaf946913da4ddc30
https://github.com/Perl/perl5/commit/76fb7a46abc1d1bb361b2abaaf946913da4ddc30
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: b8198a3b9de7915d427a97cce69cc470ed85eec8
https://github.com/Perl/perl5/commit/b8198a3b9de7915d427a97cce69cc470ed85eec8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: a3683a95234535fe51c2844a54000f6d8db6deed
https://github.com/Perl/perl5/commit/a3683a95234535fe51c2844a54000f6d8db6deed
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 3e847efbd1f04ae1cab1d7f318260149bc84816f
https://github.com/Perl/perl5/commit/3e847efbd1f04ae1cab1d7f318260149bc84816f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 0ec813f55145b0fda158931e22266c0d1e7661fe
https://github.com/Perl/perl5/commit/0ec813f55145b0fda158931e22266c0d1e7661fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c472f3ff7e485b17d3cde0804c645e48bb2d0836
https://github.com/Perl/perl5/commit/c472f3ff7e485b17d3cde0804c645e48bb2d0836
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 8dd197044e33eab3a3fecf40b42eb9df5a604e74
https://github.com/Perl/perl5/commit/8dd197044e33eab3a3fecf40b42eb9df5a604e74
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: d6b767104d8b00d3216b346afbd72c8e09b40e4e
https://github.com/Perl/perl5/commit/d6b767104d8b00d3216b346afbd72c8e09b40e4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 975f4916a4f7918a68681b42a400336f9d9be7a4
https://github.com/Perl/perl5/commit/975f4916a4f7918a68681b42a400336f9d9be7a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 6e1574c91864fcbc9f69e1af96edb8d40845434f
https://github.com/Perl/perl5/commit/6e1574c91864fcbc9f69e1af96edb8d40845434f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: e31412ff6cab4c942bcf3ef702b4e142de0c6987
https://github.com/Perl/perl5/commit/e31412ff6cab4c942bcf3ef702b4e142de0c6987
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 47e246cba4112cecf6dafcd35a2dc7276bba39c4
https://github.com/Perl/perl5/commit/47e246cba4112cecf6dafcd35a2dc7276bba39c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: bc1eebfa3734cacc3f5ff8c479aec8d46d8af2b9
https://github.com/Perl/perl5/commit/bc1eebfa3734cacc3f5ff8c479aec8d46d8af2b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 0f03f23cc7fb195a800e0a09b1d8c97a6d07f4f0
https://github.com/Perl/perl5/commit/0f03f23cc7fb195a800e0a09b1d8c97a6d07f4f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: b53682e1e1705d60e17bd518b99f03c95e058f9b
https://github.com/Perl/perl5/commit/b53682e1e1705d60e17bd518b99f03c95e058f9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 4cee9e18a0e3e2e24562d91e7dc2ca1c7196b6ac
https://github.com/Perl/perl5/commit/4cee9e18a0e3e2e24562d91e7dc2ca1c7196b6ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 47d7236a8b637a58c28a958b22455ac450b3aed0
https://github.com/Perl/perl5/commit/47d7236a8b637a58c28a958b22455ac450b3aed0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: b1e0e2c4f8bfd3cc8ad9363945cd47f208fdacd9
https://github.com/Perl/perl5/commit/b1e0e2c4f8bfd3cc8ad9363945cd47f208fdacd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 27da3439dadc2d68eddc7a2efa67b6b338434117
https://github.com/Perl/perl5/commit/27da3439dadc2d68eddc7a2efa67b6b338434117
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: af7d69f2534e00991b3fb19ac0c3b2c4598933c2
https://github.com/Perl/perl5/commit/af7d69f2534e00991b3fb19ac0c3b2c4598933c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: a1c02a61b78afebe0bf5eced3f52f9e0feb01683
https://github.com/Perl/perl5/commit/a1c02a61b78afebe0bf5eced3f52f9e0feb01683
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 86bee5b88155d6a115ec94cafbd4df4c80ce0d80
https://github.com/Perl/perl5/commit/86bee5b88155d6a115ec94cafbd4df4c80ce0d80
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: b98b34af207fcc98c0879c52ad65e44b4529dc23
https://github.com/Perl/perl5/commit/b98b34af207fcc98c0879c52ad65e44b4529dc23
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: c9a53e6879ac02372e6407a5ecc1369b722568a7
https://github.com/Perl/perl5/commit/c9a53e6879ac02372e6407a5ecc1369b722568a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: b5e701b6740aa446a6d9b9ff082024368411290d
https://github.com/Perl/perl5/commit/b5e701b6740aa446a6d9b9ff082024368411290d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 077ee6affc86445bce7585d3cff3e6fe9aeb7427
https://github.com/Perl/perl5/commit/077ee6affc86445bce7585d3cff3e6fe9aeb7427
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 5880dca512fc3f3436eb51ea0ceafd79a3317e0c
https://github.com/Perl/perl5/commit/5880dca512fc3f3436eb51ea0ceafd79a3317e0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: f0e24484a90748b827b0c7ebc458e6eed08fea9a
https://github.com/Perl/perl5/commit/f0e24484a90748b827b0c7ebc458e6eed08fea9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: ee960b65adfa8e678d7632e5574b482ef3398e85
https://github.com/Perl/perl5/commit/ee960b65adfa8e678d7632e5574b482ef3398e85
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: f732611602bc9702736ee83e29b73c9763d87bd7
https://github.com/Perl/perl5/commit/f732611602bc9702736ee83e29b73c9763d87bd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 944c7e4d3256f7b30faa04a4947c93b86d1c9269
https://github.com/Perl/perl5/commit/944c7e4d3256f7b30faa04a4947c93b86d1c9269
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 4af429da5bcacac6aee505f202a80c45a772cecb
https://github.com/Perl/perl5/commit/4af429da5bcacac6aee505f202a80c45a772cecb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 4af1ec84378ca6ba19c0ddbae0e3d155e5eca387
https://github.com/Perl/perl5/commit/4af1ec84378ca6ba19c0ddbae0e3d155e5eca387
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: f70a6606c18315db19b74e4569935aaaa9b3f997
https://github.com/Perl/perl5/commit/f70a6606c18315db19b74e4569935aaaa9b3f997
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: eb5d9e93c9380663c31e6a40821e6b27788a2cad
https://github.com/Perl/perl5/commit/eb5d9e93c9380663c31e6a40821e6b27788a2cad
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 5a0f7bc2f63e7b908a85af5f34542ef72ccec16d
https://github.com/Perl/perl5/commit/5a0f7bc2f63e7b908a85af5f34542ef72ccec16d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 43abd5e822c3e6afb3762ca701fb36d698138d49
https://github.com/Perl/perl5/commit/43abd5e822c3e6afb3762ca701fb36d698138d49
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 60537b66710862b938ac66225610f2a22316ada5
https://github.com/Perl/perl5/commit/60537b66710862b938ac66225610f2a22316ada5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: eee549d05cd38c8b09a79e184578351f1072c60f
https://github.com/Perl/perl5/commit/eee549d05cd38c8b09a79e184578351f1072c60f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 2fd3afbddc5cb9c909c55954ac750295968d882b
https://github.com/Perl/perl5/commit/2fd3afbddc5cb9c909c55954ac750295968d882b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: a8164d1e58f78b71716d1b1ccd78a4a06d4d0d6b
https://github.com/Perl/perl5/commit/a8164d1e58f78b71716d1b1ccd78a4a06d4d0d6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: b08d78d151a5cd22c05e4c0d1c74e5fa0545d55a
https://github.com/Perl/perl5/commit/b08d78d151a5cd22c05e4c0d1c74e5fa0545d55a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: a4797121ea3d1ee95e52035f159cf0633c9b7dd2
https://github.com/Perl/perl5/commit/a4797121ea3d1ee95e52035f159cf0633c9b7dd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 56e96f67341d7b40cbcf5ed972c0abd5f956c22e
https://github.com/Perl/perl5/commit/56e96f67341d7b40cbcf5ed972c0abd5f956c22e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: abd266af5d71325afe5d2bce93136bae20f3b8b8
https://github.com/Perl/perl5/commit/abd266af5d71325afe5d2bce93136bae20f3b8b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: f9d79460f7946a0af7ed3718bbb6f7ef669c2ac1
https://github.com/Perl/perl5/commit/f9d79460f7946a0af7ed3718bbb6f7ef669c2ac1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 7a245105168e3fd8c2167c675fbba008b6cc35f4
https://github.com/Perl/perl5/commit/7a245105168e3fd8c2167c675fbba008b6cc35f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 0cf28af6fcec153338237c33a7ed3c0a4ff42e21
https://github.com/Perl/perl5/commit/0cf28af6fcec153338237c33a7ed3c0a4ff42e21
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 8dbcdd970f9e7900c80eac3ac6f238ff4fa9dbeb
https://github.com/Perl/perl5/commit/8dbcdd970f9e7900c80eac3ac6f238ff4fa9dbeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: b9faec05cf0ebe7a3669a55e29bed2effd3e8168
https://github.com/Perl/perl5/commit/b9faec05cf0ebe7a3669a55e29bed2effd3e8168
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 6facd53f94f6190ed18807179c57860736b80b2f
https://github.com/Perl/perl5/commit/6facd53f94f6190ed18807179c57860736b80b2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a4d9a52013b5d1dd7a5e5c22edd0d33c038aa682
https://github.com/Perl/perl5/commit/a4d9a52013b5d1dd7a5e5c22edd0d33c038aa682
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
30
Compare: https://github.com/Perl/perl5/compare/dd397fdf38b8...a4d9a52013b5
