Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 6973fbbdd61ba2688148fb5057ab3ee535a5d97c
https://github.com/Perl/perl5/commit/6973fbbdd61ba2688148fb5057ab3ee535a5d97c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 7e91d1160ff933cd434b4e0234a7fd27146c32a4
https://github.com/Perl/perl5/commit/7e91d1160ff933cd434b4e0234a7fd27146c32a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 3250914c8f84b94de8d37b78be15b37fdc35647b
https://github.com/Perl/perl5/commit/3250914c8f84b94de8d37b78be15b37fdc35647b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 9e0db96b3938cb694ee6405a9d3d20cbdb6c0fc2
https://github.com/Perl/perl5/commit/9e0db96b3938cb694ee6405a9d3d20cbdb6c0fc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 8b3c6e1dc281cd5f708c30602d09c7c93ff2471d
https://github.com/Perl/perl5/commit/8b3c6e1dc281cd5f708c30602d09c7c93ff2471d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: ca2a5f408353cfe37e93c4a46888d2ab6f085475
https://github.com/Perl/perl5/commit/ca2a5f408353cfe37e93c4a46888d2ab6f085475
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 2029bdb81cc3bbc82c687b26fb4b5566ecce9347
https://github.com/Perl/perl5/commit/2029bdb81cc3bbc82c687b26fb4b5566ecce9347
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 9ef80ae62386628adc97a8ba0ede2fbbe052ce74
https://github.com/Perl/perl5/commit/9ef80ae62386628adc97a8ba0ede2fbbe052ce74
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 0775908415347d90dbe6c11c3232d39c22d668fe
https://github.com/Perl/perl5/commit/0775908415347d90dbe6c11c3232d39c22d668fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 8c8efbd45408f9cce48b20a175fb5d19827d4884
https://github.com/Perl/perl5/commit/8c8efbd45408f9cce48b20a175fb5d19827d4884
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 51e3ebc3ea8880f336dd22101b37716f3f84a012
https://github.com/Perl/perl5/commit/51e3ebc3ea8880f336dd22101b37716f3f84a012
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: edf8e2ebdab3209b322e4c41f753192480f6727e
https://github.com/Perl/perl5/commit/edf8e2ebdab3209b322e4c41f753192480f6727e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a626c541869698b4edc77d5ebb7ed2a57a3db42e
https://github.com/Perl/perl5/commit/a626c541869698b4edc77d5ebb7ed2a57a3db42e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: bc1b72e35bc541ad559a48bfc4f7b6f6a2456314
https://github.com/Perl/perl5/commit/bc1b72e35bc541ad559a48bfc4f7b6f6a2456314
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: d70d845eeca8a8304a5eb01e4f61ab4a1140170b
https://github.com/Perl/perl5/commit/d70d845eeca8a8304a5eb01e4f61ab4a1140170b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 4bbc838b92ab36262ee40ca488e8d741cf8b5b8a
https://github.com/Perl/perl5/commit/4bbc838b92ab36262ee40ca488e8d741cf8b5b8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 7a58cd44703c1b899539d114919a1d90925988de
https://github.com/Perl/perl5/commit/7a58cd44703c1b899539d114919a1d90925988de
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: e76d16d01c44df91d15e169636eb3b6f05b99c0e
https://github.com/Perl/perl5/commit/e76d16d01c44df91d15e169636eb3b6f05b99c0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: c8546cb1ba0117d64a4c10bd5415eeb8e70bc98e
https://github.com/Perl/perl5/commit/c8546cb1ba0117d64a4c10bd5415eeb8e70bc98e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 436aff29654a4c4caf97db177a9b6e33e56c0020
https://github.com/Perl/perl5/commit/436aff29654a4c4caf97db177a9b6e33e56c0020
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 120753e40497e84a866dfa372f51adbf9f72923b
https://github.com/Perl/perl5/commit/120753e40497e84a866dfa372f51adbf9f72923b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: b807f0b8d22d6edc60f03af2f85178f4a17b3493
https://github.com/Perl/perl5/commit/b807f0b8d22d6edc60f03af2f85178f4a17b3493
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: dcfb0622918769fa10d4d560a92d3cf87f6e8b92
https://github.com/Perl/perl5/commit/dcfb0622918769fa10d4d560a92d3cf87f6e8b92
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 6c070cf9f156113a8d3ee7da131344974fd04ea1
https://github.com/Perl/perl5/commit/6c070cf9f156113a8d3ee7da131344974fd04ea1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 7072c4cc402471ff20912334fbd08de69d22ded1
https://github.com/Perl/perl5/commit/7072c4cc402471ff20912334fbd08de69d22ded1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 2c8e3ac44bd38c11ba93c5fc5ff91d964624b290
https://github.com/Perl/perl5/commit/2c8e3ac44bd38c11ba93c5fc5ff91d964624b290
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: f419167149040a767b82d7053d643b174d183651
https://github.com/Perl/perl5/commit/f419167149040a767b82d7053d643b174d183651
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: e61a4ab8421ab8e9552d360f60eed74bbef496a0
https://github.com/Perl/perl5/commit/e61a4ab8421ab8e9552d360f60eed74bbef496a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 7fcec0449f482cc2b96bf7189a2f65889f186cee
https://github.com/Perl/perl5/commit/7fcec0449f482cc2b96bf7189a2f65889f186cee
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 31a287028de08d77ade588c2a25a82fd1d04067a
https://github.com/Perl/perl5/commit/31a287028de08d77ade588c2a25a82fd1d04067a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: f2d6d8ad7d73966eec34950e4559a1a4efe95a6c
https://github.com/Perl/perl5/commit/f2d6d8ad7d73966eec34950e4559a1a4efe95a6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 341af3961c0ab508f75fee8f41ec42b3c29ecf77
https://github.com/Perl/perl5/commit/341af3961c0ab508f75fee8f41ec42b3c29ecf77
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 50ef8908932fb17ce8c5b66b18f17c4183724760
https://github.com/Perl/perl5/commit/50ef8908932fb17ce8c5b66b18f17c4183724760
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 07e9447ef7c8c05b45f1972bb93d3b92537ab5f9
https://github.com/Perl/perl5/commit/07e9447ef7c8c05b45f1972bb93d3b92537ab5f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 2e6870dab65f0bd98f11462307e0b5b2dbc34ece
https://github.com/Perl/perl5/commit/2e6870dab65f0bd98f11462307e0b5b2dbc34ece
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a8fe9b8ac4e84173598b23e92e71863fc46e86fb
https://github.com/Perl/perl5/commit/a8fe9b8ac4e84173598b23e92e71863fc46e86fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: d9ec4eb23e21b0e8354d119b65a42024b4399976
https://github.com/Perl/perl5/commit/d9ec4eb23e21b0e8354d119b65a42024b4399976
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: a685c76492a66d9c46013ddfd053ac0944ab36b3
https://github.com/Perl/perl5/commit/a685c76492a66d9c46013ddfd053ac0944ab36b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 9b6185d298cb144888c1f90e14f92f2e674603ca
https://github.com/Perl/perl5/commit/9b6185d298cb144888c1f90e14f92f2e674603ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 5aaf2c6cd5ab9dcb68fba633230bec711f6e7141
https://github.com/Perl/perl5/commit/5aaf2c6cd5ab9dcb68fba633230bec711f6e7141
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 64335f3eff463f6ba5c533bdc9d3535b25a7ac91
https://github.com/Perl/perl5/commit/64335f3eff463f6ba5c533bdc9d3535b25a7ac91
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: fd2c8f0352a0846de2c5bbaedbd302c8950aed1c
https://github.com/Perl/perl5/commit/fd2c8f0352a0846de2c5bbaedbd302c8950aed1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 5af3ec41a9521a20ccc66be6ebe6e5e773090cd3
https://github.com/Perl/perl5/commit/5af3ec41a9521a20ccc66be6ebe6e5e773090cd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 7fa74203a337bfad7bbe1bdb08563fb1a15ed3a3
https://github.com/Perl/perl5/commit/7fa74203a337bfad7bbe1bdb08563fb1a15ed3a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 726e7c7fc54367006959189c58a12aeb1b619cb7
https://github.com/Perl/perl5/commit/726e7c7fc54367006959189c58a12aeb1b619cb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: c855b43c20ca63495a86dcf95194aa597f174351
https://github.com/Perl/perl5/commit/c855b43c20ca63495a86dcf95194aa597f174351
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: dc2a8c60cb6cff459ffbb0bc41618a9b05e71f3d
https://github.com/Perl/perl5/commit/dc2a8c60cb6cff459ffbb0bc41618a9b05e71f3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 7854a16e3f6337612d2742d6ec073371e412d099
https://github.com/Perl/perl5/commit/7854a16e3f6337612d2742d6ec073371e412d099
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 499abe79e7a7fc6cde91f411ce234acfb144f03b
https://github.com/Perl/perl5/commit/499abe79e7a7fc6cde91f411ce234acfb144f03b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: a7c795f4400fc51c5267e741eb6e3a09f2d0176e
https://github.com/Perl/perl5/commit/a7c795f4400fc51c5267e741eb6e3a09f2d0176e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 492380ac864252face55819772e5bd2592747577
https://github.com/Perl/perl5/commit/492380ac864252face55819772e5bd2592747577
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 722f0b75dc4eaf806b07a6888d289a97f33e6ead
https://github.com/Perl/perl5/commit/722f0b75dc4eaf806b07a6888d289a97f33e6ead
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 12e5ea9772a7250d9c27ec7f07454f895ee34719
https://github.com/Perl/perl5/commit/12e5ea9772a7250d9c27ec7f07454f895ee34719
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 5cacf71c5611c2a2c2182fca9a0c658dd2600104
https://github.com/Perl/perl5/commit/5cacf71c5611c2a2c2182fca9a0c658dd2600104
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 28cebe4bfd436f885c66ffe4567545db0835008e
https://github.com/Perl/perl5/commit/28cebe4bfd436f885c66ffe4567545db0835008e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 39dfcf0972bc50daceb89ff313219fac871df7b7
https://github.com/Perl/perl5/commit/39dfcf0972bc50daceb89ff313219fac871df7b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 761480870addc6d026b7bbed8169593340a27720
https://github.com/Perl/perl5/commit/761480870addc6d026b7bbed8169593340a27720
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 6669c78ca2b3dcf0f00f935a5d6401812e2ce8b0
https://github.com/Perl/perl5/commit/6669c78ca2b3dcf0f00f935a5d6401812e2ce8b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 47b80072a6eedec5ae9753cbc2b8735de0751e4d
https://github.com/Perl/perl5/commit/47b80072a6eedec5ae9753cbc2b8735de0751e4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: a7044d0f35aa101ad9122985e13e5f5f9bb8b983
https://github.com/Perl/perl5/commit/a7044d0f35aa101ad9122985e13e5f5f9bb8b983
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5a2f30ddfc9c4b46f3cf5004a3553e535d66fe58
https://github.com/Perl/perl5/commit/5a2f30ddfc9c4b46f3cf5004a3553e535d66fe58
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 097acf03f5705f64b18169100c1a92cb159ca00d
https://github.com/Perl/perl5/commit/097acf03f5705f64b18169100c1a92cb159ca00d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 0940c6eb5c77445dfcd489624c0736fe6febaf3e
https://github.com/Perl/perl5/commit/0940c6eb5c77445dfcd489624c0736fe6febaf3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 9a029c652f97b0701435068308c72869571dc427
https://github.com/Perl/perl5/commit/9a029c652f97b0701435068308c72869571dc427
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 7fddbd5f074973e5e72e7b0f32ddd68786eb3987
https://github.com/Perl/perl5/commit/7fddbd5f074973e5e72e7b0f32ddd68786eb3987
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: f69f6087c702821cff14946ab9da1d57f6bed9f0
https://github.com/Perl/perl5/commit/f69f6087c702821cff14946ab9da1d57f6bed9f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 4c25f73fa6fc2b7fcdd7473fc198766d42845e4a
https://github.com/Perl/perl5/commit/4c25f73fa6fc2b7fcdd7473fc198766d42845e4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e31c27aafc3c1efdc2d8b6d9cfe8562a85552fff
https://github.com/Perl/perl5/commit/e31c27aafc3c1efdc2d8b6d9cfe8562a85552fff
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 285339b4012a815f0f7565c3e204aab3d83ba16a
https://github.com/Perl/perl5/commit/285339b4012a815f0f7565c3e204aab3d83ba16a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 73a8c8b6c45b28c93509760843a7d3f46b1f10ba
https://github.com/Perl/perl5/commit/73a8c8b6c45b28c93509760843a7d3f46b1f10ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: d1eaef17f96d6adc9073437d5fb73c26b1027cf9
https://github.com/Perl/perl5/commit/d1eaef17f96d6adc9073437d5fb73c26b1027cf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 146bc85d7ae02463c59f1e176dc54e9f925197f5
https://github.com/Perl/perl5/commit/146bc85d7ae02463c59f1e176dc54e9f925197f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 91e944f76d6ff9cd80a0f0af90d195a0aebdab05
https://github.com/Perl/perl5/commit/91e944f76d6ff9cd80a0f0af90d195a0aebdab05
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 2d6e754a55c839cd2c2d6324b50d63e01ff21a32
https://github.com/Perl/perl5/commit/2d6e754a55c839cd2c2d6324b50d63e01ff21a32
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: c9cfe48a604abdfc3975052a1c4e5758aa7a9f25
https://github.com/Perl/perl5/commit/c9cfe48a604abdfc3975052a1c4e5758aa7a9f25
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 988c8e1581e42f618f993659bd563addfa449496
https://github.com/Perl/perl5/commit/988c8e1581e42f618f993659bd563addfa449496
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: e8d0989934dd59462a513fdd8da3309e4fd62356
https://github.com/Perl/perl5/commit/e8d0989934dd59462a513fdd8da3309e4fd62356
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: efc728d0f54312575b4e1661df6ea22fa8912fb8
https://github.com/Perl/perl5/commit/efc728d0f54312575b4e1661df6ea22fa8912fb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: e27a28b1fb63a828cd4bbcab313b3f04c33e58d4
https://github.com/Perl/perl5/commit/e27a28b1fb63a828cd4bbcab313b3f04c33e58d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 8abe33e35d7ba64ebe6fe2cd1576da3f3d0d98c2
https://github.com/Perl/perl5/commit/8abe33e35d7ba64ebe6fe2cd1576da3f3d0d98c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: dfdf0e3351adee213d9b8698a05b236555bbe27f
https://github.com/Perl/perl5/commit/dfdf0e3351adee213d9b8698a05b236555bbe27f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 0781267cfd7c77515c460ad8c3a1c7de2b1c8185
https://github.com/Perl/perl5/commit/0781267cfd7c77515c460ad8c3a1c7de2b1c8185
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 6527ab5a654d7882242c9d0ee94e628a3c336c96
https://github.com/Perl/perl5/commit/6527ab5a654d7882242c9d0ee94e628a3c336c96
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 5906f6c21b153207e082f78193596a58af05fc4b
https://github.com/Perl/perl5/commit/5906f6c21b153207e082f78193596a58af05fc4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: c445c1828063b026d54cb26acb71caf2708f8a45
https://github.com/Perl/perl5/commit/c445c1828063b026d54cb26acb71caf2708f8a45
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 48a62071fb5a063b7680353a8343b30f427be84d
https://github.com/Perl/perl5/commit/48a62071fb5a063b7680353a8343b30f427be84d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 7823954429459573cf53438ce742e556058c5a87
https://github.com/Perl/perl5/commit/7823954429459573cf53438ce742e556058c5a87
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 452bcda165a9bbf801f02d73a1ecfedbf7d44955
https://github.com/Perl/perl5/commit/452bcda165a9bbf801f02d73a1ecfedbf7d44955
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 7e299e5a5fd2d6a87cfea37617ebd57da27de7e2
https://github.com/Perl/perl5/commit/7e299e5a5fd2d6a87cfea37617ebd57da27de7e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 2288819a5a24d09ec15858ad23a247912705f099
https://github.com/Perl/perl5/commit/2288819a5a24d09ec15858ad23a247912705f099
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 16f96f9e45903adb0c3a13297bd0ac04d9d79cfc
https://github.com/Perl/perl5/commit/16f96f9e45903adb0c3a13297bd0ac04d9d79cfc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 62e5a2a707ddf49ea62bae43d07eeb7c3e56ac74
https://github.com/Perl/perl5/commit/62e5a2a707ddf49ea62bae43d07eeb7c3e56ac74
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 8c701d614046f892c4fb6aa65a355d793d72bb16
https://github.com/Perl/perl5/commit/8c701d614046f892c4fb6aa65a355d793d72bb16
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: a6365fef72460bfc7b998eba007200372be4ec7d
https://github.com/Perl/perl5/commit/a6365fef72460bfc7b998eba007200372be4ec7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 58b26c3c9220f3d5bd4053162ab920e85ddb472d
https://github.com/Perl/perl5/commit/58b26c3c9220f3d5bd4053162ab920e85ddb472d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: a8ad3d9af02f13e2e3d337375fcd5f0d71d31858
https://github.com/Perl/perl5/commit/a8ad3d9af02f13e2e3d337375fcd5f0d71d31858
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 3c68144cfcc58227703b20c8fa3c4620bcea0a55
https://github.com/Perl/perl5/commit/3c68144cfcc58227703b20c8fa3c4620bcea0a55
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: dcf2aa8d7f94e159e7cf1d2457cb77fde51bbda4
https://github.com/Perl/perl5/commit/dcf2aa8d7f94e159e7cf1d2457cb77fde51bbda4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 25e44683dd1f0f066bd601e723592e84909a6721
https://github.com/Perl/perl5/commit/25e44683dd1f0f066bd601e723592e84909a6721
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 820b3329e2f8d77fa4560ed2a1de7a895b0e131c
https://github.com/Perl/perl5/commit/820b3329e2f8d77fa4560ed2a1de7a895b0e131c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 8873f1c9e79ab938c88a238ac9f4986d9b44bfbe
https://github.com/Perl/perl5/commit/8873f1c9e79ab938c88a238ac9f4986d9b44bfbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 737d59b9b42001c0864cc73d3b4d838308a3c72c
https://github.com/Perl/perl5/commit/737d59b9b42001c0864cc73d3b4d838308a3c72c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 0d9d5bd36ea4ea74fc50705704cca0819deeb18b
https://github.com/Perl/perl5/commit/0d9d5bd36ea4ea74fc50705704cca0819deeb18b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 99ec1717dafed5302db6a62608227c3fd4d75b40
https://github.com/Perl/perl5/commit/99ec1717dafed5302db6a62608227c3fd4d75b40
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 81455ccd75a4f68adf88b6f8bfbfff2d4d4f191d
https://github.com/Perl/perl5/commit/81455ccd75a4f68adf88b6f8bfbfff2d4d4f191d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 66ebeaa630e6388cf32e4a52e5625cc087f7a4ae
https://github.com/Perl/perl5/commit/66ebeaa630e6388cf32e4a52e5625cc087f7a4ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 2bb224645b87e7cb07676c2ccc7bc3e4dac35dd1
https://github.com/Perl/perl5/commit/2bb224645b87e7cb07676c2ccc7bc3e4dac35dd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: c75791fb017ecd719ed05f73dc627202b562f8c6
https://github.com/Perl/perl5/commit/c75791fb017ecd719ed05f73dc627202b562f8c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 3d15b97c3b2228dec833a866f7e8191e828dc0bd
https://github.com/Perl/perl5/commit/3d15b97c3b2228dec833a866f7e8191e828dc0bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: e07454eafe099d9a9b09dfae406258eb2bc29c0e
https://github.com/Perl/perl5/commit/e07454eafe099d9a9b09dfae406258eb2bc29c0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 21f189684c5400da57fd36015c9063086640fa01
https://github.com/Perl/perl5/commit/21f189684c5400da57fd36015c9063086640fa01
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 854a18efcd3f74a2d0d7a64186839ccd4660ad0d
https://github.com/Perl/perl5/commit/854a18efcd3f74a2d0d7a64186839ccd4660ad0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: d1c3082545d9266f168aa71b0f3374338d5c2f0d
https://github.com/Perl/perl5/commit/d1c3082545d9266f168aa71b0f3374338d5c2f0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: e9992ec11bbdd4b0fe7c6d4b1fefcf0b56e76c3a
https://github.com/Perl/perl5/commit/e9992ec11bbdd4b0fe7c6d4b1fefcf0b56e76c3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: e49d15af3c2adae44bc006d607a98e0ffdd7cb76
https://github.com/Perl/perl5/commit/e49d15af3c2adae44bc006d607a98e0ffdd7cb76
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: f15e23214d585b403c0b5321e5febab4dcbd57d5
https://github.com/Perl/perl5/commit/f15e23214d585b403c0b5321e5febab4dcbd57d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 5b073d46e13cc411960f86f350a1c13dafeb01ae
https://github.com/Perl/perl5/commit/5b073d46e13cc411960f86f350a1c13dafeb01ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 0638eb82ac7a8fdc62b3900b84adb1e38462e5ef
https://github.com/Perl/perl5/commit/0638eb82ac7a8fdc62b3900b84adb1e38462e5ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 02fd065bb09404bbb075f589c6f7c42f3d6c7eed
https://github.com/Perl/perl5/commit/02fd065bb09404bbb075f589c6f7c42f3d6c7eed
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 46f620f8f14d28abf15dd2e02b32580b98f0bbca
https://github.com/Perl/perl5/commit/46f620f8f14d28abf15dd2e02b32580b98f0bbca
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: d3f2af8115948bd96beef2df65b3c77dcb789831
https://github.com/Perl/perl5/commit/d3f2af8115948bd96beef2df65b3c77dcb789831
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 9ba861dc03ded0590934acea1476b950c99dc9a7
https://github.com/Perl/perl5/commit/9ba861dc03ded0590934acea1476b950c99dc9a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 34ce1e582f5d4c47121618ce81e8fbb0c348a006
https://github.com/Perl/perl5/commit/34ce1e582f5d4c47121618ce81e8fbb0c348a006
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 4a2b1561da753d52befc020a7e51840157b7e522
https://github.com/Perl/perl5/commit/4a2b1561da753d52befc020a7e51840157b7e522
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: f5ef07be7baf22d9dbe2c59fe20019bc19c61699
https://github.com/Perl/perl5/commit/f5ef07be7baf22d9dbe2c59fe20019bc19c61699
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: aadb9cdf1e8032445de2ad10cad8426ef7711d52
https://github.com/Perl/perl5/commit/aadb9cdf1e8032445de2ad10cad8426ef7711d52
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 1ba5f073d3b891ef8f47629d1da68be41f5c81da
https://github.com/Perl/perl5/commit/1ba5f073d3b891ef8f47629d1da68be41f5c81da
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: de493fc9a4671ecc236748789b4251a6a15bcb18
https://github.com/Perl/perl5/commit/de493fc9a4671ecc236748789b4251a6a15bcb18
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 6de9235d227bb3db4add27ccce28d223ce490026
https://github.com/Perl/perl5/commit/6de9235d227bb3db4add27ccce28d223ce490026
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 10c8bcbe18f7f8fa623dbe7db3d521e1c360f14e
https://github.com/Perl/perl5/commit/10c8bcbe18f7f8fa623dbe7db3d521e1c360f14e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 4a7748d23c368408940245ffdf9b15b4a3094793
https://github.com/Perl/perl5/commit/4a7748d23c368408940245ffdf9b15b4a3094793
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 105b193577d57e235fd141ba4d2f9abd0a69309f
https://github.com/Perl/perl5/commit/105b193577d57e235fd141ba4d2f9abd0a69309f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 3e6ab8ac385b79ee5dbd007e710b56e51bfb6cd4
https://github.com/Perl/perl5/commit/3e6ab8ac385b79ee5dbd007e710b56e51bfb6cd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: c165f2a10254cfed95c01a8be87c035de7e92fe8
https://github.com/Perl/perl5/commit/c165f2a10254cfed95c01a8be87c035de7e92fe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 98fd8077ad3bebd90201610556eccbc7f2a54ebd
https://github.com/Perl/perl5/commit/98fd8077ad3bebd90201610556eccbc7f2a54ebd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 894ffa30c411e6b6aee630c713fb5d5e21f2ac0c
https://github.com/Perl/perl5/commit/894ffa30c411e6b6aee630c713fb5d5e21f2ac0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 9cda5e020545bbcbaa14deb08aa94bac3af17d5c
https://github.com/Perl/perl5/commit/9cda5e020545bbcbaa14deb08aa94bac3af17d5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 8970a8c9ace2eae74c6017f7e5c8f4a3c4262069
https://github.com/Perl/perl5/commit/8970a8c9ace2eae74c6017f7e5c8f4a3c4262069
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: bbd3a5a094a6028b5b77d8e5fcbf23f2d427bd5b
https://github.com/Perl/perl5/commit/bbd3a5a094a6028b5b77d8e5fcbf23f2d427bd5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 2455bed1c40acbf0a83f2ee1fdf86bea3caf94f3
https://github.com/Perl/perl5/commit/2455bed1c40acbf0a83f2ee1fdf86bea3caf94f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 657aade099ddb352d84bdbd7efff4e4db324c6eb
https://github.com/Perl/perl5/commit/657aade099ddb352d84bdbd7efff4e4db324c6eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: a05a51b8bb28f2cfaeb494cf56fe50fe08ecccf4
https://github.com/Perl/perl5/commit/a05a51b8bb28f2cfaeb494cf56fe50fe08ecccf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 9cb462df5c8d25130a95d28c921100d1a69f63f8
https://github.com/Perl/perl5/commit/9cb462df5c8d25130a95d28c921100d1a69f63f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: deb2ea050ca0c2726e302e75f6a77f4afd4069d2
https://github.com/Perl/perl5/commit/deb2ea050ca0c2726e302e75f6a77f4afd4069d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 555965ed1094c8f56ec178d6a0f2ad5609748f44
https://github.com/Perl/perl5/commit/555965ed1094c8f56ec178d6a0f2ad5609748f44
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 12b27246b269cd11247eee0a2cc62bd723a75dc1
https://github.com/Perl/perl5/commit/12b27246b269cd11247eee0a2cc62bd723a75dc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: f756dcab73d0968bcbb76ae2a1730576ced39d01
https://github.com/Perl/perl5/commit/f756dcab73d0968bcbb76ae2a1730576ced39d01
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: a6421c6782df66e952c0afae51351f103f5fb9a4
https://github.com/Perl/perl5/commit/a6421c6782df66e952c0afae51351f103f5fb9a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 30189540fe457e4c652b7ce75616ba123c0136ed
https://github.com/Perl/perl5/commit/30189540fe457e4c652b7ce75616ba123c0136ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 2c90ee2f1655658f61ae06bca5a6d167987a8b71
https://github.com/Perl/perl5/commit/2c90ee2f1655658f61ae06bca5a6d167987a8b71
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0e708fc3d2c080b11da2ba0325fa8a32fc241226
https://github.com/Perl/perl5/commit/0e708fc3d2c080b11da2ba0325fa8a32fc241226
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 1dae95538e579c1c3f94ec0458388113c4ca2c78
https://github.com/Perl/perl5/commit/1dae95538e579c1c3f94ec0458388113c4ca2c78
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: ba1014b3034c1282df408bcc6e04d4915eacec7e
https://github.com/Perl/perl5/commit/ba1014b3034c1282df408bcc6e04d4915eacec7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: c24f92354a2ab073b93564c599074676f29351a4
https://github.com/Perl/perl5/commit/c24f92354a2ab073b93564c599074676f29351a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 1845758570a611b024f4d77647253415d21aaa60
https://github.com/Perl/perl5/commit/1845758570a611b024f4d77647253415d21aaa60
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 80eb66f2e68a57fb29f6e5a3ad6d3a70d340a2a8
https://github.com/Perl/perl5/commit/80eb66f2e68a57fb29f6e5a3ad6d3a70d340a2a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 785a6d53d124db33b867b5dc5e0a752aa93bf7a7
https://github.com/Perl/perl5/commit/785a6d53d124db33b867b5dc5e0a752aa93bf7a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: a2c3b46c056d02cdf02b3c027db634e1ce8ae0e2
https://github.com/Perl/perl5/commit/a2c3b46c056d02cdf02b3c027db634e1ce8ae0e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 7b2d41d8d2c7a951fb84fbfb2ebe53a4c47d8d16
https://github.com/Perl/perl5/commit/7b2d41d8d2c7a951fb84fbfb2ebe53a4c47d8d16
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 98d9f700cb9532b2be20f0cc6ae275b8b7e9351c
https://github.com/Perl/perl5/commit/98d9f700cb9532b2be20f0cc6ae275b8b7e9351c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: f913cbf045b5fcc4bd41c9dd726f3ecf1f29b330
https://github.com/Perl/perl5/commit/f913cbf045b5fcc4bd41c9dd726f3ecf1f29b330
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 49109944b9949d6d7be4e3dc7f803316efdbc6d2
https://github.com/Perl/perl5/commit/49109944b9949d6d7be4e3dc7f803316efdbc6d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 4bdc242d3931942cb9cb9a2a4f1db76c6deae047
https://github.com/Perl/perl5/commit/4bdc242d3931942cb9cb9a2a4f1db76c6deae047
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 8bdd015811ec0d076bd0797e27268a8aa52d894d
https://github.com/Perl/perl5/commit/8bdd015811ec0d076bd0797e27268a8aa52d894d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: e70ce72498013cc58629a5ad589bd702873dea38
https://github.com/Perl/perl5/commit/e70ce72498013cc58629a5ad589bd702873dea38
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 1db9a613a1d8f2f8317de2d179f81f452dcf5f6a
https://github.com/Perl/perl5/commit/1db9a613a1d8f2f8317de2d179f81f452dcf5f6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 8fa17e36bd3943d8ad60627fc388db5322b446f8
https://github.com/Perl/perl5/commit/8fa17e36bd3943d8ad60627fc388db5322b446f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 0a029b85d8aee764ab530a5ac994d815b482c3eb
https://github.com/Perl/perl5/commit/0a029b85d8aee764ab530a5ac994d815b482c3eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 6e397df60dc942f84f209ed2e03f986e01be2e0f
https://github.com/Perl/perl5/commit/6e397df60dc942f84f209ed2e03f986e01be2e0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 40f427e970cc3bc7b20badd10cf1a47ae83afa69
https://github.com/Perl/perl5/commit/40f427e970cc3bc7b20badd10cf1a47ae83afa69
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 4df9a09f2df43c8a86fdbc93505939a7e83fc193
https://github.com/Perl/perl5/commit/4df9a09f2df43c8a86fdbc93505939a7e83fc193
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: c62124cceee6406ae0ddef4d5648ba5be1ed5ffc
https://github.com/Perl/perl5/commit/c62124cceee6406ae0ddef4d5648ba5be1ed5ffc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 02c2f6a7e243b44a77b7501927fa31ab218f302a
https://github.com/Perl/perl5/commit/02c2f6a7e243b44a77b7501927fa31ab218f302a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 66c00811670e0c435fcd7285a152ba90546c22e1
https://github.com/Perl/perl5/commit/66c00811670e0c435fcd7285a152ba90546c22e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 14bd61c30f712765a704adbc26cd69a3c4304230
https://github.com/Perl/perl5/commit/14bd61c30f712765a704adbc26cd69a3c4304230
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: f95994f16f93668b71639903d9a82cdd4d25efb3
https://github.com/Perl/perl5/commit/f95994f16f93668b71639903d9a82cdd4d25efb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 13363fe43d8115416bbded2dcd346eb9ec839fc4
https://github.com/Perl/perl5/commit/13363fe43d8115416bbded2dcd346eb9ec839fc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c0c3595621f2cba940c335e66e37cb26bc8f6873
https://github.com/Perl/perl5/commit/c0c3595621f2cba940c335e66e37cb26bc8f6873
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 38a896360eee4dd92fab7e8932367ae3f451161a
https://github.com/Perl/perl5/commit/38a896360eee4dd92fab7e8932367ae3f451161a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 832b34df35c8aee241e9c141ca165c5a008c878f
https://github.com/Perl/perl5/commit/832b34df35c8aee241e9c141ca165c5a008c878f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: f91a9f73ae2f6731852da7d1095944bcd51288d8
https://github.com/Perl/perl5/commit/f91a9f73ae2f6731852da7d1095944bcd51288d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 8eddd0e0ce48a477593a200b09e995679b0c629e
https://github.com/Perl/perl5/commit/8eddd0e0ce48a477593a200b09e995679b0c629e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: b3f40834414b7741352149a6fbd84a36e0a50d29
https://github.com/Perl/perl5/commit/b3f40834414b7741352149a6fbd84a36e0a50d29
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: e1772d8c0eb75fd056f6d2c329541cb7df102885
https://github.com/Perl/perl5/commit/e1772d8c0eb75fd056f6d2c329541cb7df102885
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 927fc4e81d02fa24efd4e6352302b6ab032e83dd
https://github.com/Perl/perl5/commit/927fc4e81d02fa24efd4e6352302b6ab032e83dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 837e6f9aaa33ce72112327f544b98ee2d449aefd
https://github.com/Perl/perl5/commit/837e6f9aaa33ce72112327f544b98ee2d449aefd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 3bee47cab0eb0d58b58638c4dead8e1d5be0b5e4
https://github.com/Perl/perl5/commit/3bee47cab0eb0d58b58638c4dead8e1d5be0b5e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 4a67dcbb9c384ab2d828f4c2763131cf60fd5894
https://github.com/Perl/perl5/commit/4a67dcbb9c384ab2d828f4c2763131cf60fd5894
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 70f44fc9b001a2fb252cec5d75d473b22951b5d8
https://github.com/Perl/perl5/commit/70f44fc9b001a2fb252cec5d75d473b22951b5d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 709e2379f411e72477ae5f83c68c716c7c3672db
https://github.com/Perl/perl5/commit/709e2379f411e72477ae5f83c68c716c7c3672db
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e694e41b3f17e3db27efb8b03645b19cc34cd919
https://github.com/Perl/perl5/commit/e694e41b3f17e3db27efb8b03645b19cc34cd919
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: dbb60d05268ecc7de5a2745e1cf054e7bd9fa1bc
https://github.com/Perl/perl5/commit/dbb60d05268ecc7de5a2745e1cf054e7bd9fa1bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 6f832b5d9e12e58b69fe6f526e7a08b780b276d4
https://github.com/Perl/perl5/commit/6f832b5d9e12e58b69fe6f526e7a08b780b276d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 96b8a2b191af239a664c9d7075d6b0b2b2bd9eeb
https://github.com/Perl/perl5/commit/96b8a2b191af239a664c9d7075d6b0b2b2bd9eeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 877ed74b1e189bde3aa71956d95e2f993bace767
https://github.com/Perl/perl5/commit/877ed74b1e189bde3aa71956d95e2f993bace767
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: b2e9ca9693f5caaddbe3927ab16e239c404a02fc
https://github.com/Perl/perl5/commit/b2e9ca9693f5caaddbe3927ab16e239c404a02fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: fd7d4ea8445d75891c28b1e7d167d2ceeb987e94
https://github.com/Perl/perl5/commit/fd7d4ea8445d75891c28b1e7d167d2ceeb987e94
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 4d0ddd2006173c7c8879b59f702d8bd911cdb1aa
https://github.com/Perl/perl5/commit/4d0ddd2006173c7c8879b59f702d8bd911cdb1aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fb1983fd21cb9e56c4a16289c607892341d227d2
https://github.com/Perl/perl5/commit/fb1983fd21cb9e56c4a16289c607892341d227d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: f5218a022ed14b9258de42479e758544844f7c17
https://github.com/Perl/perl5/commit/f5218a022ed14b9258de42479e758544844f7c17
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: e66c25e885c74066054df6d2604a3c66b864fbd6
https://github.com/Perl/perl5/commit/e66c25e885c74066054df6d2604a3c66b864fbd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 3ff89bca3e23d653c42b07de32989a01294781c6
https://github.com/Perl/perl5/commit/3ff89bca3e23d653c42b07de32989a01294781c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 1c48e251a3cbece94228129f97e0ec0734b6465d
https://github.com/Perl/perl5/commit/1c48e251a3cbece94228129f97e0ec0734b6465d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 54da04ec6ba4726a94e9ce78f9819e8684aa68d0
https://github.com/Perl/perl5/commit/54da04ec6ba4726a94e9ce78f9819e8684aa68d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 13fa2d6fa2a62a388d556d9f93d453c4321f646f
https://github.com/Perl/perl5/commit/13fa2d6fa2a62a388d556d9f93d453c4321f646f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c6db796d99f9b9a77314e9f1a525a42a66993c13
https://github.com/Perl/perl5/commit/c6db796d99f9b9a77314e9f1a525a42a66993c13
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: d996dceacb01226f48bde615be359ed186e4dc54
https://github.com/Perl/perl5/commit/d996dceacb01226f48bde615be359ed186e4dc54
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 3d3a8eb92aa5a577db5ef276aca50188252f35d2
https://github.com/Perl/perl5/commit/3d3a8eb92aa5a577db5ef276aca50188252f35d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 5ef9300361a7a0084861353ea26ee2e8c4154c6e
https://github.com/Perl/perl5/commit/5ef9300361a7a0084861353ea26ee2e8c4154c6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 361081302c67c7169f076b33eddc80a75d4ac4c6
https://github.com/Perl/perl5/commit/361081302c67c7169f076b33eddc80a75d4ac4c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: f24e29a4a59804028a14bbb904d5663e95d718c1
https://github.com/Perl/perl5/commit/f24e29a4a59804028a14bbb904d5663e95d718c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 705d9091072c2413ece4b47b4c0197afc6cf16a7
https://github.com/Perl/perl5/commit/705d9091072c2413ece4b47b4c0197afc6cf16a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: f961fa93b09e175e241f8634e593cca0a7e142b9
https://github.com/Perl/perl5/commit/f961fa93b09e175e241f8634e593cca0a7e142b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 0f903a12a31cc480979624f23c466f1967b42060
https://github.com/Perl/perl5/commit/0f903a12a31cc480979624f23c466f1967b42060
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 7297c2d2fcd5924326e32424724788bc7800136c
https://github.com/Perl/perl5/commit/7297c2d2fcd5924326e32424724788bc7800136c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: c9016ad7bacfa36a692d4a030a52dc5972c1b084
https://github.com/Perl/perl5/commit/c9016ad7bacfa36a692d4a030a52dc5972c1b084
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: 6dbd6f780502ce90c7c77e5cf2e334238d237332
https://github.com/Perl/perl5/commit/6dbd6f780502ce90c7c77e5cf2e334238d237332
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a7fb2f85a8a2daac477bdeca5030df6acdfcf7be
https://github.com/Perl/perl5/commit/a7fb2f85a8a2daac477bdeca5030df6acdfcf7be
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 138344f060ea749800ce88195d34c09a1debbf72
https://github.com/Perl/perl5/commit/138344f060ea749800ce88195d34c09a1debbf72
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 75ea739caaf007421e3a3e9025c524ddffddc545
https://github.com/Perl/perl5/commit/75ea739caaf007421e3a3e9025c524ddffddc545
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M numeric.c
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
30
Compare: https://github.com/Perl/perl5/compare/9b234bc74db3...75ea739caaf0
