Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 23bcab06fc7493abb1fc09409c8cba013586459c
https://github.com/Perl/perl5/commit/23bcab06fc7493abb1fc09409c8cba013586459c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: b83343eda348d891649a6b5604a7ce16ad6c2d06
https://github.com/Perl/perl5/commit/b83343eda348d891649a6b5604a7ce16ad6c2d06
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 60d2a6f0d8926ed7d7ade2f1b7670ae3a6f05b96
https://github.com/Perl/perl5/commit/60d2a6f0d8926ed7d7ade2f1b7670ae3a6f05b96
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: b8704dfdc474892f7e657896b273c45625133bdd
https://github.com/Perl/perl5/commit/b8704dfdc474892f7e657896b273c45625133bdd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: f43c9e1241c8f8338c046ac1de06431326fe99bf
https://github.com/Perl/perl5/commit/f43c9e1241c8f8338c046ac1de06431326fe99bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 76922f17081d3d3ba6a4c7fe62611a4a42023db7
https://github.com/Perl/perl5/commit/76922f17081d3d3ba6a4c7fe62611a4a42023db7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 280519da8f42b7b7f8ea31bf81215f21f0eaa2a7
https://github.com/Perl/perl5/commit/280519da8f42b7b7f8ea31bf81215f21f0eaa2a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 028c541a18bddee0d4e40575989ca1073b9ad435
https://github.com/Perl/perl5/commit/028c541a18bddee0d4e40575989ca1073b9ad435
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 86d01c0e6579bba2dd7c39f0b22a9e72dfea4e5c
https://github.com/Perl/perl5/commit/86d01c0e6579bba2dd7c39f0b22a9e72dfea4e5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: da9622fd6a5f166af64354156f3f75fac7823f4e
https://github.com/Perl/perl5/commit/da9622fd6a5f166af64354156f3f75fac7823f4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: c5f6c4099dc5eee4e65e5ed74a2caed0a3853f51
https://github.com/Perl/perl5/commit/c5f6c4099dc5eee4e65e5ed74a2caed0a3853f51
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: d044cd4942c798cd49ef0ade2e16f9d7f957ad50
https://github.com/Perl/perl5/commit/d044cd4942c798cd49ef0ade2e16f9d7f957ad50
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 577e0219dcd298db1cd46cdf2b1b01c6bddedcfe
https://github.com/Perl/perl5/commit/577e0219dcd298db1cd46cdf2b1b01c6bddedcfe
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 826b976083aaf65ff74ed02db97e168d3c8361e3
https://github.com/Perl/perl5/commit/826b976083aaf65ff74ed02db97e168d3c8361e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: a35477a8dfd6b5ff962936d7ecd9031ffa3ee6c1
https://github.com/Perl/perl5/commit/a35477a8dfd6b5ff962936d7ecd9031ffa3ee6c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 2cb2414dc3cf842d70565518877082137d5c235e
https://github.com/Perl/perl5/commit/2cb2414dc3cf842d70565518877082137d5c235e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 98d866212406471f14f103da95566219397155c7
https://github.com/Perl/perl5/commit/98d866212406471f14f103da95566219397155c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 79f8f666ee010dfdbbcc7aa97c9c7e62f7c50319
https://github.com/Perl/perl5/commit/79f8f666ee010dfdbbcc7aa97c9c7e62f7c50319
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 1ac04223c15e1454c5d5522993aa038339c3b59d
https://github.com/Perl/perl5/commit/1ac04223c15e1454c5d5522993aa038339c3b59d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 619e46d0cc7c4b2abc86ab222a8869708f6a555b
https://github.com/Perl/perl5/commit/619e46d0cc7c4b2abc86ab222a8869708f6a555b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 90ed13db63dc6b620355f0891e9f79a575e52593
https://github.com/Perl/perl5/commit/90ed13db63dc6b620355f0891e9f79a575e52593
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 8c94d57c8240fd036384adff065fed0cb7bc5b92
https://github.com/Perl/perl5/commit/8c94d57c8240fd036384adff065fed0cb7bc5b92
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: c55b6e111d6543c8057bc42f097d9a489db0cff9
https://github.com/Perl/perl5/commit/c55b6e111d6543c8057bc42f097d9a489db0cff9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: f28d343d995bc47765f20eb0f88ca21d06a10210
https://github.com/Perl/perl5/commit/f28d343d995bc47765f20eb0f88ca21d06a10210
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: e21964118de675bf4c948daa0487f07af6d48045
https://github.com/Perl/perl5/commit/e21964118de675bf4c948daa0487f07af6d48045
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 4d3a9de04c933c3382c51ffd8571bea8414645ae
https://github.com/Perl/perl5/commit/4d3a9de04c933c3382c51ffd8571bea8414645ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 848de4f81795a575a7a0f29abce57a08870dedfd
https://github.com/Perl/perl5/commit/848de4f81795a575a7a0f29abce57a08870dedfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 9acecf921eaf4c21e4b22d5bfd2d76d7c4962850
https://github.com/Perl/perl5/commit/9acecf921eaf4c21e4b22d5bfd2d76d7c4962850
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: baf6575cec5f927bac4043b4929ccd3d8e3fea3c
https://github.com/Perl/perl5/commit/baf6575cec5f927bac4043b4929ccd3d8e3fea3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 42d64ebde08275ee5b8b163f2f3ec422b9a04bf7
https://github.com/Perl/perl5/commit/42d64ebde08275ee5b8b163f2f3ec422b9a04bf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 3d0b3096ddaf15e5928df713a2b5bbe85e597a1b
https://github.com/Perl/perl5/commit/3d0b3096ddaf15e5928df713a2b5bbe85e597a1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 89860da73b14373997be5a55f163094510ae31c3
https://github.com/Perl/perl5/commit/89860da73b14373997be5a55f163094510ae31c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: fce9d91ad25aef58128ed73c605517b0cd61789e
https://github.com/Perl/perl5/commit/fce9d91ad25aef58128ed73c605517b0cd61789e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 6fadb19235f455bd2d0d40f103c4c3a6e34bc28a
https://github.com/Perl/perl5/commit/6fadb19235f455bd2d0d40f103c4c3a6e34bc28a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 5139b0452f78730aef59fc149503a6e546e93098
https://github.com/Perl/perl5/commit/5139b0452f78730aef59fc149503a6e546e93098
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 2355a4d5b21e294faec689296116035a97d76f94
https://github.com/Perl/perl5/commit/2355a4d5b21e294faec689296116035a97d76f94
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: da832870d938cdcacd35a39f3350098b22c93fe4
https://github.com/Perl/perl5/commit/da832870d938cdcacd35a39f3350098b22c93fe4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: c96767b6df1485837c13ace97002cc8cdb2b9dde
https://github.com/Perl/perl5/commit/c96767b6df1485837c13ace97002cc8cdb2b9dde
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 4effa499bcdae885f8f790ce538538b9cb9132f1
https://github.com/Perl/perl5/commit/4effa499bcdae885f8f790ce538538b9cb9132f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: affb3f81e866660698c209782f7bb465b9002021
https://github.com/Perl/perl5/commit/affb3f81e866660698c209782f7bb465b9002021
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 704764bd8ebe8af1bb097d13e2e79caca7b6ace7
https://github.com/Perl/perl5/commit/704764bd8ebe8af1bb097d13e2e79caca7b6ace7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: d791e58d1e6fa88cf4d8fed7bcc9a01281ff0573
https://github.com/Perl/perl5/commit/d791e58d1e6fa88cf4d8fed7bcc9a01281ff0573
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 6f3249c259101e5fda615172b7f5fdd69c98d58f
https://github.com/Perl/perl5/commit/6f3249c259101e5fda615172b7f5fdd69c98d58f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 3b91eaf4d0ce1c18ecca794aafe436a69e7d843b
https://github.com/Perl/perl5/commit/3b91eaf4d0ce1c18ecca794aafe436a69e7d843b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 6e179cdd0d4b4a8907825617116e7f1cec10cbd8
https://github.com/Perl/perl5/commit/6e179cdd0d4b4a8907825617116e7f1cec10cbd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: db1f5e89184100688beb687b8a804f448a58acb7
https://github.com/Perl/perl5/commit/db1f5e89184100688beb687b8a804f448a58acb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: b817fe5d958e3d685898cc072685dcefc3d98ad9
https://github.com/Perl/perl5/commit/b817fe5d958e3d685898cc072685dcefc3d98ad9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: a68ade669886465351ee079acd2618c14ef98df2
https://github.com/Perl/perl5/commit/a68ade669886465351ee079acd2618c14ef98df2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 317459d1a40c0f69114e48594834fcfd9ba4d787
https://github.com/Perl/perl5/commit/317459d1a40c0f69114e48594834fcfd9ba4d787
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 4af8b5562d3dcb390c59b3e5b081b5eeb33fa180
https://github.com/Perl/perl5/commit/4af8b5562d3dcb390c59b3e5b081b5eeb33fa180
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 1a04e1714a1340ce9212f93644703f9d3e688549
https://github.com/Perl/perl5/commit/1a04e1714a1340ce9212f93644703f9d3e688549
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: c3a0b1ce13bac70a38fd65c674ca1d315cc4bc0c
https://github.com/Perl/perl5/commit/c3a0b1ce13bac70a38fd65c674ca1d315cc4bc0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: ff1f8d227e423c038c0295304b4bf3363afe0d3f
https://github.com/Perl/perl5/commit/ff1f8d227e423c038c0295304b4bf3363afe0d3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 9f64d9f72ffc940258f4360eebc81574fa22ecae
https://github.com/Perl/perl5/commit/9f64d9f72ffc940258f4360eebc81574fa22ecae
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 3a51bb3eb562bd2f81998bcf9df9ce0392471e6f
https://github.com/Perl/perl5/commit/3a51bb3eb562bd2f81998bcf9df9ce0392471e6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 740daece094ea79ea55cf7872912c0b989624aa1
https://github.com/Perl/perl5/commit/740daece094ea79ea55cf7872912c0b989624aa1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: af3a4b6e5b3c732b775ad15ce81ed5e1d19e0b06
https://github.com/Perl/perl5/commit/af3a4b6e5b3c732b775ad15ce81ed5e1d19e0b06
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 9d79a67c0b2473f833e7df300f4668b72113177a
https://github.com/Perl/perl5/commit/9d79a67c0b2473f833e7df300f4668b72113177a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
XXX fails tests locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 13f1ffe98222989decd972e41257b5b68f2b83ca
https://github.com/Perl/perl5/commit/13f1ffe98222989decd972e41257b5b68f2b83ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: bcf1eee26cce1555b9d51865c2fd38913f59ec20
https://github.com/Perl/perl5/commit/bcf1eee26cce1555b9d51865c2fd38913f59ec20
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 1a8008e217513592c94404380a5e01f4628fdd24
https://github.com/Perl/perl5/commit/1a8008e217513592c94404380a5e01f4628fdd24
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: c58c2861e58bcd27af57af33e2305317b3f637da
https://github.com/Perl/perl5/commit/c58c2861e58bcd27af57af33e2305317b3f637da
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: cf6296465edad327d152cd1ad4f2fcaec54026bd
https://github.com/Perl/perl5/commit/cf6296465edad327d152cd1ad4f2fcaec54026bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 7138a80a19b9c7da4a76c8c8a4beedc1507facdb
https://github.com/Perl/perl5/commit/7138a80a19b9c7da4a76c8c8a4beedc1507facdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 4b44bc96e639343b50909f7a15cb46d953ffe076
https://github.com/Perl/perl5/commit/4b44bc96e639343b50909f7a15cb46d953ffe076
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3d68d5de3d2db1ce44307da7a045940e478d16a7
https://github.com/Perl/perl5/commit/3d68d5de3d2db1ce44307da7a045940e478d16a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 84daf68717c7d61e7b4cf9d0b037be310765e14b
https://github.com/Perl/perl5/commit/84daf68717c7d61e7b4cf9d0b037be310765e14b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: d2811c4ee581cc85921f972c4dc5a0577043d753
https://github.com/Perl/perl5/commit/d2811c4ee581cc85921f972c4dc5a0577043d753
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 18dca1eb16d2545c9edb2dec48372c48ac63975f
https://github.com/Perl/perl5/commit/18dca1eb16d2545c9edb2dec48372c48ac63975f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Move code to appropriate place
This code dealing with the LC_CTYPE category should be controlled by
whether that category exists or not; not if some other category exists.
Commit: eaf7df3bc83d9d15f2d9500357afa42fda92ca77
https://github.com/Perl/perl5/commit/eaf7df3bc83d9d15f2d9500357afa42fda92ca77
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: e7c1e16840f9796f6ba43d79f0e12a7b3d916c4e
https://github.com/Perl/perl5/commit/e7c1e16840f9796f6ba43d79f0e12a7b3d916c4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: d494c1f519f87969f78899c4138e094c8eb63584
https://github.com/Perl/perl5/commit/d494c1f519f87969f78899c4138e094c8eb63584
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: ca8238461a167dfc4a6490a53fc09dfe1e59d0b8
https://github.com/Perl/perl5/commit/ca8238461a167dfc4a6490a53fc09dfe1e59d0b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: f7e7b7a56894e66c99ebab7a572d03accdcd283b
https://github.com/Perl/perl5/commit/f7e7b7a56894e66c99ebab7a572d03accdcd283b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 7742e28c1a325b477cbcd951edc2a30f189f02b5
https://github.com/Perl/perl5/commit/7742e28c1a325b477cbcd951edc2a30f189f02b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: adb4a6570261a09f0571364292453ea498919f2c
https://github.com/Perl/perl5/commit/adb4a6570261a09f0571364292453ea498919f2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9202e22350f810c76121ff83ca4fd6cf739d6356
https://github.com/Perl/perl5/commit/9202e22350f810c76121ff83ca4fd6cf739d6356
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: c78a3030c6e5cebe47e274e396cf78f5e717a666
https://github.com/Perl/perl5/commit/c78a3030c6e5cebe47e274e396cf78f5e717a666
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: ef84e84ffdbfd2a23522f0f2fbc12aedba29ff90
https://github.com/Perl/perl5/commit/ef84e84ffdbfd2a23522f0f2fbc12aedba29ff90
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 02c852e46c3e9e97f92ba87a2d25ab51a2311a4b
https://github.com/Perl/perl5/commit/02c852e46c3e9e97f92ba87a2d25ab51a2311a4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: d27e915f6dc6305d449d228cab585826ee37f4b1
https://github.com/Perl/perl5/commit/d27e915f6dc6305d449d228cab585826ee37f4b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 3d38ade420a311a223b925e09cb1e630cc16262a
https://github.com/Perl/perl5/commit/3d38ade420a311a223b925e09cb1e630cc16262a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: b3aa16bee3f2ec9c3f115d605257e8667a2dead9
https://github.com/Perl/perl5/commit/b3aa16bee3f2ec9c3f115d605257e8667a2dead9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: dfceefefb72a6852ad77d4642a1a686efe505c05
https://github.com/Perl/perl5/commit/dfceefefb72a6852ad77d4642a1a686efe505c05
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: f129ae4fd09d179550ea079b7b41cf0d973f0a4e
https://github.com/Perl/perl5/commit/f129ae4fd09d179550ea079b7b41cf0d973f0a4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 1c4f4c549c905a738e7beabef384dcb4df0a930d
https://github.com/Perl/perl5/commit/1c4f4c549c905a738e7beabef384dcb4df0a930d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 85c2ef8dbe9331e6191dce510402ddb98b8779fc
https://github.com/Perl/perl5/commit/85c2ef8dbe9331e6191dce510402ddb98b8779fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 43bc1fd9b12736f33e8a97b99dbde15f4c7752e2
https://github.com/Perl/perl5/commit/43bc1fd9b12736f33e8a97b99dbde15f4c7752e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 806a009deaf307a66facd76146ad8b75bf5c1d15
https://github.com/Perl/perl5/commit/806a009deaf307a66facd76146ad8b75bf5c1d15
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 8fc39539422c104ddfe6a27e7be7610f5d465085
https://github.com/Perl/perl5/commit/8fc39539422c104ddfe6a27e7be7610f5d465085
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: ebf9396b38229b606c4e5f91116c5a0871da9859
https://github.com/Perl/perl5/commit/ebf9396b38229b606c4e5f91116c5a0871da9859
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 98eb0597cbdb89d6612d41cd119e7f1b79172511
https://github.com/Perl/perl5/commit/98eb0597cbdb89d6612d41cd119e7f1b79172511
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: a7046843e4c6bc100ae4dc70f984233dde0f9b1d
https://github.com/Perl/perl5/commit/a7046843e4c6bc100ae4dc70f984233dde0f9b1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 7550765356b1427621d1ebe0853ff20affce1cfc
https://github.com/Perl/perl5/commit/7550765356b1427621d1ebe0853ff20affce1cfc
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: ef6d8735a2f321d47e4d08a352ff8257fa1a30c9
https://github.com/Perl/perl5/commit/ef6d8735a2f321d47e4d08a352ff8257fa1a30c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9c3bef4cb6c13ae37f2474392e8a872486042e7c
https://github.com/Perl/perl5/commit/9c3bef4cb6c13ae37f2474392e8a872486042e7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: f239152ad2839764a042aa1f2c5af863b47f39d9
https://github.com/Perl/perl5/commit/f239152ad2839764a042aa1f2c5af863b47f39d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 355731df2c5c05c90fb330f790bf91a67b53011f
https://github.com/Perl/perl5/commit/355731df2c5c05c90fb330f790bf91a67b53011f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: e2784cd366bce280599f04859c8f103c6c11acc7
https://github.com/Perl/perl5/commit/e2784cd366bce280599f04859c8f103c6c11acc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 787fdddffc1f446479ba6f407b7634e6a5f3c1eb
https://github.com/Perl/perl5/commit/787fdddffc1f446479ba6f407b7634e6a5f3c1eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: c2d0ca6da8fc351ade963498e635ebb02dd9684e
https://github.com/Perl/perl5/commit/c2d0ca6da8fc351ade963498e635ebb02dd9684e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 28a45953975cfc838cbccbfee06c52b5d9e86198
https://github.com/Perl/perl5/commit/28a45953975cfc838cbccbfee06c52b5d9e86198
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: bf7264934f90e922c3ffc63ffeb68cc821e2a3b0
https://github.com/Perl/perl5/commit/bf7264934f90e922c3ffc63ffeb68cc821e2a3b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: f31c8987c1a32678dc07d53a3fdc81f2f16e5aec
https://github.com/Perl/perl5/commit/f31c8987c1a32678dc07d53a3fdc81f2f16e5aec
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: bd7aa0054152ad228d88f774a2bf1db8621c962b
https://github.com/Perl/perl5/commit/bd7aa0054152ad228d88f774a2bf1db8621c962b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: a3c08ba1dcf8bced9daed67baec04dd9c92b096f
https://github.com/Perl/perl5/commit/a3c08ba1dcf8bced9daed67baec04dd9c92b096f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: bd0df873983d603a7a6791513a366a4b668ad904
https://github.com/Perl/perl5/commit/bd0df873983d603a7a6791513a366a4b668ad904
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: b5ede95cf91f99e6c4eb2bca585dce0276ee7501
https://github.com/Perl/perl5/commit/b5ede95cf91f99e6c4eb2bca585dce0276ee7501
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: f062a65d5a1cb7c19103324d1ab598269cc0a9d0
https://github.com/Perl/perl5/commit/f062a65d5a1cb7c19103324d1ab598269cc0a9d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 294e5ee0da53c56615617b13c93b89ee5ac7d474
https://github.com/Perl/perl5/commit/294e5ee0da53c56615617b13c93b89ee5ac7d474
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: c61737436d62ba85d7b67ccbe21b14301f2f4688
https://github.com/Perl/perl5/commit/c61737436d62ba85d7b67ccbe21b14301f2f4688
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: a807461697506867a9adca464fd3eb00752b4672
https://github.com/Perl/perl5/commit/a807461697506867a9adca464fd3eb00752b4672
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: baa6e14630a045615372827409cb3344cc894889
https://github.com/Perl/perl5/commit/baa6e14630a045615372827409cb3344cc894889
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: cff96fafa59e19008ae56848419d13c43ca4a1b9
https://github.com/Perl/perl5/commit/cff96fafa59e19008ae56848419d13c43ca4a1b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 66305a5b63ef5e0ebad3aeddc3d2bbd5c06fbda2
https://github.com/Perl/perl5/commit/66305a5b63ef5e0ebad3aeddc3d2bbd5c06fbda2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: cb48b1e130d8d731c2579c3791ddbc7961778114
https://github.com/Perl/perl5/commit/cb48b1e130d8d731c2579c3791ddbc7961778114
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 27c88b8d938efa88a7f601571bdcc51a774b1c8c
https://github.com/Perl/perl5/commit/27c88b8d938efa88a7f601571bdcc51a774b1c8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 83d70e76f680145cefe1fbdb1b37f4a13d30aa3a
https://github.com/Perl/perl5/commit/83d70e76f680145cefe1fbdb1b37f4a13d30aa3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 0df5836a28dc4699d5dc2b4b1d753b1ae12ffa19
https://github.com/Perl/perl5/commit/0df5836a28dc4699d5dc2b4b1d753b1ae12ffa19
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: b25385cdb9a69f1cc11b9b982d85af1dc4fb5bb7
https://github.com/Perl/perl5/commit/b25385cdb9a69f1cc11b9b982d85af1dc4fb5bb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: cf3131aa93ab67b8b221e091036d52d20734532b
https://github.com/Perl/perl5/commit/cf3131aa93ab67b8b221e091036d52d20734532b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: d3ce3472b285e559ab0278e4ac87608cc34b2dc1
https://github.com/Perl/perl5/commit/d3ce3472b285e559ab0278e4ac87608cc34b2dc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 53589e96af7424a967ec97d8c446eb60b5ec1629
https://github.com/Perl/perl5/commit/53589e96af7424a967ec97d8c446eb60b5ec1629
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 7977aea05150fe76b81e8c488b28c9f5d06f28a1
https://github.com/Perl/perl5/commit/7977aea05150fe76b81e8c488b28c9f5d06f28a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 0656845b7b533fe7a3fa551ecc025f5683c837ae
https://github.com/Perl/perl5/commit/0656845b7b533fe7a3fa551ecc025f5683c837ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: f1b08deb1c3301d123bab65039a5ed929e62ac45
https://github.com/Perl/perl5/commit/f1b08deb1c3301d123bab65039a5ed929e62ac45
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: af6dfdb2619e2c27bb5894e99feb62e7b44fe813
https://github.com/Perl/perl5/commit/af6dfdb2619e2c27bb5894e99feb62e7b44fe813
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: da149eb987d87181abf7359846e971e84d428d2c
https://github.com/Perl/perl5/commit/da149eb987d87181abf7359846e971e84d428d2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: b3d3907c2d8667220e1e26d9b42ad8de3fa31fd1
https://github.com/Perl/perl5/commit/b3d3907c2d8667220e1e26d9b42ad8de3fa31fd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: cc6f3327eef2e5e74a9a0fc3cd9688d4b3b2e948
https://github.com/Perl/perl5/commit/cc6f3327eef2e5e74a9a0fc3cd9688d4b3b2e948
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 702cb6d47afd74e50602f42738fcbebaa9f0551c
https://github.com/Perl/perl5/commit/702cb6d47afd74e50602f42738fcbebaa9f0551c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 558deb7246a1d144dc66868a91021ee9341539a0
https://github.com/Perl/perl5/commit/558deb7246a1d144dc66868a91021ee9341539a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: dd6092c73edbe55eecbd1e2a1bf52f835fd498b4
https://github.com/Perl/perl5/commit/dd6092c73edbe55eecbd1e2a1bf52f835fd498b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 29f62cdd32e5f93058ca6e0352e0872c11990e9f
https://github.com/Perl/perl5/commit/29f62cdd32e5f93058ca6e0352e0872c11990e9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 10cebb975ed9abb883a5033d64a585e2468b1217
https://github.com/Perl/perl5/commit/10cebb975ed9abb883a5033d64a585e2468b1217
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: d4736f9052667f235d3a73717413976829875490
https://github.com/Perl/perl5/commit/d4736f9052667f235d3a73717413976829875490
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 43e6d6cfcbdab62a6b5fceae33802a9c78089704
https://github.com/Perl/perl5/commit/43e6d6cfcbdab62a6b5fceae33802a9c78089704
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 1ab8edf5f1989156ab5d60f2a1d3a6dd70b5131b
https://github.com/Perl/perl5/commit/1ab8edf5f1989156ab5d60f2a1d3a6dd70b5131b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: ffe35acc1d282cedc3d5f485757a3964a5f2b368
https://github.com/Perl/perl5/commit/ffe35acc1d282cedc3d5f485757a3964a5f2b368
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: bae43607fcb9958a9642405f70b67c5e87fac6e6
https://github.com/Perl/perl5/commit/bae43607fcb9958a9642405f70b67c5e87fac6e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: c0d1336ceae6b8d241f6e9411ce43fe16b4c056b
https://github.com/Perl/perl5/commit/c0d1336ceae6b8d241f6e9411ce43fe16b4c056b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 8fa1dc3c3dd0d836a11a8b32744f58424ce3c064
https://github.com/Perl/perl5/commit/8fa1dc3c3dd0d836a11a8b32744f58424ce3c064
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: ffe724391e03572d70a24a671f9b18f323833d49
https://github.com/Perl/perl5/commit/ffe724391e03572d70a24a671f9b18f323833d49
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: a8d1ab9185922bb6933ff97c7bd17b6484f3b20b
https://github.com/Perl/perl5/commit/a8d1ab9185922bb6933ff97c7bd17b6484f3b20b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 2c4149b3479cdae0c4735a4ff1cf59c35ea62ad0
https://github.com/Perl/perl5/commit/2c4149b3479cdae0c4735a4ff1cf59c35ea62ad0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 8ab47437d708f71f929cf2cc0d6fdffff17b658b
https://github.com/Perl/perl5/commit/8ab47437d708f71f929cf2cc0d6fdffff17b658b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 021db51e4a8349d6971836535b6193e9ca95dda1
https://github.com/Perl/perl5/commit/021db51e4a8349d6971836535b6193e9ca95dda1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 1ed4ebe52be26f470de701ee07694e5cc89b12fd
https://github.com/Perl/perl5/commit/1ed4ebe52be26f470de701ee07694e5cc89b12fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: d5765a190d24c518d2aa610d1636af387841363d
https://github.com/Perl/perl5/commit/d5765a190d24c518d2aa610d1636af387841363d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 8941986d629e808eca6994a5fa627471ba4ba0d6
https://github.com/Perl/perl5/commit/8941986d629e808eca6994a5fa627471ba4ba0d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 73d50fe3a12c94939f611c8b2a2c0f74ab9cfef1
https://github.com/Perl/perl5/commit/73d50fe3a12c94939f611c8b2a2c0f74ab9cfef1
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 0e498dfe18e0d0879781d7b20783e71b5c4d6db3
https://github.com/Perl/perl5/commit/0e498dfe18e0d0879781d7b20783e71b5c4d6db3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 6a611425e65cea326108e7f54008e053313ec473
https://github.com/Perl/perl5/commit/6a611425e65cea326108e7f54008e053313ec473
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 8b5c3931efc90c7e8fb312d73c13fd02c0f2b361
https://github.com/Perl/perl5/commit/8b5c3931efc90c7e8fb312d73c13fd02c0f2b361
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 0813be5de2b95bfed94ad51abd20e36014969279
https://github.com/Perl/perl5/commit/0813be5de2b95bfed94ad51abd20e36014969279
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 328580efda92360e1322a4f4521b56cc70fab22b
https://github.com/Perl/perl5/commit/328580efda92360e1322a4f4521b56cc70fab22b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 8109c76c47ae74ce6f096770690b3108953f48bb
https://github.com/Perl/perl5/commit/8109c76c47ae74ce6f096770690b3108953f48bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 8ea17eb778a325096481934f46f4ec8e8853cb9a
https://github.com/Perl/perl5/commit/8ea17eb778a325096481934f46f4ec8e8853cb9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 5991f62a1c5b4abde78d8a1707b670d064fdb0e5
https://github.com/Perl/perl5/commit/5991f62a1c5b4abde78d8a1707b670d064fdb0e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 7a14478063b09e7f87dfec76574407d1bfae55f7
https://github.com/Perl/perl5/commit/7a14478063b09e7f87dfec76574407d1bfae55f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 648c0d35c8c89a703054471ab264e178767e895d
https://github.com/Perl/perl5/commit/648c0d35c8c89a703054471ab264e178767e895d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 80ac0a5e9e09092e7d54ac3634805f6a76ad817f
https://github.com/Perl/perl5/commit/80ac0a5e9e09092e7d54ac3634805f6a76ad817f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: ed5e86b54c3885a638fb59188b032840bf2e4aea
https://github.com/Perl/perl5/commit/ed5e86b54c3885a638fb59188b032840bf2e4aea
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 7f36775bcf6d93add73abe32a0f200cf623da69a
https://github.com/Perl/perl5/commit/7f36775bcf6d93add73abe32a0f200cf623da69a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 4f50a79ea3d980abcd2699b000c22caad5343865
https://github.com/Perl/perl5/commit/4f50a79ea3d980abcd2699b000c22caad5343865
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 045904c5f2e3d38496496187bfb47a19222c99fa
https://github.com/Perl/perl5/commit/045904c5f2e3d38496496187bfb47a19222c99fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: e57de1e812ca4a33c133ad6d86668204129b8eea
https://github.com/Perl/perl5/commit/e57de1e812ca4a33c133ad6d86668204129b8eea
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: f2dcadd7e95a1a9fbd7ddebfc5f53d160f901b4f
https://github.com/Perl/perl5/commit/f2dcadd7e95a1a9fbd7ddebfc5f53d160f901b4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 4a0f7651df076edfe7a57c98ef108ea9bb444b75
https://github.com/Perl/perl5/commit/4a0f7651df076edfe7a57c98ef108ea9bb444b75
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: c95e1ff2928448257a342cd0e5a5f6238afffc42
https://github.com/Perl/perl5/commit/c95e1ff2928448257a342cd0e5a5f6238afffc42
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 33bafcb43b95ceb0884f1055abfe1b30c0f7af55
https://github.com/Perl/perl5/commit/33bafcb43b95ceb0884f1055abfe1b30c0f7af55
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 88bce1139fb4829c2cf91c83c26c61d50ce0b5ca
https://github.com/Perl/perl5/commit/88bce1139fb4829c2cf91c83c26c61d50ce0b5ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: ee27a16e66e82f2d34e8bd2e3a26cca8e50d1bf7
https://github.com/Perl/perl5/commit/ee27a16e66e82f2d34e8bd2e3a26cca8e50d1bf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 10c6cdeb9c66e91a1e05ec05d3427094c3f37375
https://github.com/Perl/perl5/commit/10c6cdeb9c66e91a1e05ec05d3427094c3f37375
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 70d63a78c619fbadb25769e4c8193c35a0473521
https://github.com/Perl/perl5/commit/70d63a78c619fbadb25769e4c8193c35a0473521
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 00757b874157b257da286bea25bd21ce0d5eb98a
https://github.com/Perl/perl5/commit/00757b874157b257da286bea25bd21ce0d5eb98a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b15738e0e1b87e4479238faab07b874a869cdf90
https://github.com/Perl/perl5/commit/b15738e0e1b87e4479238faab07b874a869cdf90
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 3ae83d7dd4be54fd0b934aca6962c38ec27e736f
https://github.com/Perl/perl5/commit/3ae83d7dd4be54fd0b934aca6962c38ec27e736f
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 41eb24454fa7cfbd9a237108436cabcba149e9c7
https://github.com/Perl/perl5/commit/41eb24454fa7cfbd9a237108436cabcba149e9c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 11ebb02a03d62f9b49c739619730c89fae61c5f0
https://github.com/Perl/perl5/commit/11ebb02a03d62f9b49c739619730c89fae61c5f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 9bc7183d14e4e3a29fc21ac4c8d9d2d6fd7e480a
https://github.com/Perl/perl5/commit/9bc7183d14e4e3a29fc21ac4c8d9d2d6fd7e480a
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: bac43ee947901078a2c7e4b6afcc50c2bfcfc2ea
https://github.com/Perl/perl5/commit/bac43ee947901078a2c7e4b6afcc50c2bfcfc2ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 485503d6384bb586680bb518e013c652490bfc3b
https://github.com/Perl/perl5/commit/485503d6384bb586680bb518e013c652490bfc3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: ce7bad5ab85dc848fa135d3397330ac685883ed2
https://github.com/Perl/perl5/commit/ce7bad5ab85dc848fa135d3397330ac685883ed2
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 867c6ba5242aea37ac5667966745a6e5cf975bba
https://github.com/Perl/perl5/commit/867c6ba5242aea37ac5667966745a6e5cf975bba
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 97c2485b0098e80324daf1e3810a961ed01fc449
https://github.com/Perl/perl5/commit/97c2485b0098e80324daf1e3810a961ed01fc449
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 85a9cc8956bd25327e8c153f0dd1c4922fd65d40
https://github.com/Perl/perl5/commit/85a9cc8956bd25327e8c153f0dd1c4922fd65d40
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 39ab95c86b34b732e7461b44483f5586814561ab
https://github.com/Perl/perl5/commit/39ab95c86b34b732e7461b44483f5586814561ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 6815d9b916575094e7fc8322b813e69c37530748
https://github.com/Perl/perl5/commit/6815d9b916575094e7fc8322b813e69c37530748
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: feca44e90628705e2bd7db46d24253af007ad074
https://github.com/Perl/perl5/commit/feca44e90628705e2bd7db46d24253af007ad074
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 55de939141b5e155489e8cc2e2c3c6d7ef59d9c7
https://github.com/Perl/perl5/commit/55de939141b5e155489e8cc2e2c3c6d7ef59d9c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: b3a48341871d41c20e76aee2d0f19e3340235e8b
https://github.com/Perl/perl5/commit/b3a48341871d41c20e76aee2d0f19e3340235e8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 0e97eb3745920e97f7f3cd3e35949aa5054ded80
https://github.com/Perl/perl5/commit/0e97eb3745920e97f7f3cd3e35949aa5054ded80
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 2c9ea978c727973cce879602d5272b73c6258a9d
https://github.com/Perl/perl5/commit/2c9ea978c727973cce879602d5272b73c6258a9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 36e4a096b9dfde659f4d87878c291871f3a0514c
https://github.com/Perl/perl5/commit/36e4a096b9dfde659f4d87878c291871f3a0514c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 05e5f0bd9feccbecd5676141ecfd4662e7739274
https://github.com/Perl/perl5/commit/05e5f0bd9feccbecd5676141ecfd4662e7739274
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: eb0801fda656543db1f4493ac51ba187d2b3eb8e
https://github.com/Perl/perl5/commit/eb0801fda656543db1f4493ac51ba187d2b3eb8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: f08115413704501f06abc64678d40e1988df4015
https://github.com/Perl/perl5/commit/f08115413704501f06abc64678d40e1988df4015
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: b859e4b88e33760eda8e1a27e191d388becebf61
https://github.com/Perl/perl5/commit/b859e4b88e33760eda8e1a27e191d388becebf61
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: ae0e85989a4a3d723e089c6c09fdaf9e13994ce0
https://github.com/Perl/perl5/commit/ae0e85989a4a3d723e089c6c09fdaf9e13994ce0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: a453e2c81c04166ec17758772cfdfdba2d7ff96d
https://github.com/Perl/perl5/commit/a453e2c81c04166ec17758772cfdfdba2d7ff96d
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 40c1b3fdd4a7d0968d51b3126d8048f0a0be55f3
https://github.com/Perl/perl5/commit/40c1b3fdd4a7d0968d51b3126d8048f0a0be55f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: e668954ba27f5e23c053058059e78143494ab7c9
https://github.com/Perl/perl5/commit/e668954ba27f5e23c053058059e78143494ab7c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f940e7f613692e3b27e1f36e2a5112114279311c
https://github.com/Perl/perl5/commit/f940e7f613692e3b27e1f36e2a5112114279311c
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: de9f996cd09c6197dff0b74f383d3c4308059a12
https://github.com/Perl/perl5/commit/de9f996cd09c6197dff0b74f383d3c4308059a12
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: ca0fb61d8a1eed84b4c4e97b441a4331117e0002
https://github.com/Perl/perl5/commit/ca0fb61d8a1eed84b4c4e97b441a4331117e0002
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 96b1dc7df88bb7095e268fd60d0c32621249a782
https://github.com/Perl/perl5/commit/96b1dc7df88bb7095e268fd60d0c32621249a782
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: dff093c91c43bdd052f983a215062f71ebc6b1aa
https://github.com/Perl/perl5/commit/dff093c91c43bdd052f983a215062f71ebc6b1aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: c912784b00948ab87922983f317d112e8e76edcf
https://github.com/Perl/perl5/commit/c912784b00948ab87922983f317d112e8e76edcf
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: c5f3985978d93a25e6590a0a0a1b13920f238d55
https://github.com/Perl/perl5/commit/c5f3985978d93a25e6590a0a0a1b13920f238d55
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 8ca34763f117488de56e48c1e70f81570658a7eb
https://github.com/Perl/perl5/commit/8ca34763f117488de56e48c1e70f81570658a7eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 1059fd93acba000d0d927279f03df8fbc48726bb
https://github.com/Perl/perl5/commit/1059fd93acba000d0d927279f03df8fbc48726bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 78dbfd802f423272d63a429a671cc153bac81883
https://github.com/Perl/perl5/commit/78dbfd802f423272d63a429a671cc153bac81883
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Fix up a comment
Commit: 2da46af3a3db8fe53639d1c16e95ae81f6346ed0
https://github.com/Perl/perl5/commit/2da46af3a3db8fe53639d1c16e95ae81f6346ed0
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 9b234bc74db367402754721c827f897e5e5e5dec
https://github.com/Perl/perl5/commit/9b234bc74db367402754721c827f897e5e5e5dec
Author: Karl Williamson <[email protected]>
Date: 2021-04-10 (Sat, 10 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M embedvar.h
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M perl.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
29
Compare: https://github.com/Perl/perl5/compare/f94ca0a9909b...9b234bc74db3
