Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 522e9556c5a133adec6d6906b61e7221267ba45c
https://github.com/Perl/perl5/commit/522e9556c5a133adec6d6906b61e7221267ba45c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 25f0f266f473451f82b9e3a47526cb5fe7638458
https://github.com/Perl/perl5/commit/25f0f266f473451f82b9e3a47526cb5fe7638458
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 2f15e727137dc91fa8bd8169c1918e8acc59c9e9
https://github.com/Perl/perl5/commit/2f15e727137dc91fa8bd8169c1918e8acc59c9e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: df1f86e19cb3f4a9c0ee32f81546d300ad476ff2
https://github.com/Perl/perl5/commit/df1f86e19cb3f4a9c0ee32f81546d300ad476ff2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: ffa1355e16a5b347e50e8f0971b8622224ec55ef
https://github.com/Perl/perl5/commit/ffa1355e16a5b347e50e8f0971b8622224ec55ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 24ebf366449bbec990809a71c4cc6267c955d798
https://github.com/Perl/perl5/commit/24ebf366449bbec990809a71c4cc6267c955d798
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: a27826b7b7ea250ee2c2dd141b4e02c15ad8acc4
https://github.com/Perl/perl5/commit/a27826b7b7ea250ee2c2dd141b4e02c15ad8acc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: e99e21020108b1896cd78ce88c926e6fbb3d6730
https://github.com/Perl/perl5/commit/e99e21020108b1896cd78ce88c926e6fbb3d6730
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 53471189ad5b575e118d854c31e08498661ff558
https://github.com/Perl/perl5/commit/53471189ad5b575e118d854c31e08498661ff558
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 4bc756ce3ef29b8124b58030634fd8c06b549990
https://github.com/Perl/perl5/commit/4bc756ce3ef29b8124b58030634fd8c06b549990
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 3140cf0f777de2d664407895cb2a86c895cd98e4
https://github.com/Perl/perl5/commit/3140cf0f777de2d664407895cb2a86c895cd98e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 79dfa43f9e0a6bc2aae02a56c32b51e0299446b1
https://github.com/Perl/perl5/commit/79dfa43f9e0a6bc2aae02a56c32b51e0299446b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: f554a78a4db14278041f01ab7a19d97db5feef43
https://github.com/Perl/perl5/commit/f554a78a4db14278041f01ab7a19d97db5feef43
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 0d464884d3af40a378156f1e7993f7e16575cfcb
https://github.com/Perl/perl5/commit/0d464884d3af40a378156f1e7993f7e16575cfcb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 8abd5664dec43c6802883d7cc9b5f2bb6be8e777
https://github.com/Perl/perl5/commit/8abd5664dec43c6802883d7cc9b5f2bb6be8e777
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: be0fde082ce3e2ce8312057e1424cc6be68ff455
https://github.com/Perl/perl5/commit/be0fde082ce3e2ce8312057e1424cc6be68ff455
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 6a54a8908759f1b920d9e1860e03be5769b5e0aa
https://github.com/Perl/perl5/commit/6a54a8908759f1b920d9e1860e03be5769b5e0aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 418f5deed578dc2f9f065458e956eda451496ee5
https://github.com/Perl/perl5/commit/418f5deed578dc2f9f065458e956eda451496ee5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: b5e4bf07937f698d337c63623bcf65ccedeba865
https://github.com/Perl/perl5/commit/b5e4bf07937f698d337c63623bcf65ccedeba865
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: f0a859e001a24f6d9b340c939c53e9dc3e0eb9fd
https://github.com/Perl/perl5/commit/f0a859e001a24f6d9b340c939c53e9dc3e0eb9fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 1133b1373873475a501d301349a381cc0298a22f
https://github.com/Perl/perl5/commit/1133b1373873475a501d301349a381cc0298a22f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 9c057b1cb56554d60965b4d4662428250e207e3f
https://github.com/Perl/perl5/commit/9c057b1cb56554d60965b4d4662428250e207e3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 9289438f3d6b4a8a8eae679c83e91186741b921d
https://github.com/Perl/perl5/commit/9289438f3d6b4a8a8eae679c83e91186741b921d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 994c1b8666e6ec6c9df56e8097b8048ff0d99437
https://github.com/Perl/perl5/commit/994c1b8666e6ec6c9df56e8097b8048ff0d99437
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 20f8074690c0f3677b6682d9a724bf55dc1c396f
https://github.com/Perl/perl5/commit/20f8074690c0f3677b6682d9a724bf55dc1c396f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: dace571940453fed92a7a610e9d226b4f16065fa
https://github.com/Perl/perl5/commit/dace571940453fed92a7a610e9d226b4f16065fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: b4be838d71e7f84fb8c2abe7d6d4d87c1ab5cad5
https://github.com/Perl/perl5/commit/b4be838d71e7f84fb8c2abe7d6d4d87c1ab5cad5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 0c03b8a1851f3ec3883867f004aaf22dbab5a4f0
https://github.com/Perl/perl5/commit/0c03b8a1851f3ec3883867f004aaf22dbab5a4f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: e32a6bbaa2474386b0d45534c79a925e83517f50
https://github.com/Perl/perl5/commit/e32a6bbaa2474386b0d45534c79a925e83517f50
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: edec2a2aa5e3642fafe085e1dabd3e545a11ec55
https://github.com/Perl/perl5/commit/edec2a2aa5e3642fafe085e1dabd3e545a11ec55
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: d9808aec5a0ba962440385ccfe283751c88bdd9a
https://github.com/Perl/perl5/commit/d9808aec5a0ba962440385ccfe283751c88bdd9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: cb96005c0018f422f0d6450dfbf0588caad28a90
https://github.com/Perl/perl5/commit/cb96005c0018f422f0d6450dfbf0588caad28a90
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 422a5b9b0ac78da65c548ef00a47996c0255ca4c
https://github.com/Perl/perl5/commit/422a5b9b0ac78da65c548ef00a47996c0255ca4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: bb42c6862e5bb36f6b3ce76ffc6786282f4718c0
https://github.com/Perl/perl5/commit/bb42c6862e5bb36f6b3ce76ffc6786282f4718c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: e74a8e07d10cb1d19cee6219d92e8fba71f31249
https://github.com/Perl/perl5/commit/e74a8e07d10cb1d19cee6219d92e8fba71f31249
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: a968cda4d423034567b17d1c35cb3fc632acf79f
https://github.com/Perl/perl5/commit/a968cda4d423034567b17d1c35cb3fc632acf79f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 82502a31eb75a80afedacdfc606c8488d2eca733
https://github.com/Perl/perl5/commit/82502a31eb75a80afedacdfc606c8488d2eca733
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 80d8c3412133b2dc6380dca7e5f6688486bbcb11
https://github.com/Perl/perl5/commit/80d8c3412133b2dc6380dca7e5f6688486bbcb11
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: fad2142cdbac31b5c26b114b3b3bb30677a3c8f6
https://github.com/Perl/perl5/commit/fad2142cdbac31b5c26b114b3b3bb30677a3c8f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 48ef0461413ddcf58ad5d8ce0948ae023061d210
https://github.com/Perl/perl5/commit/48ef0461413ddcf58ad5d8ce0948ae023061d210
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 7f1a69d52e9f697efc417ba60a67ae44de989032
https://github.com/Perl/perl5/commit/7f1a69d52e9f697efc417ba60a67ae44de989032
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: e3e556e5d8418e34efa1be4276f1f6038ebaa08a
https://github.com/Perl/perl5/commit/e3e556e5d8418e34efa1be4276f1f6038ebaa08a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: ccc52ff6b835154df55319de3a9b4a5328640d85
https://github.com/Perl/perl5/commit/ccc52ff6b835154df55319de3a9b4a5328640d85
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 9ad7276aaebba72fffc768994686e736f22f8178
https://github.com/Perl/perl5/commit/9ad7276aaebba72fffc768994686e736f22f8178
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 36add30b7c12140f8c1f1c7215dea09ce3542686
https://github.com/Perl/perl5/commit/36add30b7c12140f8c1f1c7215dea09ce3542686
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: ac0cc447e22da44d4bc5d8e68ee83d5fbf1b7d82
https://github.com/Perl/perl5/commit/ac0cc447e22da44d4bc5d8e68ee83d5fbf1b7d82
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 37d7b8fc9caa72fe1882c64effdfc55e299d54cf
https://github.com/Perl/perl5/commit/37d7b8fc9caa72fe1882c64effdfc55e299d54cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 1f5412ef6e01217066442e63d1f93950981665ff
https://github.com/Perl/perl5/commit/1f5412ef6e01217066442e63d1f93950981665ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 2d7f4ff4198e7f23e5e3391335588e285fad65c1
https://github.com/Perl/perl5/commit/2d7f4ff4198e7f23e5e3391335588e285fad65c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 96120526c612b2e1b370b9962a58b9424841e4af
https://github.com/Perl/perl5/commit/96120526c612b2e1b370b9962a58b9424841e4af
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 7b6b30576d3cea8c395cce9c23360049447ebf2f
https://github.com/Perl/perl5/commit/7b6b30576d3cea8c395cce9c23360049447ebf2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: aeafef04fbd7dc938a17ac728bf06514856c4cd8
https://github.com/Perl/perl5/commit/aeafef04fbd7dc938a17ac728bf06514856c4cd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: bbd26da50ccf563db0681c7b77702c52c85e5253
https://github.com/Perl/perl5/commit/bbd26da50ccf563db0681c7b77702c52c85e5253
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 8d8dac379e167184ddca8e46d47f47c01422f183
https://github.com/Perl/perl5/commit/8d8dac379e167184ddca8e46d47f47c01422f183
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 9fb900328365366a6544b6dd8d0e4598ce178c46
https://github.com/Perl/perl5/commit/9fb900328365366a6544b6dd8d0e4598ce178c46
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 427b1d527e6c76985e8809f0de411742e68f89c9
https://github.com/Perl/perl5/commit/427b1d527e6c76985e8809f0de411742e68f89c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 58f4b450828345ef07835226e8ee77f04e06c114
https://github.com/Perl/perl5/commit/58f4b450828345ef07835226e8ee77f04e06c114
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 718a73b55d282f7eacae0d131c0f39cb086f65b9
https://github.com/Perl/perl5/commit/718a73b55d282f7eacae0d131c0f39cb086f65b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 1c4ad162e055ec210dfbc30ef4abc0d74f0a8fa6
https://github.com/Perl/perl5/commit/1c4ad162e055ec210dfbc30ef4abc0d74f0a8fa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 150ae33079e2270cfcc412cccf1cd346ce83f1ee
https://github.com/Perl/perl5/commit/150ae33079e2270cfcc412cccf1cd346ce83f1ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 4a99aeb864663140e5d14deebd7caf4bb6acb51e
https://github.com/Perl/perl5/commit/4a99aeb864663140e5d14deebd7caf4bb6acb51e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 42582383e4519d858e2a63339cdac20cc23aaa78
https://github.com/Perl/perl5/commit/42582383e4519d858e2a63339cdac20cc23aaa78
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 07b0d0da471a2b9a3d8ddc326a6d2cde5eb5dc99
https://github.com/Perl/perl5/commit/07b0d0da471a2b9a3d8ddc326a6d2cde5eb5dc99
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 722df0843a403fd0569b8ad2952f022b6bb7c841
https://github.com/Perl/perl5/commit/722df0843a403fd0569b8ad2952f022b6bb7c841
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 89e7534b0d2deaf145b6d4b39dd18ebdcd312021
https://github.com/Perl/perl5/commit/89e7534b0d2deaf145b6d4b39dd18ebdcd312021
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: ec1dd7069743aa905af0275440c854298f34e662
https://github.com/Perl/perl5/commit/ec1dd7069743aa905af0275440c854298f34e662
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: bea131605e80ef8e8dc7a9860e502c438a8f0cc0
https://github.com/Perl/perl5/commit/bea131605e80ef8e8dc7a9860e502c438a8f0cc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: b1b3cdb654b8cfeee95d7eddb4c65434761a580f
https://github.com/Perl/perl5/commit/b1b3cdb654b8cfeee95d7eddb4c65434761a580f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: f31ec629175198e4fb628aa31a6f56ed90f690a7
https://github.com/Perl/perl5/commit/f31ec629175198e4fb628aa31a6f56ed90f690a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 9b9d78c30357734993ce0110b49845aaa2ac0826
https://github.com/Perl/perl5/commit/9b9d78c30357734993ce0110b49845aaa2ac0826
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 4e7efc4686bd78b26893e270b16ae637a703ff71
https://github.com/Perl/perl5/commit/4e7efc4686bd78b26893e270b16ae637a703ff71
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 743f5805773896db14333431129f40da4957a338
https://github.com/Perl/perl5/commit/743f5805773896db14333431129f40da4957a338
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 64bcd6c4862a0e1e8501afc2c578fbf9594d9c2f
https://github.com/Perl/perl5/commit/64bcd6c4862a0e1e8501afc2c578fbf9594d9c2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 9fafd0dbdea14daa408898de5beddea62ef021f1
https://github.com/Perl/perl5/commit/9fafd0dbdea14daa408898de5beddea62ef021f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 18f042a8ba63bbc0e4f1ff638f77d76b6f33503f
https://github.com/Perl/perl5/commit/18f042a8ba63bbc0e4f1ff638f77d76b6f33503f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 4bda6971bac912c89500bb0be9a965d42587e510
https://github.com/Perl/perl5/commit/4bda6971bac912c89500bb0be9a965d42587e510
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 280993eb6e800122fbc88520e284966fbb5f3cbd
https://github.com/Perl/perl5/commit/280993eb6e800122fbc88520e284966fbb5f3cbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: ad442362343822c3a16d1498169b058e57cdd48d
https://github.com/Perl/perl5/commit/ad442362343822c3a16d1498169b058e57cdd48d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 07e0afe52ae05a24d317e12cf693f62f5378cf20
https://github.com/Perl/perl5/commit/07e0afe52ae05a24d317e12cf693f62f5378cf20
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 75e1eed41bad3390b1499f8f9d3169dcf8e7ceec
https://github.com/Perl/perl5/commit/75e1eed41bad3390b1499f8f9d3169dcf8e7ceec
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 8196c39efb2ce912e7f330f7b4dd25f9e07fa2fa
https://github.com/Perl/perl5/commit/8196c39efb2ce912e7f330f7b4dd25f9e07fa2fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 94f48a606e814be52fd170595186f471a730e547
https://github.com/Perl/perl5/commit/94f48a606e814be52fd170595186f471a730e547
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: ed3b14ddf384567c48c4e199ea3e66772cba3146
https://github.com/Perl/perl5/commit/ed3b14ddf384567c48c4e199ea3e66772cba3146
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: bcd2ca6db627ef3985c3cf7ec876d5732eac739b
https://github.com/Perl/perl5/commit/bcd2ca6db627ef3985c3cf7ec876d5732eac739b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 24f6d8cad94fc319eeb88d411f493a6532337f68
https://github.com/Perl/perl5/commit/24f6d8cad94fc319eeb88d411f493a6532337f68
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: d1653108db00be209442ca674208e6d29e440b0e
https://github.com/Perl/perl5/commit/d1653108db00be209442ca674208e6d29e440b0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: e008a5eef5f7af03c7ef55ec4efbaa4f3ecc6c19
https://github.com/Perl/perl5/commit/e008a5eef5f7af03c7ef55ec4efbaa4f3ecc6c19
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 385705dff49aa8b807876aa365bceafbad38949a
https://github.com/Perl/perl5/commit/385705dff49aa8b807876aa365bceafbad38949a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: dac7511f1c6227e55e0b64060c2a821b6f64d38b
https://github.com/Perl/perl5/commit/dac7511f1c6227e55e0b64060c2a821b6f64d38b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: d535347da163c9b6ce214cc10adddb85b7a3edb7
https://github.com/Perl/perl5/commit/d535347da163c9b6ce214cc10adddb85b7a3edb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 37f56e3621a0f959fcbc01827856278e5128220e
https://github.com/Perl/perl5/commit/37f56e3621a0f959fcbc01827856278e5128220e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 8eedd4b456a1760fd62f1af20e77ee56a25e101e
https://github.com/Perl/perl5/commit/8eedd4b456a1760fd62f1af20e77ee56a25e101e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: fef555dbee322e942eebb26f4cf353f3bcc85f2f
https://github.com/Perl/perl5/commit/fef555dbee322e942eebb26f4cf353f3bcc85f2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: cda27bc2253b5c32b8a01b4d82da4e0335804e89
https://github.com/Perl/perl5/commit/cda27bc2253b5c32b8a01b4d82da4e0335804e89
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: e124eecd270984495dfd2f6222681278abb51fe3
https://github.com/Perl/perl5/commit/e124eecd270984495dfd2f6222681278abb51fe3
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 44f7714d2623b886d145b7d0f0b5d6a194d6f847
https://github.com/Perl/perl5/commit/44f7714d2623b886d145b7d0f0b5d6a194d6f847
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 761d645da8d3bbea826833828db7b28c5630365f
https://github.com/Perl/perl5/commit/761d645da8d3bbea826833828db7b28c5630365f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: d583312ff558410cdb9d7cf5dd70095b9bec8b98
https://github.com/Perl/perl5/commit/d583312ff558410cdb9d7cf5dd70095b9bec8b98
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: ca82fade442237a2964664566987b70810b80f2f
https://github.com/Perl/perl5/commit/ca82fade442237a2964664566987b70810b80f2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: df087f8d023ee0dd9806a3af63d56ffe1ffcb7e3
https://github.com/Perl/perl5/commit/df087f8d023ee0dd9806a3af63d56ffe1ffcb7e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 0ce35079449d92ae9db5120d88e7bd4f5acabaf4
https://github.com/Perl/perl5/commit/0ce35079449d92ae9db5120d88e7bd4f5acabaf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: ac07d906a1351a9b64fd211196a6304f32a58b24
https://github.com/Perl/perl5/commit/ac07d906a1351a9b64fd211196a6304f32a58b24
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 15925069a0072e86367cc2c1cde9c27e5e58d2a6
https://github.com/Perl/perl5/commit/15925069a0072e86367cc2c1cde9c27e5e58d2a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 2ce77b09f636bbcf86d291a617ebe08a2725b6d4
https://github.com/Perl/perl5/commit/2ce77b09f636bbcf86d291a617ebe08a2725b6d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: a2464d2191c5263eaeb978a87b7ae47a6cc6f85d
https://github.com/Perl/perl5/commit/a2464d2191c5263eaeb978a87b7ae47a6cc6f85d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 740257e955e0e6017c76a1287b05543ba34811a9
https://github.com/Perl/perl5/commit/740257e955e0e6017c76a1287b05543ba34811a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 0358c216757df9c8a2179cd96617206bf37eb842
https://github.com/Perl/perl5/commit/0358c216757df9c8a2179cd96617206bf37eb842
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: ec836c4018fa1afec1f1c68604ffa1a0c8ed1b58
https://github.com/Perl/perl5/commit/ec836c4018fa1afec1f1c68604ffa1a0c8ed1b58
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: ca6da1ebe18d277374045fb8c5cea565a9c98190
https://github.com/Perl/perl5/commit/ca6da1ebe18d277374045fb8c5cea565a9c98190
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 1cb7a21af0141145da6bb08ea7cbf6b38d8de674
https://github.com/Perl/perl5/commit/1cb7a21af0141145da6bb08ea7cbf6b38d8de674
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: c820da0d8100c87c2a68a313dfb5c4aa416de645
https://github.com/Perl/perl5/commit/c820da0d8100c87c2a68a313dfb5c4aa416de645
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 79329d94f6ae4eacc8ff8e173a854cf7f3e05055
https://github.com/Perl/perl5/commit/79329d94f6ae4eacc8ff8e173a854cf7f3e05055
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 23253a18d4d08b2587881a8cec65b2c92a8bed54
https://github.com/Perl/perl5/commit/23253a18d4d08b2587881a8cec65b2c92a8bed54
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: a4ee3de1e6d46953fca9ad3ac70c72522bc19504
https://github.com/Perl/perl5/commit/a4ee3de1e6d46953fca9ad3ac70c72522bc19504
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: dc01bf9cc62d7c4361572437e1f61bedc14d142c
https://github.com/Perl/perl5/commit/dc01bf9cc62d7c4361572437e1f61bedc14d142c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 9435674d28042b6e5f66d3935eeb17bec7cdb319
https://github.com/Perl/perl5/commit/9435674d28042b6e5f66d3935eeb17bec7cdb319
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 58c2113ad3ff54af1c2a36396af24efa7749d113
https://github.com/Perl/perl5/commit/58c2113ad3ff54af1c2a36396af24efa7749d113
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 66bd3e97ed9e6743aef06b604195391cc2c3f0f4
https://github.com/Perl/perl5/commit/66bd3e97ed9e6743aef06b604195391cc2c3f0f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 8ff5ad6813f7b5f06b756e739fbcbd9d16116d39
https://github.com/Perl/perl5/commit/8ff5ad6813f7b5f06b756e739fbcbd9d16116d39
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 4f579cbfba8fc63170bc0a2ecf71ffbc0d11b24f
https://github.com/Perl/perl5/commit/4f579cbfba8fc63170bc0a2ecf71ffbc0d11b24f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: b043756841bea4ab7b31eea8edc943714812733d
https://github.com/Perl/perl5/commit/b043756841bea4ab7b31eea8edc943714812733d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 5db188f3cb809d287b04feb72df7d3c318f293d3
https://github.com/Perl/perl5/commit/5db188f3cb809d287b04feb72df7d3c318f293d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: a6fd0f58bd0c007ece8ffaf823ecd24845863206
https://github.com/Perl/perl5/commit/a6fd0f58bd0c007ece8ffaf823ecd24845863206
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: ffd74e3e2c196f59d8201e1eb83e230c0fbda050
https://github.com/Perl/perl5/commit/ffd74e3e2c196f59d8201e1eb83e230c0fbda050
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: a1ac181053c7415a0c749c63043281033fa9fad4
https://github.com/Perl/perl5/commit/a1ac181053c7415a0c749c63043281033fa9fad4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 330906cba152b0a3ef064bf7b951a6f29f31f236
https://github.com/Perl/perl5/commit/330906cba152b0a3ef064bf7b951a6f29f31f236
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: b9bbb4a46a50fdef06fce38928e8faeefafec36d
https://github.com/Perl/perl5/commit/b9bbb4a46a50fdef06fce38928e8faeefafec36d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 5b498a39c45d810e039d3914b703b56c900a71f7
https://github.com/Perl/perl5/commit/5b498a39c45d810e039d3914b703b56c900a71f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: de98afbfaeb7166a0fd71755452ea2db10dcf615
https://github.com/Perl/perl5/commit/de98afbfaeb7166a0fd71755452ea2db10dcf615
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 844c8df944e376d9dfc4e515e4272760f7e772d0
https://github.com/Perl/perl5/commit/844c8df944e376d9dfc4e515e4272760f7e772d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: a9937adea35d20beba6dc7493e0f6c96bc7b3bbf
https://github.com/Perl/perl5/commit/a9937adea35d20beba6dc7493e0f6c96bc7b3bbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: e1f729f40df93d7cf0f4258792dc68e97a96c453
https://github.com/Perl/perl5/commit/e1f729f40df93d7cf0f4258792dc68e97a96c453
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 8811946ec5341fa927eb51bc0fd8ebdf09bb9c21
https://github.com/Perl/perl5/commit/8811946ec5341fa927eb51bc0fd8ebdf09bb9c21
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 93eb4ebb6869b6557a4474195b3ee741c2784f69
https://github.com/Perl/perl5/commit/93eb4ebb6869b6557a4474195b3ee741c2784f69
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: efe7e1781940ec9f84ee85d9b000b99f92597214
https://github.com/Perl/perl5/commit/efe7e1781940ec9f84ee85d9b000b99f92597214
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: ab9735acd94c95296b563d2dfcc1dc62eb14b9fb
https://github.com/Perl/perl5/commit/ab9735acd94c95296b563d2dfcc1dc62eb14b9fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: a9004390f9120dc6c16846bb69fa02de8a44b5ca
https://github.com/Perl/perl5/commit/a9004390f9120dc6c16846bb69fa02de8a44b5ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: dd8a37d25853e316a46782b496ba632a50611ec9
https://github.com/Perl/perl5/commit/dd8a37d25853e316a46782b496ba632a50611ec9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b76eb0721c2b1b676e25d38beb11cd604511800a
https://github.com/Perl/perl5/commit/b76eb0721c2b1b676e25d38beb11cd604511800a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 90d05b93bacc23fb9a47775787cebb340c07a9f2
https://github.com/Perl/perl5/commit/90d05b93bacc23fb9a47775787cebb340c07a9f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 53f1eaa13a1d937208dda7bf1c5744e28afa92c0
https://github.com/Perl/perl5/commit/53f1eaa13a1d937208dda7bf1c5744e28afa92c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: f19f99ec5202c3b30f64fb0aceb26809db492ddf
https://github.com/Perl/perl5/commit/f19f99ec5202c3b30f64fb0aceb26809db492ddf
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: bb03b277a74d030f5d2c53ada7dc45745b05ec6e
https://github.com/Perl/perl5/commit/bb03b277a74d030f5d2c53ada7dc45745b05ec6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: e1fe41524b40dbd82d537e769f38fdd3e93e29f7
https://github.com/Perl/perl5/commit/e1fe41524b40dbd82d537e769f38fdd3e93e29f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: d577e5219998e661ed555bcf19cbca9794b0424e
https://github.com/Perl/perl5/commit/d577e5219998e661ed555bcf19cbca9794b0424e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: db9ffac1adce3ab0d992e831880986e63d01fb87
https://github.com/Perl/perl5/commit/db9ffac1adce3ab0d992e831880986e63d01fb87
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 3d3f6bd0eb8991175c94b900e082eebb08c72c0c
https://github.com/Perl/perl5/commit/3d3f6bd0eb8991175c94b900e082eebb08c72c0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 663485796d95e27fb2d542fcc5176d1b4cc6986c
https://github.com/Perl/perl5/commit/663485796d95e27fb2d542fcc5176d1b4cc6986c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 4cfe86ab3299fa97b2f5789f7f2ed5578aa6af68
https://github.com/Perl/perl5/commit/4cfe86ab3299fa97b2f5789f7f2ed5578aa6af68
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 661914c5ec3a6f8ce78abfbb0aa16aceddb2bfca
https://github.com/Perl/perl5/commit/661914c5ec3a6f8ce78abfbb0aa16aceddb2bfca
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: d82e067ca94892b69e78d2610d8bbea412ca8e7b
https://github.com/Perl/perl5/commit/d82e067ca94892b69e78d2610d8bbea412ca8e7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 9e75665542e8875ebaa84142a77160be32801d9a
https://github.com/Perl/perl5/commit/9e75665542e8875ebaa84142a77160be32801d9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 472464f8871eabdecdc77e6508c0ad20127e121a
https://github.com/Perl/perl5/commit/472464f8871eabdecdc77e6508c0ad20127e121a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: da7dec9baf9fb82d17d68e9968b8703539941d1c
https://github.com/Perl/perl5/commit/da7dec9baf9fb82d17d68e9968b8703539941d1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 1513d0b34c8bb018f7670394d5bf0a3f5b8ae8aa
https://github.com/Perl/perl5/commit/1513d0b34c8bb018f7670394d5bf0a3f5b8ae8aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: e82663ac8688adad89709db0aabf3143358a8a4a
https://github.com/Perl/perl5/commit/e82663ac8688adad89709db0aabf3143358a8a4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 7fa1bd837388a1f0ab326068a4991befb2fa605c
https://github.com/Perl/perl5/commit/7fa1bd837388a1f0ab326068a4991befb2fa605c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 24729a970f938fe0d6ce4f8d4248b2cd1b885235
https://github.com/Perl/perl5/commit/24729a970f938fe0d6ce4f8d4248b2cd1b885235
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 65d2cc11ebf0da23da9b5987dd933d0c4f9369ab
https://github.com/Perl/perl5/commit/65d2cc11ebf0da23da9b5987dd933d0c4f9369ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 9178ab81a977e837d9a8b8fd6f30753379fa6668
https://github.com/Perl/perl5/commit/9178ab81a977e837d9a8b8fd6f30753379fa6668
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 5209e71926a564378f505d902896a901ac8d5efb
https://github.com/Perl/perl5/commit/5209e71926a564378f505d902896a901ac8d5efb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 522b296020ac1469cc131278303db917a135e55f
https://github.com/Perl/perl5/commit/522b296020ac1469cc131278303db917a135e55f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: f41933d01a4c847294e5d2487d0e1f3c300d31bb
https://github.com/Perl/perl5/commit/f41933d01a4c847294e5d2487d0e1f3c300d31bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 9622a65f80fc40957fbb09e54045a30228a48bc9
https://github.com/Perl/perl5/commit/9622a65f80fc40957fbb09e54045a30228a48bc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 09b2d612370adedaec9e63bfe87eafb1c854ce2b
https://github.com/Perl/perl5/commit/09b2d612370adedaec9e63bfe87eafb1c854ce2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: b8f5204b8ded088bfbba865ff98202e96d4dc928
https://github.com/Perl/perl5/commit/b8f5204b8ded088bfbba865ff98202e96d4dc928
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: cb851746c3b34021094978b28aacc29cfe482be5
https://github.com/Perl/perl5/commit/cb851746c3b34021094978b28aacc29cfe482be5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 46a16c003f9202e9a3efaec8f3c3c3b70ec41fef
https://github.com/Perl/perl5/commit/46a16c003f9202e9a3efaec8f3c3c3b70ec41fef
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 833f51cd0e36b0647cb9be75eea6e0c2455bee11
https://github.com/Perl/perl5/commit/833f51cd0e36b0647cb9be75eea6e0c2455bee11
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 2b446e19d5d651811c03c9bf81afabfbd1474a04
https://github.com/Perl/perl5/commit/2b446e19d5d651811c03c9bf81afabfbd1474a04
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: c4e2bce09cb189836a1f5cb7ca3f301133a46036
https://github.com/Perl/perl5/commit/c4e2bce09cb189836a1f5cb7ca3f301133a46036
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 86f024ba021c07c36befc81fbbcf23773e15cc47
https://github.com/Perl/perl5/commit/86f024ba021c07c36befc81fbbcf23773e15cc47
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 7de8ead2dfb6483edfcbd3b20be2537594621e5d
https://github.com/Perl/perl5/commit/7de8ead2dfb6483edfcbd3b20be2537594621e5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 91a082ee967a057b1a7dc9063c49896e7e26a9d6
https://github.com/Perl/perl5/commit/91a082ee967a057b1a7dc9063c49896e7e26a9d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: dd6b0d7da7a587d213f6c55f62015fbfb37096fa
https://github.com/Perl/perl5/commit/dd6b0d7da7a587d213f6c55f62015fbfb37096fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 0267387f412bc667d4aa001b3a62ca9c94e83a00
https://github.com/Perl/perl5/commit/0267387f412bc667d4aa001b3a62ca9c94e83a00
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 40c97da4b1e3803d221d8aadcecede321dea45ef
https://github.com/Perl/perl5/commit/40c97da4b1e3803d221d8aadcecede321dea45ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 816fd5ff14416b0a2aaaaa63657a8f9892110810
https://github.com/Perl/perl5/commit/816fd5ff14416b0a2aaaaa63657a8f9892110810
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: c1b589e498151df7754fa3b36d02c0af6dfa92d7
https://github.com/Perl/perl5/commit/c1b589e498151df7754fa3b36d02c0af6dfa92d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 00f87dcaeb1b1a9063fc5fac00e217e6bba6f18d
https://github.com/Perl/perl5/commit/00f87dcaeb1b1a9063fc5fac00e217e6bba6f18d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 2732c2e4aaab85c06248d7a98294bb378bd19a65
https://github.com/Perl/perl5/commit/2732c2e4aaab85c06248d7a98294bb378bd19a65
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 9eb0d3e8704a94df6f4bb97350ecb19d6f045e47
https://github.com/Perl/perl5/commit/9eb0d3e8704a94df6f4bb97350ecb19d6f045e47
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 979e030bf59bb289cae4b35f69a8a9939380dfa2
https://github.com/Perl/perl5/commit/979e030bf59bb289cae4b35f69a8a9939380dfa2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 3722b7648047621ad66cc6cb7b71e68258c4c83f
https://github.com/Perl/perl5/commit/3722b7648047621ad66cc6cb7b71e68258c4c83f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 7dfbbf29e99fa9655da996271bce0dcefb5d172e
https://github.com/Perl/perl5/commit/7dfbbf29e99fa9655da996271bce0dcefb5d172e
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: ce5f98657847bd90a0c1a6c2592a98bbc10508c1
https://github.com/Perl/perl5/commit/ce5f98657847bd90a0c1a6c2592a98bbc10508c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6c21a99e88049bfbb296f75434231080809af513
https://github.com/Perl/perl5/commit/6c21a99e88049bfbb296f75434231080809af513
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 64fa7c1bd3cb7f9a224e5da87a87f28564bf3c32
https://github.com/Perl/perl5/commit/64fa7c1bd3cb7f9a224e5da87a87f28564bf3c32
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b47a8d8650e65f6524e021b4f5d4070888054d1d
https://github.com/Perl/perl5/commit/b47a8d8650e65f6524e021b4f5d4070888054d1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 3a0973ab8ac0447da9ab6be6e5fe0552263ac79c
https://github.com/Perl/perl5/commit/3a0973ab8ac0447da9ab6be6e5fe0552263ac79c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 3bd22ebb65e3e1b96cde46ac042b0e3a48368bad
https://github.com/Perl/perl5/commit/3bd22ebb65e3e1b96cde46ac042b0e3a48368bad
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 801e4ebf66cbdd6f7228d921c6c5b2a205d651c3
https://github.com/Perl/perl5/commit/801e4ebf66cbdd6f7228d921c6c5b2a205d651c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: e4b39f577182f34d2f5fb0ad95da80d1f909d258
https://github.com/Perl/perl5/commit/e4b39f577182f34d2f5fb0ad95da80d1f909d258
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: b7c545a10ec04494b461851b1c103ca9d3bee8f2
https://github.com/Perl/perl5/commit/b7c545a10ec04494b461851b1c103ca9d3bee8f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 2e048d368574cb2ddd878f3d134bba1355021501
https://github.com/Perl/perl5/commit/2e048d368574cb2ddd878f3d134bba1355021501
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: e1f88d0ccf97fa119a0f3af64f1e341fc3ac80da
https://github.com/Perl/perl5/commit/e1f88d0ccf97fa119a0f3af64f1e341fc3ac80da
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 285521588cb9ff54e7e6ec5ea8ec36461ec1d779
https://github.com/Perl/perl5/commit/285521588cb9ff54e7e6ec5ea8ec36461ec1d779
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e8bfe546f9be5d9fbc2d123ae8cb493e674f61b6
https://github.com/Perl/perl5/commit/e8bfe546f9be5d9fbc2d123ae8cb493e674f61b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 5998cde93c68df235d17dc0ddaf79aa131d8d72f
https://github.com/Perl/perl5/commit/5998cde93c68df235d17dc0ddaf79aa131d8d72f
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 035b75e58ac4615704ae73e4d4da5c5ae4135d90
https://github.com/Perl/perl5/commit/035b75e58ac4615704ae73e4d4da5c5ae4135d90
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 07265522ff5f744115515e8782d57ad001dc28c4
https://github.com/Perl/perl5/commit/07265522ff5f744115515e8782d57ad001dc28c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 6385f9521261994b5215ff5d3f724f74e87fe982
https://github.com/Perl/perl5/commit/6385f9521261994b5215ff5d3f724f74e87fe982
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 413ad28cf0a27c3059984263fa548826466ea78c
https://github.com/Perl/perl5/commit/413ad28cf0a27c3059984263fa548826466ea78c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 186c82c1e3c9d4ca949ece6aef0bf24b319ce228
https://github.com/Perl/perl5/commit/186c82c1e3c9d4ca949ece6aef0bf24b319ce228
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: ce7e6f70ec7ebf91c32023411ab2c009e00cfbce
https://github.com/Perl/perl5/commit/ce7e6f70ec7ebf91c32023411ab2c009e00cfbce
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 77695385b8785a9148b4251f12d01663b51b040c
https://github.com/Perl/perl5/commit/77695385b8785a9148b4251f12d01663b51b040c
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 5f3830f8a77c04319523ce71a31bee1e6a493b26
https://github.com/Perl/perl5/commit/5f3830f8a77c04319523ce71a31bee1e6a493b26
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: d5ddea8bb4f02377593bfc6fe9d4c03ac1956f79
https://github.com/Perl/perl5/commit/d5ddea8bb4f02377593bfc6fe9d4c03ac1956f79
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 86abb6fda008247addf90c29090ad91e99988afe
https://github.com/Perl/perl5/commit/86abb6fda008247addf90c29090ad91e99988afe
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 5c8ce05469f66241c8682d33734d00cc7ae39851
https://github.com/Perl/perl5/commit/5c8ce05469f66241c8682d33734d00cc7ae39851
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 464dc8e0c48ac23deed37b5105fc28969e841194
https://github.com/Perl/perl5/commit/464dc8e0c48ac23deed37b5105fc28969e841194
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 7b29999ecbab4e50cb720a96dccb6ccb8a7d0aa5
https://github.com/Perl/perl5/commit/7b29999ecbab4e50cb720a96dccb6ccb8a7d0aa5
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 32cd19abbbc3e120c16bb28c921c091be366d879
https://github.com/Perl/perl5/commit/32cd19abbbc3e120c16bb28c921c091be366d879
Author: Karl Williamson <[email protected]>
Date: 2021-04-08 (Thu, 08 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more23
Compare: https://github.com/Perl/perl5/compare/7212f87f9489...32cd19abbbc3
