Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 68a2a96b8a78b086fc5adeffc8eecb97f1cd48d5
https://github.com/Perl/perl5/commit/68a2a96b8a78b086fc5adeffc8eecb97f1cd48d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 52c50df66ed5187926b757cacbd5d32291c03211
https://github.com/Perl/perl5/commit/52c50df66ed5187926b757cacbd5d32291c03211
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: c9935a132966832cdba6941677c5d580a8677d3e
https://github.com/Perl/perl5/commit/c9935a132966832cdba6941677c5d580a8677d3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 752d1fae4f0e524b2a41fc3f870ae3e09c6beffb
https://github.com/Perl/perl5/commit/752d1fae4f0e524b2a41fc3f870ae3e09c6beffb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: d303e63baed038e22d614dcc5e9e699e67ee8ca2
https://github.com/Perl/perl5/commit/d303e63baed038e22d614dcc5e9e699e67ee8ca2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: bfa7585de7e97b86ad5d44350dcd4c351072d807
https://github.com/Perl/perl5/commit/bfa7585de7e97b86ad5d44350dcd4c351072d807
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 90f25f8257718bbb4dbda2b58b116ef9cafae09d
https://github.com/Perl/perl5/commit/90f25f8257718bbb4dbda2b58b116ef9cafae09d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: a3791e234da8dd8b4f70ff1c0a71de515eaabdf1
https://github.com/Perl/perl5/commit/a3791e234da8dd8b4f70ff1c0a71de515eaabdf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: e3c8cddb03d5fcdad5ebf26689ec73ead68ec128
https://github.com/Perl/perl5/commit/e3c8cddb03d5fcdad5ebf26689ec73ead68ec128
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 44ced8c55abcf1ef9432bd904dd055c369cc341a
https://github.com/Perl/perl5/commit/44ced8c55abcf1ef9432bd904dd055c369cc341a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: ebbaa43fcbbd5173d2d7ea15a25d84220f666e23
https://github.com/Perl/perl5/commit/ebbaa43fcbbd5173d2d7ea15a25d84220f666e23
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 4f441acba177b74162fb007eb81a42f2e0995fc0
https://github.com/Perl/perl5/commit/4f441acba177b74162fb007eb81a42f2e0995fc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 11ba89da3fc2cc4de8a25fd51d0560acfc106fe9
https://github.com/Perl/perl5/commit/11ba89da3fc2cc4de8a25fd51d0560acfc106fe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: dc9fefe424ae8c5b2b1a696bf2e4ee96da4fe33d
https://github.com/Perl/perl5/commit/dc9fefe424ae8c5b2b1a696bf2e4ee96da4fe33d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: c5ecb09747c510365a3e4b080d9908b11244b09a
https://github.com/Perl/perl5/commit/c5ecb09747c510365a3e4b080d9908b11244b09a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: ef82aea4ebf5c5935148bc0bd4b825f90262ac97
https://github.com/Perl/perl5/commit/ef82aea4ebf5c5935148bc0bd4b825f90262ac97
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: d8d3058346e56417e9b1bf478a62542e5d68638d
https://github.com/Perl/perl5/commit/d8d3058346e56417e9b1bf478a62542e5d68638d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 95c000deb8e04915967140959303cb3af9289ef0
https://github.com/Perl/perl5/commit/95c000deb8e04915967140959303cb3af9289ef0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 00c9a7381621c955c88e9b557d77e796081bd4ea
https://github.com/Perl/perl5/commit/00c9a7381621c955c88e9b557d77e796081bd4ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: c7cea56628f10adc62f47055ef61874aa66bdafd
https://github.com/Perl/perl5/commit/c7cea56628f10adc62f47055ef61874aa66bdafd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: afb639425729426029b4d42987e42738a0467924
https://github.com/Perl/perl5/commit/afb639425729426029b4d42987e42738a0467924
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 860c4b088908378a609273997589dbb4680a1842
https://github.com/Perl/perl5/commit/860c4b088908378a609273997589dbb4680a1842
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: dc44a0f24c53ded7a81e55d7e5774dd886e21b0e
https://github.com/Perl/perl5/commit/dc44a0f24c53ded7a81e55d7e5774dd886e21b0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 6cd933142a04f20324bc1176470cb82625578a91
https://github.com/Perl/perl5/commit/6cd933142a04f20324bc1176470cb82625578a91
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: f676bb2c42ebe4ac1dcf811eb05126baf03bd9f6
https://github.com/Perl/perl5/commit/f676bb2c42ebe4ac1dcf811eb05126baf03bd9f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 90897458791dc72f5c41d787da0953af38791787
https://github.com/Perl/perl5/commit/90897458791dc72f5c41d787da0953af38791787
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 7f438abf51d55c62459948d0bdc2001decea4cac
https://github.com/Perl/perl5/commit/7f438abf51d55c62459948d0bdc2001decea4cac
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 157b17c0a0737fbd33f21779f13e059b5d9cbf59
https://github.com/Perl/perl5/commit/157b17c0a0737fbd33f21779f13e059b5d9cbf59
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: fd3104b051092e380f2b565a5ef8b428fe3d385e
https://github.com/Perl/perl5/commit/fd3104b051092e380f2b565a5ef8b428fe3d385e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: fda06cbfffc156b97dd7f2637c32d38d44244e65
https://github.com/Perl/perl5/commit/fda06cbfffc156b97dd7f2637c32d38d44244e65
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 41d66800a7ceca7a1df2c4989d0d328cd31f7c99
https://github.com/Perl/perl5/commit/41d66800a7ceca7a1df2c4989d0d328cd31f7c99
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 1aa8e9ccec9d80395aab0d77aec073cb243dba88
https://github.com/Perl/perl5/commit/1aa8e9ccec9d80395aab0d77aec073cb243dba88
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: a7b5c43977135dbb676dad261022c68b77038fc1
https://github.com/Perl/perl5/commit/a7b5c43977135dbb676dad261022c68b77038fc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: d255fab5789c7847ff4b2f32ba28ddcf48774178
https://github.com/Perl/perl5/commit/d255fab5789c7847ff4b2f32ba28ddcf48774178
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 47e477f0c8d6ebe4a379f5efa4a8ba641795e6b7
https://github.com/Perl/perl5/commit/47e477f0c8d6ebe4a379f5efa4a8ba641795e6b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: b3b4d5f5f85e23087c060516911e5ea4de6fe49f
https://github.com/Perl/perl5/commit/b3b4d5f5f85e23087c060516911e5ea4de6fe49f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 99ded68aa594b3dade6195ad99e097a4ddd5b5a0
https://github.com/Perl/perl5/commit/99ded68aa594b3dade6195ad99e097a4ddd5b5a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: e397691e27e74d939c5515dda34e70b37237e62b
https://github.com/Perl/perl5/commit/e397691e27e74d939c5515dda34e70b37237e62b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 62cf40bf51cd4c7e8d62653f2c25b0acb0b6a112
https://github.com/Perl/perl5/commit/62cf40bf51cd4c7e8d62653f2c25b0acb0b6a112
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 27dd0cd54ead7272315cc90e24c044ab202b12c1
https://github.com/Perl/perl5/commit/27dd0cd54ead7272315cc90e24c044ab202b12c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 49e64a6085942121b3bc3c11e5482776b6b94f33
https://github.com/Perl/perl5/commit/49e64a6085942121b3bc3c11e5482776b6b94f33
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: fb8de586f3587ffd33df04558d6c415cba0e593d
https://github.com/Perl/perl5/commit/fb8de586f3587ffd33df04558d6c415cba0e593d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 9cd373e8b1c086a4996298ca0951371a4b18f6b3
https://github.com/Perl/perl5/commit/9cd373e8b1c086a4996298ca0951371a4b18f6b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 5a675e4e676f3af90d3632484fec5f9d20506e34
https://github.com/Perl/perl5/commit/5a675e4e676f3af90d3632484fec5f9d20506e34
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 445cfc96f486a0a73138dd563fbed6bd11166f17
https://github.com/Perl/perl5/commit/445cfc96f486a0a73138dd563fbed6bd11166f17
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 8daa4b5d07eae1fcbc1448dd981e3f10ab2c54dd
https://github.com/Perl/perl5/commit/8daa4b5d07eae1fcbc1448dd981e3f10ab2c54dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: d0e06d46e9c017c6d7890712f3b4f5bc9c8530ba
https://github.com/Perl/perl5/commit/d0e06d46e9c017c6d7890712f3b4f5bc9c8530ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 91e0e4b68685df8ff5e5e2a9aaa416081dfbfd55
https://github.com/Perl/perl5/commit/91e0e4b68685df8ff5e5e2a9aaa416081dfbfd55
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: dcb21575cdbed0c55762154ef4e7d255008b6b4d
https://github.com/Perl/perl5/commit/dcb21575cdbed0c55762154ef4e7d255008b6b4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 4e9ed1938441b3d472e253825bd7d0c4f840ca77
https://github.com/Perl/perl5/commit/4e9ed1938441b3d472e253825bd7d0c4f840ca77
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: f711bb1ac3add8482c100afa9aeba1ff1dceb1fd
https://github.com/Perl/perl5/commit/f711bb1ac3add8482c100afa9aeba1ff1dceb1fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 0b023154d09f1e8c442e7889162bf82f61536498
https://github.com/Perl/perl5/commit/0b023154d09f1e8c442e7889162bf82f61536498
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: b74e47c0b0f73254320751e242088260036fe0b7
https://github.com/Perl/perl5/commit/b74e47c0b0f73254320751e242088260036fe0b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 511ab13eb0f47cf2b46b728b40a8f6ed258cd26d
https://github.com/Perl/perl5/commit/511ab13eb0f47cf2b46b728b40a8f6ed258cd26d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 6941766215ddf5b8ddc68d356ffb0cf097b34fb5
https://github.com/Perl/perl5/commit/6941766215ddf5b8ddc68d356ffb0cf097b34fb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: da29f139b2339730a2882e646f5e79420a5b57e9
https://github.com/Perl/perl5/commit/da29f139b2339730a2882e646f5e79420a5b57e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: db028239b7381dd18915aafadf2d355632141ad5
https://github.com/Perl/perl5/commit/db028239b7381dd18915aafadf2d355632141ad5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 4817a6a2104c5a5cff1a3536e585ec79b1826a6d
https://github.com/Perl/perl5/commit/4817a6a2104c5a5cff1a3536e585ec79b1826a6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: a3968244c12233ea8760b8c30af04e744efca0c9
https://github.com/Perl/perl5/commit/a3968244c12233ea8760b8c30af04e744efca0c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 06d67db6cbc5db7bb488e0f3b82adb20db1dc8ae
https://github.com/Perl/perl5/commit/06d67db6cbc5db7bb488e0f3b82adb20db1dc8ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 70a19f1e411f57830ac5401def9c57ca8b6d09b7
https://github.com/Perl/perl5/commit/70a19f1e411f57830ac5401def9c57ca8b6d09b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c67ba0996b99a990feb7a5bc740b6a030fdd9123
https://github.com/Perl/perl5/commit/c67ba0996b99a990feb7a5bc740b6a030fdd9123
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 6a564bdd66698964f852a7511d78a1625c2971b4
https://github.com/Perl/perl5/commit/6a564bdd66698964f852a7511d78a1625c2971b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 39dc2aaaa2913a260f22244015ee99057ab409cc
https://github.com/Perl/perl5/commit/39dc2aaaa2913a260f22244015ee99057ab409cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 9466acdd86a6c6e776f5f86ea29ace6a0be0e8ac
https://github.com/Perl/perl5/commit/9466acdd86a6c6e776f5f86ea29ace6a0be0e8ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d4eac3eacaf8b3d17e08d07de6f33510415fe9c9
https://github.com/Perl/perl5/commit/d4eac3eacaf8b3d17e08d07de6f33510415fe9c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: a5677fafb87cb0a810a9b8a91d9cf901e87998b5
https://github.com/Perl/perl5/commit/a5677fafb87cb0a810a9b8a91d9cf901e87998b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 7a9f78fc1b413efe126ddf689953256893ec4cb3
https://github.com/Perl/perl5/commit/7a9f78fc1b413efe126ddf689953256893ec4cb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 7edf80fb3d846f60bb65658ca82f60531f71e750
https://github.com/Perl/perl5/commit/7edf80fb3d846f60bb65658ca82f60531f71e750
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: ab04f6c711263c24887df0b0f2705b66bf9a22e2
https://github.com/Perl/perl5/commit/ab04f6c711263c24887df0b0f2705b66bf9a22e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 82478e5151b951f3f70e893a2816917848f2afc9
https://github.com/Perl/perl5/commit/82478e5151b951f3f70e893a2816917848f2afc9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 15ac0f5c1bb96a3123cae2acfd51b35f53fd2036
https://github.com/Perl/perl5/commit/15ac0f5c1bb96a3123cae2acfd51b35f53fd2036
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 822f461e25b5fb012a43cd0348c89b2fce54a44a
https://github.com/Perl/perl5/commit/822f461e25b5fb012a43cd0348c89b2fce54a44a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 43ae6574747dbbde7143ebcd9374e9d315aa4fb5
https://github.com/Perl/perl5/commit/43ae6574747dbbde7143ebcd9374e9d315aa4fb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 6a07e649aa1deede970dc154e0933527d14af0f4
https://github.com/Perl/perl5/commit/6a07e649aa1deede970dc154e0933527d14af0f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: b0a5eb619399e63f6b3862f0b12f86ee0550561e
https://github.com/Perl/perl5/commit/b0a5eb619399e63f6b3862f0b12f86ee0550561e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 86eb30140e011746dadc8499fddf662b7cfd302f
https://github.com/Perl/perl5/commit/86eb30140e011746dadc8499fddf662b7cfd302f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: d4842a48886cbc6b24be264d9468892e3ae0a299
https://github.com/Perl/perl5/commit/d4842a48886cbc6b24be264d9468892e3ae0a299
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: ce21efa0e7237bd776914a4090c6575209572386
https://github.com/Perl/perl5/commit/ce21efa0e7237bd776914a4090c6575209572386
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: a897264fda65f5eaaa796820bfdc2cbf7b26bb67
https://github.com/Perl/perl5/commit/a897264fda65f5eaaa796820bfdc2cbf7b26bb67
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: dbe20d126b0ccb3b86c5b5e48bd5e9bf26400816
https://github.com/Perl/perl5/commit/dbe20d126b0ccb3b86c5b5e48bd5e9bf26400816
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 96232f8c424f488029a090428fe1df11f060c55c
https://github.com/Perl/perl5/commit/96232f8c424f488029a090428fe1df11f060c55c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 6902dda8ef8026bfa7ddae20db0c37e2e0d61dcc
https://github.com/Perl/perl5/commit/6902dda8ef8026bfa7ddae20db0c37e2e0d61dcc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: e10afb5835f92c0c13edaea0135a2a16a019e968
https://github.com/Perl/perl5/commit/e10afb5835f92c0c13edaea0135a2a16a019e968
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 4fc8d36715c099c91351bf68ce3a3c8c062e5c06
https://github.com/Perl/perl5/commit/4fc8d36715c099c91351bf68ce3a3c8c062e5c06
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: aafe63861ef6d601c4799279691e5e25f7eac556
https://github.com/Perl/perl5/commit/aafe63861ef6d601c4799279691e5e25f7eac556
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: dac70ee62f5086a31151d10a570fd8c5be95b856
https://github.com/Perl/perl5/commit/dac70ee62f5086a31151d10a570fd8c5be95b856
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 2e0e35ac4184839c9d0cf67b8a99c50bb84c3eca
https://github.com/Perl/perl5/commit/2e0e35ac4184839c9d0cf67b8a99c50bb84c3eca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 2a5ee34b49fee7325d91b46b5b7bdf8fb4bae4cc
https://github.com/Perl/perl5/commit/2a5ee34b49fee7325d91b46b5b7bdf8fb4bae4cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 618794d1435228ad2a1b043c093e6d86c792960a
https://github.com/Perl/perl5/commit/618794d1435228ad2a1b043c093e6d86c792960a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 85d9f8a65b06f6c7d49b8def18f7195d84508ae6
https://github.com/Perl/perl5/commit/85d9f8a65b06f6c7d49b8def18f7195d84508ae6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 0e39fe9abc41b2e4f422505f32a1986e31b521f0
https://github.com/Perl/perl5/commit/0e39fe9abc41b2e4f422505f32a1986e31b521f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 67583d8e4a6cc7e8c5f8b5dcd3227c408fd3b1e4
https://github.com/Perl/perl5/commit/67583d8e4a6cc7e8c5f8b5dcd3227c408fd3b1e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 05f2fe28ce5817beaa1efad2c8637e47975ba853
https://github.com/Perl/perl5/commit/05f2fe28ce5817beaa1efad2c8637e47975ba853
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 2b90f7a2f91e7c76aa9dc9f10e287ab6c61678c9
https://github.com/Perl/perl5/commit/2b90f7a2f91e7c76aa9dc9f10e287ab6c61678c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 227755e0e7d1c1b0bf46ddcbcee321457a1b68ce
https://github.com/Perl/perl5/commit/227755e0e7d1c1b0bf46ddcbcee321457a1b68ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 7b3d1247df78e05186b5710bfc3dff1adad97aa9
https://github.com/Perl/perl5/commit/7b3d1247df78e05186b5710bfc3dff1adad97aa9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 0f1378239b61d621d3b4519dcc5667ebbd9b6b1f
https://github.com/Perl/perl5/commit/0f1378239b61d621d3b4519dcc5667ebbd9b6b1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: cbff3effe7d704fe13408a15b4d55e15c75a720c
https://github.com/Perl/perl5/commit/cbff3effe7d704fe13408a15b4d55e15c75a720c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: c4dda4b55e688d4ae23650f0d8b55ef272ffa6ee
https://github.com/Perl/perl5/commit/c4dda4b55e688d4ae23650f0d8b55ef272ffa6ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 57d7c6f8f901af6c09dcf33187da73a1b9bfd59f
https://github.com/Perl/perl5/commit/57d7c6f8f901af6c09dcf33187da73a1b9bfd59f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 626fcb6df57b68ab8a8432e59954107b957af613
https://github.com/Perl/perl5/commit/626fcb6df57b68ab8a8432e59954107b957af613
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 2d110e9b51f232510541aeb90084a330192a9835
https://github.com/Perl/perl5/commit/2d110e9b51f232510541aeb90084a330192a9835
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: b77ad19aad275a0f78b24bee01e6cdea3fc11ddc
https://github.com/Perl/perl5/commit/b77ad19aad275a0f78b24bee01e6cdea3fc11ddc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 11c82d7f40c88e197f44944c5c930ca0245d7066
https://github.com/Perl/perl5/commit/11c82d7f40c88e197f44944c5c930ca0245d7066
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 5e97240db77cb73f36cbf1a284b220e5c2b02113
https://github.com/Perl/perl5/commit/5e97240db77cb73f36cbf1a284b220e5c2b02113
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: c45cca1e927397aded55c77017f8d4f70b6787c9
https://github.com/Perl/perl5/commit/c45cca1e927397aded55c77017f8d4f70b6787c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 790642f0d15658ffb52be2a77a46e75c38bde436
https://github.com/Perl/perl5/commit/790642f0d15658ffb52be2a77a46e75c38bde436
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 36c5e236ee4fb51ade4d4b591bf29564ccc3ad57
https://github.com/Perl/perl5/commit/36c5e236ee4fb51ade4d4b591bf29564ccc3ad57
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 178e4bb538ffb3dd0ed034daec424ff51d6e85ab
https://github.com/Perl/perl5/commit/178e4bb538ffb3dd0ed034daec424ff51d6e85ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: ce2682da5b81816aee9192498771627bf1bacbbe
https://github.com/Perl/perl5/commit/ce2682da5b81816aee9192498771627bf1bacbbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 245e65f7eebc4bead9dc16569dc46ab0e14f348e
https://github.com/Perl/perl5/commit/245e65f7eebc4bead9dc16569dc46ab0e14f348e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: f34f563d52c55533e9e775f1e8f937cdc62d89e5
https://github.com/Perl/perl5/commit/f34f563d52c55533e9e775f1e8f937cdc62d89e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 4d09cd70ca04afd8e82b3641bcf756da394f0433
https://github.com/Perl/perl5/commit/4d09cd70ca04afd8e82b3641bcf756da394f0433
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: dbe1a142665895dd0114ea933097d2f8b48ad09b
https://github.com/Perl/perl5/commit/dbe1a142665895dd0114ea933097d2f8b48ad09b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: b96999c50c01f85f2a511d294c1983c87a90f81e
https://github.com/Perl/perl5/commit/b96999c50c01f85f2a511d294c1983c87a90f81e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: f100583e6ddd2126c62e380fcb0ac1d1bf5773ce
https://github.com/Perl/perl5/commit/f100583e6ddd2126c62e380fcb0ac1d1bf5773ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: fc3e7317a377c439db896b21bf23823cb37c92be
https://github.com/Perl/perl5/commit/fc3e7317a377c439db896b21bf23823cb37c92be
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: fdc6c73079c0d2c1b748343a55d16423d1f4847e
https://github.com/Perl/perl5/commit/fdc6c73079c0d2c1b748343a55d16423d1f4847e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 29669ae87c93a12afb581b97191b2c925c2e6902
https://github.com/Perl/perl5/commit/29669ae87c93a12afb581b97191b2c925c2e6902
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 5c9fd68f2c5f2ce83256b245cead799e7664f68e
https://github.com/Perl/perl5/commit/5c9fd68f2c5f2ce83256b245cead799e7664f68e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 911ee4d90a1c2bcd63dc847721ff7501a0944947
https://github.com/Perl/perl5/commit/911ee4d90a1c2bcd63dc847721ff7501a0944947
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 9e7ecc484baa8b746c9b5cd3e27ce04b12bee843
https://github.com/Perl/perl5/commit/9e7ecc484baa8b746c9b5cd3e27ce04b12bee843
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 69741538b1e5096156cf7d8c1897f5f8af9769e6
https://github.com/Perl/perl5/commit/69741538b1e5096156cf7d8c1897f5f8af9769e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 4e6f29f0b05f2542599f9676b2eac06016a272a9
https://github.com/Perl/perl5/commit/4e6f29f0b05f2542599f9676b2eac06016a272a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 566982fff2e8719beb70d64be222317d47cc58a3
https://github.com/Perl/perl5/commit/566982fff2e8719beb70d64be222317d47cc58a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 30502e8935f9da66df3db9432723b9446a52dc6a
https://github.com/Perl/perl5/commit/30502e8935f9da66df3db9432723b9446a52dc6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 6567372f3b334633a65431bfb3b7abf161596bfd
https://github.com/Perl/perl5/commit/6567372f3b334633a65431bfb3b7abf161596bfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 9aedb29737f948d54ce164d828a322a782be5153
https://github.com/Perl/perl5/commit/9aedb29737f948d54ce164d828a322a782be5153
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 011d1412180f55b1578f77d408874287d8f43932
https://github.com/Perl/perl5/commit/011d1412180f55b1578f77d408874287d8f43932
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 90bedd90e0c3a1d19334cd724e52773e4c3197c2
https://github.com/Perl/perl5/commit/90bedd90e0c3a1d19334cd724e52773e4c3197c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 2a044a54b5ba8e247c1f53d94dc6d6f11240e535
https://github.com/Perl/perl5/commit/2a044a54b5ba8e247c1f53d94dc6d6f11240e535
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 8019f8efdeecfab296d2feeb481e60f2358c70fe
https://github.com/Perl/perl5/commit/8019f8efdeecfab296d2feeb481e60f2358c70fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 9be68e4b9d86086edc1a89eee2fe324c1eccae44
https://github.com/Perl/perl5/commit/9be68e4b9d86086edc1a89eee2fe324c1eccae44
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 9fcd74129c0ab1c67b4199feec2be9d5f5e4887d
https://github.com/Perl/perl5/commit/9fcd74129c0ab1c67b4199feec2be9d5f5e4887d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 67fc9b4187f0f9155b88d7bad56f8e5cb57e4ec3
https://github.com/Perl/perl5/commit/67fc9b4187f0f9155b88d7bad56f8e5cb57e4ec3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: cda96bb163bcec15fe29ccb7351623ea526a1252
https://github.com/Perl/perl5/commit/cda96bb163bcec15fe29ccb7351623ea526a1252
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 9c656006950bbdf2c583afe76e501be92e806cda
https://github.com/Perl/perl5/commit/9c656006950bbdf2c583afe76e501be92e806cda
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 60e3126667be2825f0aa9b04e9b1476daaae02d1
https://github.com/Perl/perl5/commit/60e3126667be2825f0aa9b04e9b1476daaae02d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 6e2bce6a181a9fb056ee8fc3a2c4e2b51b5ab6b0
https://github.com/Perl/perl5/commit/6e2bce6a181a9fb056ee8fc3a2c4e2b51b5ab6b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 8b54aae4e4a0946cb2127b8cea1dbe08e3714a02
https://github.com/Perl/perl5/commit/8b54aae4e4a0946cb2127b8cea1dbe08e3714a02
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 7f8c5d9c7799c341f5cff079b98a528177595df5
https://github.com/Perl/perl5/commit/7f8c5d9c7799c341f5cff079b98a528177595df5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 436579e1719c1a4bff357962f604ecd025b48638
https://github.com/Perl/perl5/commit/436579e1719c1a4bff357962f604ecd025b48638
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: e0098792889d1fd63dd32e725859107fba5df68b
https://github.com/Perl/perl5/commit/e0098792889d1fd63dd32e725859107fba5df68b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 8628afcb82ab01c47429840aa40dbbb1d2ab459c
https://github.com/Perl/perl5/commit/8628afcb82ab01c47429840aa40dbbb1d2ab459c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 25818be7466e9e6e2db364f877ac79dba1d73b21
https://github.com/Perl/perl5/commit/25818be7466e9e6e2db364f877ac79dba1d73b21
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 62e19a6dd1d93f017a00aa0b7a7bd7ad805ef4af
https://github.com/Perl/perl5/commit/62e19a6dd1d93f017a00aa0b7a7bd7ad805ef4af
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 5cd10af1484378572df4115a702761c06346ffb4
https://github.com/Perl/perl5/commit/5cd10af1484378572df4115a702761c06346ffb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: dea5b6d5978073ec5385726845bf4be452f9a4e1
https://github.com/Perl/perl5/commit/dea5b6d5978073ec5385726845bf4be452f9a4e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 3930d16e958ef0e00b6b2ac3f7f5ba02555ebee7
https://github.com/Perl/perl5/commit/3930d16e958ef0e00b6b2ac3f7f5ba02555ebee7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 4f601bc8169a32c9a257f71606e56c69ed2c876f
https://github.com/Perl/perl5/commit/4f601bc8169a32c9a257f71606e56c69ed2c876f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 02ddc5c2715d1d8e7c885d27f43dff2b4f2c06a4
https://github.com/Perl/perl5/commit/02ddc5c2715d1d8e7c885d27f43dff2b4f2c06a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 095886aecf7f47662f0677863af9898e48da0f9a
https://github.com/Perl/perl5/commit/095886aecf7f47662f0677863af9898e48da0f9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 6dc0e74a5c4ce0f4f1e0f9244ceeb5f19a198e44
https://github.com/Perl/perl5/commit/6dc0e74a5c4ce0f4f1e0f9244ceeb5f19a198e44
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 0c33d355d5662d87291839d93c940a0e78a4f5e3
https://github.com/Perl/perl5/commit/0c33d355d5662d87291839d93c940a0e78a4f5e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: ea8def819c738179cf7c36e0d955a7a2a4390407
https://github.com/Perl/perl5/commit/ea8def819c738179cf7c36e0d955a7a2a4390407
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 9cd78543fc1caa237333e6216492bc70aec35ac1
https://github.com/Perl/perl5/commit/9cd78543fc1caa237333e6216492bc70aec35ac1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 1c0094bb810c3b238c236589d026ca13733424b4
https://github.com/Perl/perl5/commit/1c0094bb810c3b238c236589d026ca13733424b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 83638399295234f30ee99aa07d41182f0c443719
https://github.com/Perl/perl5/commit/83638399295234f30ee99aa07d41182f0c443719
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 7862597bd5f23ef53163c8849145c12122bcb748
https://github.com/Perl/perl5/commit/7862597bd5f23ef53163c8849145c12122bcb748
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 1f7ff00cdfff937a98d3413dc7c535308ff244f3
https://github.com/Perl/perl5/commit/1f7ff00cdfff937a98d3413dc7c535308ff244f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: edf78d3260473d11fedcba584477bc59053797fa
https://github.com/Perl/perl5/commit/edf78d3260473d11fedcba584477bc59053797fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 786563bb9242b848fa40bf1fd4563fecaad1f281
https://github.com/Perl/perl5/commit/786563bb9242b848fa40bf1fd4563fecaad1f281
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 220098dacccc2bcb106c5c27f18b1a1e810e9888
https://github.com/Perl/perl5/commit/220098dacccc2bcb106c5c27f18b1a1e810e9888
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 7af964ed86641bb29a1bad3b08d6935760e9d856
https://github.com/Perl/perl5/commit/7af964ed86641bb29a1bad3b08d6935760e9d856
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: b2947cf5adfcd9fa450e8d9c702ba171a85a70f5
https://github.com/Perl/perl5/commit/b2947cf5adfcd9fa450e8d9c702ba171a85a70f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: e45c3aaf644f38a6143149160bdf7c8c32085dd6
https://github.com/Perl/perl5/commit/e45c3aaf644f38a6143149160bdf7c8c32085dd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 03027d37bdc89763dc4f2abc86d0967ab1c9dbbb
https://github.com/Perl/perl5/commit/03027d37bdc89763dc4f2abc86d0967ab1c9dbbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 93b4b7de672433eb8cd245e9dd53e1d74939a14b
https://github.com/Perl/perl5/commit/93b4b7de672433eb8cd245e9dd53e1d74939a14b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 66128e645e0da2541f3c53408e1ef50aac13576d
https://github.com/Perl/perl5/commit/66128e645e0da2541f3c53408e1ef50aac13576d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 8bddeb9a7e32fa5cbe86d8e21e04378bafa25eb0
https://github.com/Perl/perl5/commit/8bddeb9a7e32fa5cbe86d8e21e04378bafa25eb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: fef68e7c8af854673b740422835e05cef5cccdcd
https://github.com/Perl/perl5/commit/fef68e7c8af854673b740422835e05cef5cccdcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 98b15ebb86dee8d6ab7e7fd0a65b4ba9b0f4903b
https://github.com/Perl/perl5/commit/98b15ebb86dee8d6ab7e7fd0a65b4ba9b0f4903b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 52d25d1ba8f6c64aad0459232744b854327b87ed
https://github.com/Perl/perl5/commit/52d25d1ba8f6c64aad0459232744b854327b87ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 400df1166cc71b97eb1bdf8d45924ac815af6c78
https://github.com/Perl/perl5/commit/400df1166cc71b97eb1bdf8d45924ac815af6c78
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5c91a9fa9997bd5fcd22b80337b5486db303ee8a
https://github.com/Perl/perl5/commit/5c91a9fa9997bd5fcd22b80337b5486db303ee8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d188765359cfe71c615f5e635abda2fe15d7177c
https://github.com/Perl/perl5/commit/d188765359cfe71c615f5e635abda2fe15d7177c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 0523c13fd37b43ecbadfc30bb1cfdf26be61cb5c
https://github.com/Perl/perl5/commit/0523c13fd37b43ecbadfc30bb1cfdf26be61cb5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: f369b5374a9ae17aa41b1774d57bca25debf8714
https://github.com/Perl/perl5/commit/f369b5374a9ae17aa41b1774d57bca25debf8714
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 81da5d929d367656e6ade8aff27ee7c3d7ff9db8
https://github.com/Perl/perl5/commit/81da5d929d367656e6ade8aff27ee7c3d7ff9db8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: cb8710d2cba8bdcffbf4a21f525fd08a66b43bd4
https://github.com/Perl/perl5/commit/cb8710d2cba8bdcffbf4a21f525fd08a66b43bd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 0fffabc87e7b667ba5be2b7c54976ff7c6ad5a41
https://github.com/Perl/perl5/commit/0fffabc87e7b667ba5be2b7c54976ff7c6ad5a41
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: dbc668b9cc48be067a36517c1e081ac7cfe6a3c7
https://github.com/Perl/perl5/commit/dbc668b9cc48be067a36517c1e081ac7cfe6a3c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 24457e89a5e00c06e0944d604c9b9f7cfddb21d3
https://github.com/Perl/perl5/commit/24457e89a5e00c06e0944d604c9b9f7cfddb21d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 99f5d88a5a7619da70e86ea6412340946e37720c
https://github.com/Perl/perl5/commit/99f5d88a5a7619da70e86ea6412340946e37720c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: ea365156845c849c09233ab4caee20b0ad8026a3
https://github.com/Perl/perl5/commit/ea365156845c849c09233ab4caee20b0ad8026a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: fdf0ba20786cfbeffa43d6732372064c8fb34e64
https://github.com/Perl/perl5/commit/fdf0ba20786cfbeffa43d6732372064c8fb34e64
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 11b0acd3023c1ed1b829b9c5563a231f8427fe2a
https://github.com/Perl/perl5/commit/11b0acd3023c1ed1b829b9c5563a231f8427fe2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: c53803e29e785162f068f72ad26a92a2290b6742
https://github.com/Perl/perl5/commit/c53803e29e785162f068f72ad26a92a2290b6742
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 82ce583045c2205847a7303bc9a2b9b10af699b9
https://github.com/Perl/perl5/commit/82ce583045c2205847a7303bc9a2b9b10af699b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 1e436e0319710bef068e316893de8a2733ad7ecb
https://github.com/Perl/perl5/commit/1e436e0319710bef068e316893de8a2733ad7ecb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 957b9922fd9b9774cdf54d3ddcc1f4823f114c9d
https://github.com/Perl/perl5/commit/957b9922fd9b9774cdf54d3ddcc1f4823f114c9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 95e0f208aa3547c8c5cea979c273d9bb71955ee5
https://github.com/Perl/perl5/commit/95e0f208aa3547c8c5cea979c273d9bb71955ee5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 86610bcddbd257bbc4a7eb936106e5cac2e1c4c1
https://github.com/Perl/perl5/commit/86610bcddbd257bbc4a7eb936106e5cac2e1c4c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 298f7a6005281904bd7717182c73850493bb0104
https://github.com/Perl/perl5/commit/298f7a6005281904bd7717182c73850493bb0104
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b2015cdef8f9f6f2931c6baa70e728495a6874a5
https://github.com/Perl/perl5/commit/b2015cdef8f9f6f2931c6baa70e728495a6874a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: d64c560a4885efd692d9fa31f6174b13b059e0a7
https://github.com/Perl/perl5/commit/d64c560a4885efd692d9fa31f6174b13b059e0a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 1a8fc24b70450d116762fc36b63fb4bcf419d700
https://github.com/Perl/perl5/commit/1a8fc24b70450d116762fc36b63fb4bcf419d700
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 9b087af3fd1393a43301b77e284f3e431f061a3b
https://github.com/Perl/perl5/commit/9b087af3fd1393a43301b77e284f3e431f061a3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: c0b511c10dbadcd565e0aab533622e4719f9c4b9
https://github.com/Perl/perl5/commit/c0b511c10dbadcd565e0aab533622e4719f9c4b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 1dc7a8798015c88a03e270e8a50b6295131b6695
https://github.com/Perl/perl5/commit/1dc7a8798015c88a03e270e8a50b6295131b6695
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: cdf66ee4be44bb32a7405e5ccf1ca5f2651e5b9e
https://github.com/Perl/perl5/commit/cdf66ee4be44bb32a7405e5ccf1ca5f2651e5b9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 0afa07b5df8ca7bda1bb1fd42358ea31cbef7950
https://github.com/Perl/perl5/commit/0afa07b5df8ca7bda1bb1fd42358ea31cbef7950
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 6fb5a00600df629ed21ed42f8df2dcdcfa9570c5
https://github.com/Perl/perl5/commit/6fb5a00600df629ed21ed42f8df2dcdcfa9570c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 2d93bd5a6dd855808f3185f097079b8f23b583d3
https://github.com/Perl/perl5/commit/2d93bd5a6dd855808f3185f097079b8f23b583d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 93ceef1514721dc005f659fbbd8f91b0dcbfbd48
https://github.com/Perl/perl5/commit/93ceef1514721dc005f659fbbd8f91b0dcbfbd48
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 64f8293562af737fa8009c538086ee287e73ffca
https://github.com/Perl/perl5/commit/64f8293562af737fa8009c538086ee287e73ffca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: d9284a834f269c575b56a54ab05d87755992cc86
https://github.com/Perl/perl5/commit/d9284a834f269c575b56a54ab05d87755992cc86
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 801038abf94229f9e16964c5e0f79903ca603bb5
https://github.com/Perl/perl5/commit/801038abf94229f9e16964c5e0f79903ca603bb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 17bb9f135518f4eecc7f0ccea56f38b4df19bae5
https://github.com/Perl/perl5/commit/17bb9f135518f4eecc7f0ccea56f38b4df19bae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 41bcdb8823a5036fc9ac3cc86cbb2e422b1ae538
https://github.com/Perl/perl5/commit/41bcdb8823a5036fc9ac3cc86cbb2e422b1ae538
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: a3f190e79add920ce638a2816f817e7430ff9f73
https://github.com/Perl/perl5/commit/a3f190e79add920ce638a2816f817e7430ff9f73
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 7212f87f948913e912c4472f43191a4a31211487
https://github.com/Perl/perl5/commit/7212f87f948913e912c4472f43191a4a31211487
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more22
Compare: https://github.com/Perl/perl5/compare/f7e6507cd12d...7212f87f9489
