Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: aac85fadbd1835e519519ce5112c85d40949e48b
https://github.com/Perl/perl5/commit/aac85fadbd1835e519519ce5112c85d40949e48b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 46dc52002ac3637598ecb8cfb32c054820054526
https://github.com/Perl/perl5/commit/46dc52002ac3637598ecb8cfb32c054820054526
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 598fc2e1bdb96fd310013064dba9f097e8e8ef99
https://github.com/Perl/perl5/commit/598fc2e1bdb96fd310013064dba9f097e8e8ef99
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 3c1f36067c9a8416bb18f4a21a6204996cc92449
https://github.com/Perl/perl5/commit/3c1f36067c9a8416bb18f4a21a6204996cc92449
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 072432af9a64b543a6fcdd7a1681c51e28c39692
https://github.com/Perl/perl5/commit/072432af9a64b543a6fcdd7a1681c51e28c39692
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 4d6608685b8f62e2aa23dfd874f28935c35c72b0
https://github.com/Perl/perl5/commit/4d6608685b8f62e2aa23dfd874f28935c35c72b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: cb0192c41863370c33adfd0db2f950c7668d290d
https://github.com/Perl/perl5/commit/cb0192c41863370c33adfd0db2f950c7668d290d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 81acfa5576fb296c329a6f76cf3e025f253ef5e7
https://github.com/Perl/perl5/commit/81acfa5576fb296c329a6f76cf3e025f253ef5e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 442f288626dab7a9070693cc17953d7f3672e606
https://github.com/Perl/perl5/commit/442f288626dab7a9070693cc17953d7f3672e606
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 3a6816aae12a2bdf31528155d3d78003f3fa99c2
https://github.com/Perl/perl5/commit/3a6816aae12a2bdf31528155d3d78003f3fa99c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 358880efae1ae5663a22468e4ad213a930a1ea80
https://github.com/Perl/perl5/commit/358880efae1ae5663a22468e4ad213a930a1ea80
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 586c9ab77db9594e6d14ac839eff355aee39c716
https://github.com/Perl/perl5/commit/586c9ab77db9594e6d14ac839eff355aee39c716
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 5512cb28192427b547247a13df39fc0f84e2cce1
https://github.com/Perl/perl5/commit/5512cb28192427b547247a13df39fc0f84e2cce1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 3f179e01ae7137c51186816f179c095d1b024f5b
https://github.com/Perl/perl5/commit/3f179e01ae7137c51186816f179c095d1b024f5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: eead36b26e93efc92686c17fc10254e7a0c74bc0
https://github.com/Perl/perl5/commit/eead36b26e93efc92686c17fc10254e7a0c74bc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 2d4a73c8a013c98d2f32b2ecd0c863680a85add5
https://github.com/Perl/perl5/commit/2d4a73c8a013c98d2f32b2ecd0c863680a85add5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: d3cd9258998eb84d16671da2391ec41143a301f0
https://github.com/Perl/perl5/commit/d3cd9258998eb84d16671da2391ec41143a301f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: d118baee78356a5c2a53c5134ac669963b1b93cf
https://github.com/Perl/perl5/commit/d118baee78356a5c2a53c5134ac669963b1b93cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 01ccfc9e223d334bf259a6524b2ef98ac8635f0e
https://github.com/Perl/perl5/commit/01ccfc9e223d334bf259a6524b2ef98ac8635f0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: f10270d780b3b08e28e05cdc2307f623fd5148f1
https://github.com/Perl/perl5/commit/f10270d780b3b08e28e05cdc2307f623fd5148f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 2d70c1e1b903e0c0cc8356af57ab2ca992932d2a
https://github.com/Perl/perl5/commit/2d70c1e1b903e0c0cc8356af57ab2ca992932d2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 4b5cf4b99259627af3e868f2e557fa08fa011ad1
https://github.com/Perl/perl5/commit/4b5cf4b99259627af3e868f2e557fa08fa011ad1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: ad1443526fca399780d6a38f9a413d496193b30f
https://github.com/Perl/perl5/commit/ad1443526fca399780d6a38f9a413d496193b30f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 044c0e29e9f4f891bbac39a2fa7545402f2ea7e9
https://github.com/Perl/perl5/commit/044c0e29e9f4f891bbac39a2fa7545402f2ea7e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 3d5eefd227d9ffaae265f6806afb80deae0b388b
https://github.com/Perl/perl5/commit/3d5eefd227d9ffaae265f6806afb80deae0b388b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 809c1cfbd7585971b22317d838379d86eb3733b4
https://github.com/Perl/perl5/commit/809c1cfbd7585971b22317d838379d86eb3733b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 9e9f55a49c6f1801717915c8a634202e974dfad1
https://github.com/Perl/perl5/commit/9e9f55a49c6f1801717915c8a634202e974dfad1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 083db809f3a85543f067146d5275cab44dac6351
https://github.com/Perl/perl5/commit/083db809f3a85543f067146d5275cab44dac6351
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 15da74265763109e26c3ae51635d2688db85c0b9
https://github.com/Perl/perl5/commit/15da74265763109e26c3ae51635d2688db85c0b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 82cb6b8fc427dfe76a432e887c85bf129b71d5eb
https://github.com/Perl/perl5/commit/82cb6b8fc427dfe76a432e887c85bf129b71d5eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: cf1fdc930790d6b7d5c6194dbfb6d70155dbf35a
https://github.com/Perl/perl5/commit/cf1fdc930790d6b7d5c6194dbfb6d70155dbf35a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 41f6da977402572bf0f634ade15514e86f11b86b
https://github.com/Perl/perl5/commit/41f6da977402572bf0f634ade15514e86f11b86b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 505bcc64532b89e186827e9b625be5adbc8e66b4
https://github.com/Perl/perl5/commit/505bcc64532b89e186827e9b625be5adbc8e66b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 18add3ccd60b74cc710a3f6eda82d070d15a3d7d
https://github.com/Perl/perl5/commit/18add3ccd60b74cc710a3f6eda82d070d15a3d7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 36eb8d8ea06cb01e6269d3d3abe620f85122c9f2
https://github.com/Perl/perl5/commit/36eb8d8ea06cb01e6269d3d3abe620f85122c9f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 3fb13dec3350cf2d4384af204b96865d0cef89a7
https://github.com/Perl/perl5/commit/3fb13dec3350cf2d4384af204b96865d0cef89a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 8d8afee3607823935a1721bbca7340205ca0999a
https://github.com/Perl/perl5/commit/8d8afee3607823935a1721bbca7340205ca0999a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 9f19432d3e769181d8c1ffece07a84a725fc9618
https://github.com/Perl/perl5/commit/9f19432d3e769181d8c1ffece07a84a725fc9618
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: d031cd6e6ee0145d61ce4b86d4be0e6155871743
https://github.com/Perl/perl5/commit/d031cd6e6ee0145d61ce4b86d4be0e6155871743
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: e7c397186ae6e4b2220f991b0432c954cf76d1f6
https://github.com/Perl/perl5/commit/e7c397186ae6e4b2220f991b0432c954cf76d1f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 96048fbaab8766819338d7b7103753cf1749b13b
https://github.com/Perl/perl5/commit/96048fbaab8766819338d7b7103753cf1749b13b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 1a4cb666452985129448fb644e5ca7bb5bc9ad2e
https://github.com/Perl/perl5/commit/1a4cb666452985129448fb644e5ca7bb5bc9ad2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 52c05284e53122292cda27a8758f99fe79c40baa
https://github.com/Perl/perl5/commit/52c05284e53122292cda27a8758f99fe79c40baa
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 97110b10ebd15a142e09991a33cf99e73f21e8c0
https://github.com/Perl/perl5/commit/97110b10ebd15a142e09991a33cf99e73f21e8c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 2a9ff1e72161d905ae483cca59c02d3647db5a89
https://github.com/Perl/perl5/commit/2a9ff1e72161d905ae483cca59c02d3647db5a89
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 71be4b27d613bb6241c99b977b290ffb5f89c32f
https://github.com/Perl/perl5/commit/71be4b27d613bb6241c99b977b290ffb5f89c32f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 045b55b3820ec02221400860d1ad04f3f6df4943
https://github.com/Perl/perl5/commit/045b55b3820ec02221400860d1ad04f3f6df4943
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: ecc19da86e0957f6ad7285fdd7f11e6eefc65159
https://github.com/Perl/perl5/commit/ecc19da86e0957f6ad7285fdd7f11e6eefc65159
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 46fb4a68bc99341b9cce8979d095573bc46b40ec
https://github.com/Perl/perl5/commit/46fb4a68bc99341b9cce8979d095573bc46b40ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 2e81e2772fd07da4927f90e43ebbbfec5b7d9cb5
https://github.com/Perl/perl5/commit/2e81e2772fd07da4927f90e43ebbbfec5b7d9cb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 67f46f5e9b62f8043a680f44127db706019dd19e
https://github.com/Perl/perl5/commit/67f46f5e9b62f8043a680f44127db706019dd19e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: e8ff197f69e086edd437533112be609c5c9b06ce
https://github.com/Perl/perl5/commit/e8ff197f69e086edd437533112be609c5c9b06ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 4b85dc13b0254c46af4581a23ce18a7183ef4de3
https://github.com/Perl/perl5/commit/4b85dc13b0254c46af4581a23ce18a7183ef4de3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 2919c47e0bff6c0d34fab825c0dbc96604dcf413
https://github.com/Perl/perl5/commit/2919c47e0bff6c0d34fab825c0dbc96604dcf413
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 223b3c0debf69d9d7674d2583aec876887a5373c
https://github.com/Perl/perl5/commit/223b3c0debf69d9d7674d2583aec876887a5373c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 130e11c12df5dc7f2909079879633801a366da5f
https://github.com/Perl/perl5/commit/130e11c12df5dc7f2909079879633801a366da5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 02c7b2bba676b09d3ea97bc19fe3379378231675
https://github.com/Perl/perl5/commit/02c7b2bba676b09d3ea97bc19fe3379378231675
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 650fe8eb195399ff99b775498b41bad0edbc3449
https://github.com/Perl/perl5/commit/650fe8eb195399ff99b775498b41bad0edbc3449
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 9889e52a4de5ba287de3d15f3e1547c2bed7c9b4
https://github.com/Perl/perl5/commit/9889e52a4de5ba287de3d15f3e1547c2bed7c9b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: e610df4abdf5a83cb3133a7be5eb86bf098c41fc
https://github.com/Perl/perl5/commit/e610df4abdf5a83cb3133a7be5eb86bf098c41fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 593d6c2fe7f91121793fb476b39df7d1d4fe169b
https://github.com/Perl/perl5/commit/593d6c2fe7f91121793fb476b39df7d1d4fe169b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: eca814de0191f380f45e5ceb5e5cd3ba0fa9cf1f
https://github.com/Perl/perl5/commit/eca814de0191f380f45e5ceb5e5cd3ba0fa9cf1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: f67ba86c282da3f3425acd3f966f4d62d33fa051
https://github.com/Perl/perl5/commit/f67ba86c282da3f3425acd3f966f4d62d33fa051
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 09b8d8f52e15f617d34a15cff504daa70a138be3
https://github.com/Perl/perl5/commit/09b8d8f52e15f617d34a15cff504daa70a138be3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 64ce5df17bc760bf12339c3a9cdd670a1aff407a
https://github.com/Perl/perl5/commit/64ce5df17bc760bf12339c3a9cdd670a1aff407a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 2a0afc275fb5b60c9b24026c26f5028fa192b860
https://github.com/Perl/perl5/commit/2a0afc275fb5b60c9b24026c26f5028fa192b860
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3b04f77633db68413596d0ca821ab9744ffb7afa
https://github.com/Perl/perl5/commit/3b04f77633db68413596d0ca821ab9744ffb7afa
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 664d07829703d25dbbf922d7700c405dad6b502e
https://github.com/Perl/perl5/commit/664d07829703d25dbbf922d7700c405dad6b502e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 172f9032066c7197a561d02521da8de720356820
https://github.com/Perl/perl5/commit/172f9032066c7197a561d02521da8de720356820
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e6347c2eee6b7bd4594b156f621a6f6ede5a2b9c
https://github.com/Perl/perl5/commit/e6347c2eee6b7bd4594b156f621a6f6ede5a2b9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: b0d6619cbf84806b5204296cfd5a8bd074309acf
https://github.com/Perl/perl5/commit/b0d6619cbf84806b5204296cfd5a8bd074309acf
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 3ff5cc758fea6b74ab35e8b45839597b4eb3f53b
https://github.com/Perl/perl5/commit/3ff5cc758fea6b74ab35e8b45839597b4eb3f53b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: af01bf79eddc571b7b36f4854a4f3f6f66aa0774
https://github.com/Perl/perl5/commit/af01bf79eddc571b7b36f4854a4f3f6f66aa0774
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 8b67c888b241822016fc38c47424ca5b92629a11
https://github.com/Perl/perl5/commit/8b67c888b241822016fc38c47424ca5b92629a11
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 6a0b2519f19c369bc21bece8c707427a0890d59d
https://github.com/Perl/perl5/commit/6a0b2519f19c369bc21bece8c707427a0890d59d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: c45bc6d6bf50b379f0ea054574d4628cb6f8c23a
https://github.com/Perl/perl5/commit/c45bc6d6bf50b379f0ea054574d4628cb6f8c23a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 210e58f6cfc23239df4ae71ba8d19f40aa2986db
https://github.com/Perl/perl5/commit/210e58f6cfc23239df4ae71ba8d19f40aa2986db
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 3a1e6938c471a5c04a617f3dda0970ac6f8c0cd3
https://github.com/Perl/perl5/commit/3a1e6938c471a5c04a617f3dda0970ac6f8c0cd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 95b7d23a6a661fa3041a646d851eb4665a020541
https://github.com/Perl/perl5/commit/95b7d23a6a661fa3041a646d851eb4665a020541
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 8c6892fb126a1d3bf7b178a6510d66f876c4c348
https://github.com/Perl/perl5/commit/8c6892fb126a1d3bf7b178a6510d66f876c4c348
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 05fd9202d59c81f2089bd7584953cb3c33280fcf
https://github.com/Perl/perl5/commit/05fd9202d59c81f2089bd7584953cb3c33280fcf
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: f0e007ab74b2456959cf69b21df8f8c7dbd7c296
https://github.com/Perl/perl5/commit/f0e007ab74b2456959cf69b21df8f8c7dbd7c296
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e82a35b24d47d9acb1fd7bb2ab85e324baa6bac8
https://github.com/Perl/perl5/commit/e82a35b24d47d9acb1fd7bb2ab85e324baa6bac8
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 112922f42baa4977c04e18357a9698f24debfb0f
https://github.com/Perl/perl5/commit/112922f42baa4977c04e18357a9698f24debfb0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 41c36da0fd58e30127419cef67c56e55a6c864da
https://github.com/Perl/perl5/commit/41c36da0fd58e30127419cef67c56e55a6c864da
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 89b9925aeed3bde419e7799adb4d7310c937375e
https://github.com/Perl/perl5/commit/89b9925aeed3bde419e7799adb4d7310c937375e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 38a8b51f3a0511b3b18f51f5d32492ece50653ab
https://github.com/Perl/perl5/commit/38a8b51f3a0511b3b18f51f5d32492ece50653ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 30503201898b415d7f683c54ae5772639a534973
https://github.com/Perl/perl5/commit/30503201898b415d7f683c54ae5772639a534973
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 2e2d8dcc560964b31f0e7efffe0fbeb17f920b3b
https://github.com/Perl/perl5/commit/2e2d8dcc560964b31f0e7efffe0fbeb17f920b3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 92f6332684c11c2bfc10f76de93e50c317c553c4
https://github.com/Perl/perl5/commit/92f6332684c11c2bfc10f76de93e50c317c553c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 8649d5f84669bb544ad572b77fa2af28b163fe0d
https://github.com/Perl/perl5/commit/8649d5f84669bb544ad572b77fa2af28b163fe0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 2451d0ce375545f18c0480895ad684054a870765
https://github.com/Perl/perl5/commit/2451d0ce375545f18c0480895ad684054a870765
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 87ab74cb99b677d8a052642304c0a76b7ef0bbef
https://github.com/Perl/perl5/commit/87ab74cb99b677d8a052642304c0a76b7ef0bbef
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 35364fed5e900e9edae5cfdad4a1a1c3aa7ff83c
https://github.com/Perl/perl5/commit/35364fed5e900e9edae5cfdad4a1a1c3aa7ff83c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: d48be1066a2e5c86139a85b7594516297fef6a44
https://github.com/Perl/perl5/commit/d48be1066a2e5c86139a85b7594516297fef6a44
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 15d886fe119d3f6e74b5d8dd888bfacd6f691575
https://github.com/Perl/perl5/commit/15d886fe119d3f6e74b5d8dd888bfacd6f691575
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 40f76a4291f323bfbb34cc7d43c7e490b025d63f
https://github.com/Perl/perl5/commit/40f76a4291f323bfbb34cc7d43c7e490b025d63f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 4946481d7b6a3a423ff489732781d21b01ef232c
https://github.com/Perl/perl5/commit/4946481d7b6a3a423ff489732781d21b01ef232c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: a603b216332223453e07e0a763881dde492bcb6a
https://github.com/Perl/perl5/commit/a603b216332223453e07e0a763881dde492bcb6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 8e4c54c73dd20c22ec13abce354c19d583aca911
https://github.com/Perl/perl5/commit/8e4c54c73dd20c22ec13abce354c19d583aca911
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: e7a0086bb56ac2e0ad9019a184f18430b140e775
https://github.com/Perl/perl5/commit/e7a0086bb56ac2e0ad9019a184f18430b140e775
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: b4b2a6310eec0ce4b783de0565ff529c334cf05d
https://github.com/Perl/perl5/commit/b4b2a6310eec0ce4b783de0565ff529c334cf05d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 1b44f831d15e7d3a5d107fea960a461fa5663f68
https://github.com/Perl/perl5/commit/1b44f831d15e7d3a5d107fea960a461fa5663f68
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: de9669da85651ed0b01f52ded3eaeb7931ca5f09
https://github.com/Perl/perl5/commit/de9669da85651ed0b01f52ded3eaeb7931ca5f09
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: bda248296c0fa5e51ee4c35b0762685130bc1cea
https://github.com/Perl/perl5/commit/bda248296c0fa5e51ee4c35b0762685130bc1cea
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 781a00d62cef99d2af12319c2aa3d3b2b258afb9
https://github.com/Perl/perl5/commit/781a00d62cef99d2af12319c2aa3d3b2b258afb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 2fc45adce34852e9349a6d60ea58cc81696409ac
https://github.com/Perl/perl5/commit/2fc45adce34852e9349a6d60ea58cc81696409ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: fb8da0583dce4d91c454ef1ab71e31a229adbe6e
https://github.com/Perl/perl5/commit/fb8da0583dce4d91c454ef1ab71e31a229adbe6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 8afd1ccefc977520d20233cf5e87bf6bccee14f7
https://github.com/Perl/perl5/commit/8afd1ccefc977520d20233cf5e87bf6bccee14f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 53be0933f5bcf1e4636e0a0b71493a9345bcd251
https://github.com/Perl/perl5/commit/53be0933f5bcf1e4636e0a0b71493a9345bcd251
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 2f8c631102df2a6f86ba0d7d633d42dfa15d1360
https://github.com/Perl/perl5/commit/2f8c631102df2a6f86ba0d7d633d42dfa15d1360
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 2e68f5c50d96e5e8c46f2db25ebc9d26def6177d
https://github.com/Perl/perl5/commit/2e68f5c50d96e5e8c46f2db25ebc9d26def6177d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: b9b737b191343ffbe52faab4c04b157e643ac9a3
https://github.com/Perl/perl5/commit/b9b737b191343ffbe52faab4c04b157e643ac9a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 1cad3d8d18d7416a2697e8c3f160a1fbe396cf77
https://github.com/Perl/perl5/commit/1cad3d8d18d7416a2697e8c3f160a1fbe396cf77
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 562de3e1bb1a66dd05e8be7502a52fac674190c4
https://github.com/Perl/perl5/commit/562de3e1bb1a66dd05e8be7502a52fac674190c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 7805213572b0fa781712f3a9caf692b196474e23
https://github.com/Perl/perl5/commit/7805213572b0fa781712f3a9caf692b196474e23
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 05c6fe3c107372ba24d9e4537aed20b80777428f
https://github.com/Perl/perl5/commit/05c6fe3c107372ba24d9e4537aed20b80777428f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 3b3d4ea026df0929f625436496ecc75e1ba2ebd3
https://github.com/Perl/perl5/commit/3b3d4ea026df0929f625436496ecc75e1ba2ebd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: cdba1562b3a9846c1415c51a256d1d981a5a88a5
https://github.com/Perl/perl5/commit/cdba1562b3a9846c1415c51a256d1d981a5a88a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: dc74ae12b08de485f78c0b59833370156dedd252
https://github.com/Perl/perl5/commit/dc74ae12b08de485f78c0b59833370156dedd252
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 25ac9b5933bd161850f4379a571093aaa52048f6
https://github.com/Perl/perl5/commit/25ac9b5933bd161850f4379a571093aaa52048f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: c5ab1be334504bb0d8b6a6c2bfb3ded579503aaa
https://github.com/Perl/perl5/commit/c5ab1be334504bb0d8b6a6c2bfb3ded579503aaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: b238a97b0779749f9f7958f7818640536b55a996
https://github.com/Perl/perl5/commit/b238a97b0779749f9f7958f7818640536b55a996
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 86b3364cd23035444f22940454ab245d6a0cde74
https://github.com/Perl/perl5/commit/86b3364cd23035444f22940454ab245d6a0cde74
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 312f7baf4182ca04f68e8871cae42d4eb64bf35d
https://github.com/Perl/perl5/commit/312f7baf4182ca04f68e8871cae42d4eb64bf35d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 106498959d30a8e1274ef93c2639a3a2172a540b
https://github.com/Perl/perl5/commit/106498959d30a8e1274ef93c2639a3a2172a540b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: ef6bfce1a52935fbc8f82611b7c1b48250186703
https://github.com/Perl/perl5/commit/ef6bfce1a52935fbc8f82611b7c1b48250186703
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 597a1b11522de9dbaa4fc56b8dbf4ec7844793b3
https://github.com/Perl/perl5/commit/597a1b11522de9dbaa4fc56b8dbf4ec7844793b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: b4199a5a058c3e107d944c4775b755b55f4ac92a
https://github.com/Perl/perl5/commit/b4199a5a058c3e107d944c4775b755b55f4ac92a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 33ecb9d4b1db7e2dc1c79a7355f786c8876f6618
https://github.com/Perl/perl5/commit/33ecb9d4b1db7e2dc1c79a7355f786c8876f6618
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 676129c85d49584caa7555ca0e763945095ca78f
https://github.com/Perl/perl5/commit/676129c85d49584caa7555ca0e763945095ca78f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 44bc17e7e48c607951e8b1c6f31cf7234de6eca3
https://github.com/Perl/perl5/commit/44bc17e7e48c607951e8b1c6f31cf7234de6eca3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 2f72674b470276c248ca30cadf020ed1c08e55b0
https://github.com/Perl/perl5/commit/2f72674b470276c248ca30cadf020ed1c08e55b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 7daa011407138f53365a8fe1eaf7ec2ee6d64632
https://github.com/Perl/perl5/commit/7daa011407138f53365a8fe1eaf7ec2ee6d64632
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: dfb4f4145ca8cb34d2eb7d88c6795d2cf3e2eff0
https://github.com/Perl/perl5/commit/dfb4f4145ca8cb34d2eb7d88c6795d2cf3e2eff0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 872f9103001d28de40ebf41d2781dc8aaa55f023
https://github.com/Perl/perl5/commit/872f9103001d28de40ebf41d2781dc8aaa55f023
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 7f7720cca31a93b046b2e333cdeca951c197da52
https://github.com/Perl/perl5/commit/7f7720cca31a93b046b2e333cdeca951c197da52
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 6919f697edefb1407f90ab1d1cca8a3aef66830a
https://github.com/Perl/perl5/commit/6919f697edefb1407f90ab1d1cca8a3aef66830a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 03851ef630617864b76ee72cd5fe65b709c94f9b
https://github.com/Perl/perl5/commit/03851ef630617864b76ee72cd5fe65b709c94f9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 467597bf33c1fe877faae35b0d8efc6369ac3880
https://github.com/Perl/perl5/commit/467597bf33c1fe877faae35b0d8efc6369ac3880
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 45d0fa00575298754afd8c7d0746650f9d78b988
https://github.com/Perl/perl5/commit/45d0fa00575298754afd8c7d0746650f9d78b988
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 4fa1a45f7662ccf628c6eb6e909f9113f22170ec
https://github.com/Perl/perl5/commit/4fa1a45f7662ccf628c6eb6e909f9113f22170ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 5c941ad181dec18ba2934c663fc417dbee464599
https://github.com/Perl/perl5/commit/5c941ad181dec18ba2934c663fc417dbee464599
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 690d31edbb58800de244d4e808a1ea09bf57183d
https://github.com/Perl/perl5/commit/690d31edbb58800de244d4e808a1ea09bf57183d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: f8d4cc32cd6ee20118f433702361add9d1d84564
https://github.com/Perl/perl5/commit/f8d4cc32cd6ee20118f433702361add9d1d84564
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: bc5fcfe70f91dae7f6d9327ccf9d8219f2eb5355
https://github.com/Perl/perl5/commit/bc5fcfe70f91dae7f6d9327ccf9d8219f2eb5355
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: a308b38a221e24cc74147136e6fcc3b920fb38f7
https://github.com/Perl/perl5/commit/a308b38a221e24cc74147136e6fcc3b920fb38f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 271e32121137fcc0905176c5d3b2dacfd25e462b
https://github.com/Perl/perl5/commit/271e32121137fcc0905176c5d3b2dacfd25e462b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: a6fa407917d798a8a1f34f18eb6ccc163e26b408
https://github.com/Perl/perl5/commit/a6fa407917d798a8a1f34f18eb6ccc163e26b408
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: b8c98adea6e42423585021fe55a3dd006e9c07f3
https://github.com/Perl/perl5/commit/b8c98adea6e42423585021fe55a3dd006e9c07f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 72d0f8e5e191f8639aa798e3cbc84b9e7d2206ec
https://github.com/Perl/perl5/commit/72d0f8e5e191f8639aa798e3cbc84b9e7d2206ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 8be1acd3f4215d17bd29c9b185bd975639d4f171
https://github.com/Perl/perl5/commit/8be1acd3f4215d17bd29c9b185bd975639d4f171
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 813d54041d9cd0fce5e992f1f01c9f8ab73f1579
https://github.com/Perl/perl5/commit/813d54041d9cd0fce5e992f1f01c9f8ab73f1579
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 96256be587d92f2f462db33487de3cb95e0ae106
https://github.com/Perl/perl5/commit/96256be587d92f2f462db33487de3cb95e0ae106
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: f6deb65be02740e7446c32407a7a5743d711ba4f
https://github.com/Perl/perl5/commit/f6deb65be02740e7446c32407a7a5743d711ba4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 60313d60d83b3e782094ce205f063afaade2c996
https://github.com/Perl/perl5/commit/60313d60d83b3e782094ce205f063afaade2c996
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: bb523ee9cd574e5d32a5944542789f03107775d0
https://github.com/Perl/perl5/commit/bb523ee9cd574e5d32a5944542789f03107775d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 4425adb90e04345e4c82d0163c87b4bb1090e117
https://github.com/Perl/perl5/commit/4425adb90e04345e4c82d0163c87b4bb1090e117
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: a4cde8909b8619a5d416fc34d2a12c2637915e45
https://github.com/Perl/perl5/commit/a4cde8909b8619a5d416fc34d2a12c2637915e45
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: ab016bc28c70bb0e5a58d54f72b5136ef484bab1
https://github.com/Perl/perl5/commit/ab016bc28c70bb0e5a58d54f72b5136ef484bab1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 3ea0c8838766baa238b63063ec7944279acb0c71
https://github.com/Perl/perl5/commit/3ea0c8838766baa238b63063ec7944279acb0c71
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 276b552079d94c00885ab4e1073f42a4fdc08ade
https://github.com/Perl/perl5/commit/276b552079d94c00885ab4e1073f42a4fdc08ade
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: e5298cf1ea097e814be26c65ae38d06b64ba008c
https://github.com/Perl/perl5/commit/e5298cf1ea097e814be26c65ae38d06b64ba008c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 397ba2b70b69840eeed6a36959e73c92f142c0a7
https://github.com/Perl/perl5/commit/397ba2b70b69840eeed6a36959e73c92f142c0a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 27a4f24298b9b67d131f4b8fb34460260d972223
https://github.com/Perl/perl5/commit/27a4f24298b9b67d131f4b8fb34460260d972223
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 221682130587bf6810a022c23885c7f53e1f985a
https://github.com/Perl/perl5/commit/221682130587bf6810a022c23885c7f53e1f985a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: eb0b6c93d17173477ae6c0733b5056dda175db2d
https://github.com/Perl/perl5/commit/eb0b6c93d17173477ae6c0733b5056dda175db2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 61f5c00dbcf78c43cac300e6c85b3aaaa96fb704
https://github.com/Perl/perl5/commit/61f5c00dbcf78c43cac300e6c85b3aaaa96fb704
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 9a5714014b6910d9ddd13784cd47c4abb94be2e7
https://github.com/Perl/perl5/commit/9a5714014b6910d9ddd13784cd47c4abb94be2e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: ec33dd465fd816f0370de9eaab375f36c691e252
https://github.com/Perl/perl5/commit/ec33dd465fd816f0370de9eaab375f36c691e252
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 83f0e47b613663292f9ecf4370b64e7a5c889821
https://github.com/Perl/perl5/commit/83f0e47b613663292f9ecf4370b64e7a5c889821
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 77560a22a4833cd56d875a9d9cfec3e1c02b5e9d
https://github.com/Perl/perl5/commit/77560a22a4833cd56d875a9d9cfec3e1c02b5e9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 8605640a7d30ec3dfc79437f8f3073006dab29a3
https://github.com/Perl/perl5/commit/8605640a7d30ec3dfc79437f8f3073006dab29a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 99125f932209c08784e42c94884c8c94b2bb217a
https://github.com/Perl/perl5/commit/99125f932209c08784e42c94884c8c94b2bb217a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 16f50bb683d600d9208910923b20cb4a465e3617
https://github.com/Perl/perl5/commit/16f50bb683d600d9208910923b20cb4a465e3617
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 7d7647b30d4d0c7f1555921113aaf3b746993853
https://github.com/Perl/perl5/commit/7d7647b30d4d0c7f1555921113aaf3b746993853
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 01317e28221b38e1a1bf8bd1c984e3d8606ddfc5
https://github.com/Perl/perl5/commit/01317e28221b38e1a1bf8bd1c984e3d8606ddfc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: e2297c24bb4365fa2cc9544d3d520bc906b6097b
https://github.com/Perl/perl5/commit/e2297c24bb4365fa2cc9544d3d520bc906b6097b
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 23a57b39a1080401bf4aff63c9e79837c8a69ebc
https://github.com/Perl/perl5/commit/23a57b39a1080401bf4aff63c9e79837c8a69ebc
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: d0326fb824f5656943ca10718ef134d7699c15f5
https://github.com/Perl/perl5/commit/d0326fb824f5656943ca10718ef134d7699c15f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: a0700973959adaf241724e5d2abf7441ae075539
https://github.com/Perl/perl5/commit/a0700973959adaf241724e5d2abf7441ae075539
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 416b3afc1e0ae34c8cfb010bc58a7b18b1721158
https://github.com/Perl/perl5/commit/416b3afc1e0ae34c8cfb010bc58a7b18b1721158
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 8f128586c28e340ad8c8a65e204bfd3f3fe62290
https://github.com/Perl/perl5/commit/8f128586c28e340ad8c8a65e204bfd3f3fe62290
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: c128b78a0f08f56b6d12987b08cd6887df2d02b5
https://github.com/Perl/perl5/commit/c128b78a0f08f56b6d12987b08cd6887df2d02b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 72eda2be3e0b822458140d5586aeb517845b5924
https://github.com/Perl/perl5/commit/72eda2be3e0b822458140d5586aeb517845b5924
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 01ab7e793dbe8cc5fd12744f0a3c571a6f6ec07c
https://github.com/Perl/perl5/commit/01ab7e793dbe8cc5fd12744f0a3c571a6f6ec07c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 4d2d42ad5e1485cd85a552b5704874e448282f03
https://github.com/Perl/perl5/commit/4d2d42ad5e1485cd85a552b5704874e448282f03
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: d0636267bcf4af0f71ba948c56b511d9c2a206a5
https://github.com/Perl/perl5/commit/d0636267bcf4af0f71ba948c56b511d9c2a206a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 794b514eb1172c8a63eac3f892cc2c41c069d8db
https://github.com/Perl/perl5/commit/794b514eb1172c8a63eac3f892cc2c41c069d8db
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 99dfeb884751808f3a64f0b25922965f59382f60
https://github.com/Perl/perl5/commit/99dfeb884751808f3a64f0b25922965f59382f60
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: ace6dc11a112805134fc9236cce07cd45bc26aa2
https://github.com/Perl/perl5/commit/ace6dc11a112805134fc9236cce07cd45bc26aa2
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 8c44d0acd3f9a75bc704d423a8ea1289c9d046dd
https://github.com/Perl/perl5/commit/8c44d0acd3f9a75bc704d423a8ea1289c9d046dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: f07ee5cd23b7d3a4351ffc7802ad1f8216655355
https://github.com/Perl/perl5/commit/f07ee5cd23b7d3a4351ffc7802ad1f8216655355
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 75c5e35f6a581244aea2902dbf01bc6590e38b1d
https://github.com/Perl/perl5/commit/75c5e35f6a581244aea2902dbf01bc6590e38b1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 8e11d309dff7b0ce55482cedacf3bf193cd4381d
https://github.com/Perl/perl5/commit/8e11d309dff7b0ce55482cedacf3bf193cd4381d
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 47607dacbcd541cbd2ec16227a0ada91326061a8
https://github.com/Perl/perl5/commit/47607dacbcd541cbd2ec16227a0ada91326061a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 0e27877a5b37f5ccab797863bc33080825b73936
https://github.com/Perl/perl5/commit/0e27877a5b37f5ccab797863bc33080825b73936
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: cd93ca3090f89e7212f5755b6948e961859ae89a
https://github.com/Perl/perl5/commit/cd93ca3090f89e7212f5755b6948e961859ae89a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: d0cd6eec82819bddba19e94ba7581757e920cd82
https://github.com/Perl/perl5/commit/d0cd6eec82819bddba19e94ba7581757e920cd82
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 0859daf3d9e7582cd0512a826b875497b47da330
https://github.com/Perl/perl5/commit/0859daf3d9e7582cd0512a826b875497b47da330
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 0da461829e92630237725682b64cacc1cdf41a3c
https://github.com/Perl/perl5/commit/0da461829e92630237725682b64cacc1cdf41a3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: cc5291122984ab9fbc337df494d25846d1b44bf9
https://github.com/Perl/perl5/commit/cc5291122984ab9fbc337df494d25846d1b44bf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 01df29f5b8da3979c090259a0cd28c3fb38a5976
https://github.com/Perl/perl5/commit/01df29f5b8da3979c090259a0cd28c3fb38a5976
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a1958689af579a938b0191a9969cce57505f1642
https://github.com/Perl/perl5/commit/a1958689af579a938b0191a9969cce57505f1642
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: b9d29bbc506a851a2f5984eb0fd75aed3bd58484
https://github.com/Perl/perl5/commit/b9d29bbc506a851a2f5984eb0fd75aed3bd58484
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 9830048f3ff7913d7607f758a5a42f8288dbd9f7
https://github.com/Perl/perl5/commit/9830048f3ff7913d7607f758a5a42f8288dbd9f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 3e9eb33d842634ce5edcb907edec2704fd41f5fa
https://github.com/Perl/perl5/commit/3e9eb33d842634ce5edcb907edec2704fd41f5fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: bc8ff7793eff21b0edff08ea119f3019c123dde1
https://github.com/Perl/perl5/commit/bc8ff7793eff21b0edff08ea119f3019c123dde1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 2065e41080e523ca23248a561123b6a0d4609ce1
https://github.com/Perl/perl5/commit/2065e41080e523ca23248a561123b6a0d4609ce1
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: da32a53e29833b4a08c520d08730b3f84b726545
https://github.com/Perl/perl5/commit/da32a53e29833b4a08c520d08730b3f84b726545
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: ab09a586e8e509aaf2beff3f791544903f63370f
https://github.com/Perl/perl5/commit/ab09a586e8e509aaf2beff3f791544903f63370f
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 2a11663219aac6f50b74d6c3caab9e37d3084195
https://github.com/Perl/perl5/commit/2a11663219aac6f50b74d6c3caab9e37d3084195
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: a98868e4c8e811fd364da776ba56c1d246c1021a
https://github.com/Perl/perl5/commit/a98868e4c8e811fd364da776ba56c1d246c1021a
Author: Karl Williamson <[email protected]>
Date: 2021-04-06 (Tue, 06 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more17
Compare: https://github.com/Perl/perl5/compare/5279818a1539...a98868e4c8e8
