Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: d93a7ead23471a7b5ba2460650709694d2f2f1dc
https://github.com/Perl/perl5/commit/d93a7ead23471a7b5ba2460650709694d2f2f1dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 3d7d4d46bbbaa30a85585e71611f37c0d051bd62
https://github.com/Perl/perl5/commit/3d7d4d46bbbaa30a85585e71611f37c0d051bd62
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: b7cf51f378f5b73fb06049dc251507845ccaee64
https://github.com/Perl/perl5/commit/b7cf51f378f5b73fb06049dc251507845ccaee64
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 9877ddc105248f53b9f16315528ca7b366c85dc8
https://github.com/Perl/perl5/commit/9877ddc105248f53b9f16315528ca7b366c85dc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 7544e290332fac1bd72294514284ccb102283dd7
https://github.com/Perl/perl5/commit/7544e290332fac1bd72294514284ccb102283dd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: d03979dea7d4a7e6b0e98049d1c65b1230b80d19
https://github.com/Perl/perl5/commit/d03979dea7d4a7e6b0e98049d1c65b1230b80d19
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 2070573fb6e8a602262ff0c6482cb0c89e095350
https://github.com/Perl/perl5/commit/2070573fb6e8a602262ff0c6482cb0c89e095350
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 6744ce6ca6f35575eed9d024648fe9c3704beb53
https://github.com/Perl/perl5/commit/6744ce6ca6f35575eed9d024648fe9c3704beb53
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 556054cb551aa1693ca2915fac1e3502608993ee
https://github.com/Perl/perl5/commit/556054cb551aa1693ca2915fac1e3502608993ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 0fe568b08f002fadb9564fd275d7a97774b66c01
https://github.com/Perl/perl5/commit/0fe568b08f002fadb9564fd275d7a97774b66c01
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 03807294f8556a90b6422186377b2ac7a44782e3
https://github.com/Perl/perl5/commit/03807294f8556a90b6422186377b2ac7a44782e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 6c706fe9ecc73b6fffb3c8d69de7b09009e8d232
https://github.com/Perl/perl5/commit/6c706fe9ecc73b6fffb3c8d69de7b09009e8d232
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 4ad834b9c1397c6c9a870aa0c6e53b8d2892c25a
https://github.com/Perl/perl5/commit/4ad834b9c1397c6c9a870aa0c6e53b8d2892c25a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 1bee8bd27dd1767b16f5f88a20aa7476d45e1199
https://github.com/Perl/perl5/commit/1bee8bd27dd1767b16f5f88a20aa7476d45e1199
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: eb73ee2bc90cd7b7fc636b16df5d5bebb006bc9b
https://github.com/Perl/perl5/commit/eb73ee2bc90cd7b7fc636b16df5d5bebb006bc9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 4da9a3f96e02c9542ae61c69bbf67f111bf5801b
https://github.com/Perl/perl5/commit/4da9a3f96e02c9542ae61c69bbf67f111bf5801b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 051196f2e1386775ab8d61ab9506036449a43df1
https://github.com/Perl/perl5/commit/051196f2e1386775ab8d61ab9506036449a43df1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 7c1bbb23b05a28e3d45d1892d92f70b6fb7c4149
https://github.com/Perl/perl5/commit/7c1bbb23b05a28e3d45d1892d92f70b6fb7c4149
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: b66b47eb7b4541c2f21e770898f77efa86855290
https://github.com/Perl/perl5/commit/b66b47eb7b4541c2f21e770898f77efa86855290
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 6c907e8fd927fe986384343a12d3d368bb35f579
https://github.com/Perl/perl5/commit/6c907e8fd927fe986384343a12d3d368bb35f579
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: d6e94dff356194c2962e4c83c96e0a43274901d4
https://github.com/Perl/perl5/commit/d6e94dff356194c2962e4c83c96e0a43274901d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 57305e8d8150a3c94e681c6706cb48f4ffc5f268
https://github.com/Perl/perl5/commit/57305e8d8150a3c94e681c6706cb48f4ffc5f268
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: becbe49499b31a1968c09d37b13ec159a1c9fd48
https://github.com/Perl/perl5/commit/becbe49499b31a1968c09d37b13ec159a1c9fd48
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 40a904f442da72f68e5dfe77d283a7f324730497
https://github.com/Perl/perl5/commit/40a904f442da72f68e5dfe77d283a7f324730497
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 8442c4a5119e4e58bb304a95ba3a3b1e904b8052
https://github.com/Perl/perl5/commit/8442c4a5119e4e58bb304a95ba3a3b1e904b8052
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 357757768d89b54971a2b5e72479c8ff60592c13
https://github.com/Perl/perl5/commit/357757768d89b54971a2b5e72479c8ff60592c13
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 5dabe0fff67ec84adbf4e30aa1c210836f1d752f
https://github.com/Perl/perl5/commit/5dabe0fff67ec84adbf4e30aa1c210836f1d752f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: e1abfd63efad099dbb6ea7b3fe826f41f0e74d29
https://github.com/Perl/perl5/commit/e1abfd63efad099dbb6ea7b3fe826f41f0e74d29
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: fccefbaeae65d5a941864a7100074e1bdb4038e8
https://github.com/Perl/perl5/commit/fccefbaeae65d5a941864a7100074e1bdb4038e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 978f5941ae9553ef36af8c7a7925b0352da134ed
https://github.com/Perl/perl5/commit/978f5941ae9553ef36af8c7a7925b0352da134ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 80e8fab2e2ebdbace913b0ec8e605f4d7c837870
https://github.com/Perl/perl5/commit/80e8fab2e2ebdbace913b0ec8e605f4d7c837870
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: b24f1985b6bfbfc5c16964861bc7468e95ee24cb
https://github.com/Perl/perl5/commit/b24f1985b6bfbfc5c16964861bc7468e95ee24cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: a725d0cca1a320198f829222c4dac8781dec0831
https://github.com/Perl/perl5/commit/a725d0cca1a320198f829222c4dac8781dec0831
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 31e44609d9f08e35f55eeeb60927afd4bdf03ead
https://github.com/Perl/perl5/commit/31e44609d9f08e35f55eeeb60927afd4bdf03ead
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 723393a7b84cc5ac31f38b89467442f319744693
https://github.com/Perl/perl5/commit/723393a7b84cc5ac31f38b89467442f319744693
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 2c68c18dbff3b26d111abdd31777a3f5e3c1fc19
https://github.com/Perl/perl5/commit/2c68c18dbff3b26d111abdd31777a3f5e3c1fc19
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 8768da74be25cf1bdc90c93b16e679f7810d6659
https://github.com/Perl/perl5/commit/8768da74be25cf1bdc90c93b16e679f7810d6659
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 4ca7687e482820d4c569960437817bc9722dabd1
https://github.com/Perl/perl5/commit/4ca7687e482820d4c569960437817bc9722dabd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: a4ca918d979e7579a25bf7059fa4eec60cd0eb16
https://github.com/Perl/perl5/commit/a4ca918d979e7579a25bf7059fa4eec60cd0eb16
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 25df2ed68c33fa974411dfac4347d98c2d018683
https://github.com/Perl/perl5/commit/25df2ed68c33fa974411dfac4347d98c2d018683
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 06e83bfdbf86dce194f7b21476d4278d6e3f490e
https://github.com/Perl/perl5/commit/06e83bfdbf86dce194f7b21476d4278d6e3f490e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: f923195ca45bad1256ac28f08bf0139ec9a05fce
https://github.com/Perl/perl5/commit/f923195ca45bad1256ac28f08bf0139ec9a05fce
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 20d1868a291da83adaf18bf9ad9c2ea7dbabda92
https://github.com/Perl/perl5/commit/20d1868a291da83adaf18bf9ad9c2ea7dbabda92
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 104e49b49360b77119c70514730fed6752369038
https://github.com/Perl/perl5/commit/104e49b49360b77119c70514730fed6752369038
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: f9aa7e7068ff36bd672646121d6737c8f27aa755
https://github.com/Perl/perl5/commit/f9aa7e7068ff36bd672646121d6737c8f27aa755
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 9e72b8a956b721b04d6d48e16560e8f8eb1737df
https://github.com/Perl/perl5/commit/9e72b8a956b721b04d6d48e16560e8f8eb1737df
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: af2c2a1f031e02bf8ecc741ed335b39fca2f9df2
https://github.com/Perl/perl5/commit/af2c2a1f031e02bf8ecc741ed335b39fca2f9df2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: f300543f6fa09a457007022063bfbdbd0c82adf1
https://github.com/Perl/perl5/commit/f300543f6fa09a457007022063bfbdbd0c82adf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 61b1a34ecc9dbe72a8a76f3a364a6f39bc946d8a
https://github.com/Perl/perl5/commit/61b1a34ecc9dbe72a8a76f3a364a6f39bc946d8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: b72b5edc6b587aae7356d68e01c2876a01221a6e
https://github.com/Perl/perl5/commit/b72b5edc6b587aae7356d68e01c2876a01221a6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: ddc05781be169aa700365bcd301db63518c66501
https://github.com/Perl/perl5/commit/ddc05781be169aa700365bcd301db63518c66501
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: d91f50ae531971ff78e08dbd52cbaba3a4d339ff
https://github.com/Perl/perl5/commit/d91f50ae531971ff78e08dbd52cbaba3a4d339ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: bdabdc2f22be8ab9456c4e7c7d399af02c22f7b1
https://github.com/Perl/perl5/commit/bdabdc2f22be8ab9456c4e7c7d399af02c22f7b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 0c45c0e8411d1fecfb04ad70b3219d62ac102d99
https://github.com/Perl/perl5/commit/0c45c0e8411d1fecfb04ad70b3219d62ac102d99
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 097b283f5379c5a348858d5328000094b3959666
https://github.com/Perl/perl5/commit/097b283f5379c5a348858d5328000094b3959666
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 4c9fdbe8103ff95607a7ad9018f158e5ca4d6a31
https://github.com/Perl/perl5/commit/4c9fdbe8103ff95607a7ad9018f158e5ca4d6a31
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 8c5f0da0e2d37cc6eafcdb1080cc8f0794ca9504
https://github.com/Perl/perl5/commit/8c5f0da0e2d37cc6eafcdb1080cc8f0794ca9504
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 329c6f477e42336f32cb062b0291d7785d0d3748
https://github.com/Perl/perl5/commit/329c6f477e42336f32cb062b0291d7785d0d3748
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 676649f2f70b7eb1faa05305ba88fbfb413fcb1b
https://github.com/Perl/perl5/commit/676649f2f70b7eb1faa05305ba88fbfb413fcb1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: cf02bf2c1f772ae898371a6cc76fffcafbc33cac
https://github.com/Perl/perl5/commit/cf02bf2c1f772ae898371a6cc76fffcafbc33cac
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 075e54a924613f506d2c2e4c60e348bb99c0786b
https://github.com/Perl/perl5/commit/075e54a924613f506d2c2e4c60e348bb99c0786b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c3f6ca7f471345c2aa5e4466a4070b22ab4acf52
https://github.com/Perl/perl5/commit/c3f6ca7f471345c2aa5e4466a4070b22ab4acf52
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: f2e4cdc5e8816a7da161cd7d5c0a5d04697e91ec
https://github.com/Perl/perl5/commit/f2e4cdc5e8816a7da161cd7d5c0a5d04697e91ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 152408d0dec972a5ab2058976829b733bb12d5b5
https://github.com/Perl/perl5/commit/152408d0dec972a5ab2058976829b733bb12d5b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 87f576a9e07939145cee166c49c09c35597cffba
https://github.com/Perl/perl5/commit/87f576a9e07939145cee166c49c09c35597cffba
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: a843ea835a1450e607f877dc12d8e7d0ef989d1a
https://github.com/Perl/perl5/commit/a843ea835a1450e607f877dc12d8e7d0ef989d1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3ab93c6ff5eceb25b1ac9af936b87b4cbab311bb
https://github.com/Perl/perl5/commit/3ab93c6ff5eceb25b1ac9af936b87b4cbab311bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e7c97a93b36af5a67df2aa85e91a1d76665795b8
https://github.com/Perl/perl5/commit/e7c97a93b36af5a67df2aa85e91a1d76665795b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: f71c41a822fc3fd9728a0f7763d1557ce83a5b7e
https://github.com/Perl/perl5/commit/f71c41a822fc3fd9728a0f7763d1557ce83a5b7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 54561be54b19a811c4a6a910154ef79e672f9a6c
https://github.com/Perl/perl5/commit/54561be54b19a811c4a6a910154ef79e672f9a6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 3aa623d046fec0597d2df5169f8e6d925f967d40
https://github.com/Perl/perl5/commit/3aa623d046fec0597d2df5169f8e6d925f967d40
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: ff497ba15921146bece09618a1ae49f0abc3897e
https://github.com/Perl/perl5/commit/ff497ba15921146bece09618a1ae49f0abc3897e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a1c80d9cd2b3d5eca2ed105329d17707bf917ab8
https://github.com/Perl/perl5/commit/a1c80d9cd2b3d5eca2ed105329d17707bf917ab8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 165a2b38dda54b044c779b4005c6e52da70fbebd
https://github.com/Perl/perl5/commit/165a2b38dda54b044c779b4005c6e52da70fbebd
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 9f1a4e8a13fa784bf6decbb119c8fa9e73595051
https://github.com/Perl/perl5/commit/9f1a4e8a13fa784bf6decbb119c8fa9e73595051
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: b70cf2fe180a209c58c5a6724350b205d109e3fa
https://github.com/Perl/perl5/commit/b70cf2fe180a209c58c5a6724350b205d109e3fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 3534dd28ada04ca5541e93d0f9cc7e6335e8a93b
https://github.com/Perl/perl5/commit/3534dd28ada04ca5541e93d0f9cc7e6335e8a93b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 336d558c3d637c016cfff18bce2fa15dffaa5438
https://github.com/Perl/perl5/commit/336d558c3d637c016cfff18bce2fa15dffaa5438
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 0b8ae84307566491fc20a255c2df4484fd75384e
https://github.com/Perl/perl5/commit/0b8ae84307566491fc20a255c2df4484fd75384e
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 221c3fb88abf4e21bd870a33fd9828f7ddaaab94
https://github.com/Perl/perl5/commit/221c3fb88abf4e21bd870a33fd9828f7ddaaab94
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 07e757ef08b677bc5e3f0620437e90664cecc60d
https://github.com/Perl/perl5/commit/07e757ef08b677bc5e3f0620437e90664cecc60d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 26024a1b7eee2f251a8081a77f4e337b3f43a0af
https://github.com/Perl/perl5/commit/26024a1b7eee2f251a8081a77f4e337b3f43a0af
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e01682917f6fd6126275ec9d4b011178278d4168
https://github.com/Perl/perl5/commit/e01682917f6fd6126275ec9d4b011178278d4168
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 5467812ee40a9cc88982306ee5e22670687bede4
https://github.com/Perl/perl5/commit/5467812ee40a9cc88982306ee5e22670687bede4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: e762dc81c60eb28bcb53b3e8c717f19c5bdcf087
https://github.com/Perl/perl5/commit/e762dc81c60eb28bcb53b3e8c717f19c5bdcf087
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 0144004c470cd77125af003cee379c4b58eb0d2a
https://github.com/Perl/perl5/commit/0144004c470cd77125af003cee379c4b58eb0d2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: abc2cd1788f66bf79489ae013deec126809fcb2a
https://github.com/Perl/perl5/commit/abc2cd1788f66bf79489ae013deec126809fcb2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 1856123f21307df1b23df99545c219610cb1c67d
https://github.com/Perl/perl5/commit/1856123f21307df1b23df99545c219610cb1c67d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: f6089eef87db612c6462a2f4a2085979c8c2aaf3
https://github.com/Perl/perl5/commit/f6089eef87db612c6462a2f4a2085979c8c2aaf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 39772a81fa32a1205975bfc1ae6ec4471a8114de
https://github.com/Perl/perl5/commit/39772a81fa32a1205975bfc1ae6ec4471a8114de
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 311b181c4cf918d37a9e9eea344508c0936a2f83
https://github.com/Perl/perl5/commit/311b181c4cf918d37a9e9eea344508c0936a2f83
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 945547a27c75249b5c2743d4dac5c27e66274d91
https://github.com/Perl/perl5/commit/945547a27c75249b5c2743d4dac5c27e66274d91
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 892454ee9bedf537904c6691f4c9ffed50c50c9c
https://github.com/Perl/perl5/commit/892454ee9bedf537904c6691f4c9ffed50c50c9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 39c92518260fc5ebbe64914e60970b42e93c9039
https://github.com/Perl/perl5/commit/39c92518260fc5ebbe64914e60970b42e93c9039
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 61439c73e543676e953a9c516e217d0629b733b6
https://github.com/Perl/perl5/commit/61439c73e543676e953a9c516e217d0629b733b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: eea7c5281ad555c39eef81b6cf29540d3d58558a
https://github.com/Perl/perl5/commit/eea7c5281ad555c39eef81b6cf29540d3d58558a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 6d61f87abd1dc58a576903975faa1da20c889778
https://github.com/Perl/perl5/commit/6d61f87abd1dc58a576903975faa1da20c889778
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: d3a8f052a051a4b3fe344cc09922a6774ffedab3
https://github.com/Perl/perl5/commit/d3a8f052a051a4b3fe344cc09922a6774ffedab3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: bcda7ede40ac0c868e034cb1ca9e3941d5c392ce
https://github.com/Perl/perl5/commit/bcda7ede40ac0c868e034cb1ca9e3941d5c392ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: f59e6d281c84ed946d90d214989a1170c6502e21
https://github.com/Perl/perl5/commit/f59e6d281c84ed946d90d214989a1170c6502e21
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: c4a45e46f90893e47a2587af980a0c6de36017b8
https://github.com/Perl/perl5/commit/c4a45e46f90893e47a2587af980a0c6de36017b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: dd458a25287a65a58849f9ee7cc7e90684a2dec4
https://github.com/Perl/perl5/commit/dd458a25287a65a58849f9ee7cc7e90684a2dec4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: f4aefc273ad780b6fb254f8c87cbff6614a8618f
https://github.com/Perl/perl5/commit/f4aefc273ad780b6fb254f8c87cbff6614a8618f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 9cf2237beb680ffc8f7ea5fa83efbff55d09c9a5
https://github.com/Perl/perl5/commit/9cf2237beb680ffc8f7ea5fa83efbff55d09c9a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 3ec34ceb2ae27be89c07590ff31a9db6a73a6dd9
https://github.com/Perl/perl5/commit/3ec34ceb2ae27be89c07590ff31a9db6a73a6dd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 226a637ff7e81348ba63c4c3d5010c93e6f6d493
https://github.com/Perl/perl5/commit/226a637ff7e81348ba63c4c3d5010c93e6f6d493
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: cd977e6164c237b22d0ea2010a8dfbee811a3954
https://github.com/Perl/perl5/commit/cd977e6164c237b22d0ea2010a8dfbee811a3954
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 978df984e74b365459252426573343fbd661958b
https://github.com/Perl/perl5/commit/978df984e74b365459252426573343fbd661958b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 8ce68f3e2bfcd949390996609a4f057a7f17953a
https://github.com/Perl/perl5/commit/8ce68f3e2bfcd949390996609a4f057a7f17953a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: c1fc1d97a73c8e7a6d438bfaaa9438658caa0251
https://github.com/Perl/perl5/commit/c1fc1d97a73c8e7a6d438bfaaa9438658caa0251
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: b10953422871ee516d8c36d463c968f74c5d74bf
https://github.com/Perl/perl5/commit/b10953422871ee516d8c36d463c968f74c5d74bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 903fecf4b75755b1a9eb2fd1b90b4086d6bcbe0f
https://github.com/Perl/perl5/commit/903fecf4b75755b1a9eb2fd1b90b4086d6bcbe0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: de8c29f2ae0f36735983c88b7ad1063698926be4
https://github.com/Perl/perl5/commit/de8c29f2ae0f36735983c88b7ad1063698926be4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: f2bf00c295fb38c5aa0ff281cbce8967c611dacd
https://github.com/Perl/perl5/commit/f2bf00c295fb38c5aa0ff281cbce8967c611dacd
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 834e1eafb223a3f9a34d0e80ebb4081be728fe58
https://github.com/Perl/perl5/commit/834e1eafb223a3f9a34d0e80ebb4081be728fe58
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 97ae28ff6edecbedfb8691b44748c42c7204640c
https://github.com/Perl/perl5/commit/97ae28ff6edecbedfb8691b44748c42c7204640c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: a9a8d60d2268af0bec51d36333e8795bdd9670b8
https://github.com/Perl/perl5/commit/a9a8d60d2268af0bec51d36333e8795bdd9670b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: f8b4ef352832427c0f5f488f3e4da64fd83e143a
https://github.com/Perl/perl5/commit/f8b4ef352832427c0f5f488f3e4da64fd83e143a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 60524902216cee472006309e31d88dd4a57cf192
https://github.com/Perl/perl5/commit/60524902216cee472006309e31d88dd4a57cf192
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 19d0a40728018340d76cf0a50a14b44a109ae286
https://github.com/Perl/perl5/commit/19d0a40728018340d76cf0a50a14b44a109ae286
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 302535d4fed758ad4d4dbed8fbf7303a9cc1d663
https://github.com/Perl/perl5/commit/302535d4fed758ad4d4dbed8fbf7303a9cc1d663
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 6d450e5ba7a63eca9be14e7afd0cc5833c85fb74
https://github.com/Perl/perl5/commit/6d450e5ba7a63eca9be14e7afd0cc5833c85fb74
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 8a68541ee208c3cab9b7ca6a22aa6abdcdfcd2ce
https://github.com/Perl/perl5/commit/8a68541ee208c3cab9b7ca6a22aa6abdcdfcd2ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6a2a7f19f5cda9bacb089ff9d6a65a4e04cf0735
https://github.com/Perl/perl5/commit/6a2a7f19f5cda9bacb089ff9d6a65a4e04cf0735
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 67ecd858fa5ec22fadc90996a874f40e0630d7d1
https://github.com/Perl/perl5/commit/67ecd858fa5ec22fadc90996a874f40e0630d7d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: ecb7b1842c7704f6b78abc6bd5271fb691f75c65
https://github.com/Perl/perl5/commit/ecb7b1842c7704f6b78abc6bd5271fb691f75c65
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 3373e858b2a6ab22171cec1475ce77ef799ed8d7
https://github.com/Perl/perl5/commit/3373e858b2a6ab22171cec1475ce77ef799ed8d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 81edfd896de5efee66ef18d77b51f2581cde229c
https://github.com/Perl/perl5/commit/81edfd896de5efee66ef18d77b51f2581cde229c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 50dbbd4352041b006dd0544e3c0b6ed112d6cb34
https://github.com/Perl/perl5/commit/50dbbd4352041b006dd0544e3c0b6ed112d6cb34
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 877810ed72637cdbb043a25b2e6f4de02b2532e0
https://github.com/Perl/perl5/commit/877810ed72637cdbb043a25b2e6f4de02b2532e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 5e98c7e930623d4706a0db4b8ab9aea7ecd10c43
https://github.com/Perl/perl5/commit/5e98c7e930623d4706a0db4b8ab9aea7ecd10c43
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: f1197e5167507f02a8ec0913aec49cdc3f2d4f78
https://github.com/Perl/perl5/commit/f1197e5167507f02a8ec0913aec49cdc3f2d4f78
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: add727aac3647c3119957c9438216ac39ad1f882
https://github.com/Perl/perl5/commit/add727aac3647c3119957c9438216ac39ad1f882
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: f1e02500e0c5c731d97a8adaa58440e406d1bc07
https://github.com/Perl/perl5/commit/f1e02500e0c5c731d97a8adaa58440e406d1bc07
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 4235b66ce7323e4e65f046d7047d914628d4af61
https://github.com/Perl/perl5/commit/4235b66ce7323e4e65f046d7047d914628d4af61
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 71902f4211f70953214fb2f9345d91209b9ed017
https://github.com/Perl/perl5/commit/71902f4211f70953214fb2f9345d91209b9ed017
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 38f352d8b294faf7406a011dc531c7b550f3a7a1
https://github.com/Perl/perl5/commit/38f352d8b294faf7406a011dc531c7b550f3a7a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 719f356e018712f73b39dc4d2308c702a844d34d
https://github.com/Perl/perl5/commit/719f356e018712f73b39dc4d2308c702a844d34d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 9acd88fb82640d64e6f5ccd60a71890fff431fc5
https://github.com/Perl/perl5/commit/9acd88fb82640d64e6f5ccd60a71890fff431fc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 06886b3e192b472d8cfcd0c9ea85180e70016f55
https://github.com/Perl/perl5/commit/06886b3e192b472d8cfcd0c9ea85180e70016f55
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: eaf7afe90b5a040bc6639319f278e67b008dacf0
https://github.com/Perl/perl5/commit/eaf7afe90b5a040bc6639319f278e67b008dacf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a49fa2155da14f15df6ea2c87b2a6787ba21a651
https://github.com/Perl/perl5/commit/a49fa2155da14f15df6ea2c87b2a6787ba21a651
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: a6c51dd7a976416432b90800d34a27d9b52d8f35
https://github.com/Perl/perl5/commit/a6c51dd7a976416432b90800d34a27d9b52d8f35
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: e0f0b089a035df7d2a1d1f4f8ff8892ec457cfb8
https://github.com/Perl/perl5/commit/e0f0b089a035df7d2a1d1f4f8ff8892ec457cfb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 11061a505fd7c08327a443d6e7065b85b76e1071
https://github.com/Perl/perl5/commit/11061a505fd7c08327a443d6e7065b85b76e1071
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 3b7176b4516e2cbde70d2eb4a19c52a65fd011a9
https://github.com/Perl/perl5/commit/3b7176b4516e2cbde70d2eb4a19c52a65fd011a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: db5c423a54cd6bc8ed1fe3499f2c7f2f7ae590f2
https://github.com/Perl/perl5/commit/db5c423a54cd6bc8ed1fe3499f2c7f2f7ae590f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 93df5d68a154ccc9a47dfe9f8c0c1c9b16e897eb
https://github.com/Perl/perl5/commit/93df5d68a154ccc9a47dfe9f8c0c1c9b16e897eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 65df0f559a0a9cd0885d779bc4b63a76915f6e12
https://github.com/Perl/perl5/commit/65df0f559a0a9cd0885d779bc4b63a76915f6e12
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 9db76895ae8331befec70832f02369d62501908a
https://github.com/Perl/perl5/commit/9db76895ae8331befec70832f02369d62501908a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 1563bb1f9b00b7ef96a51f6e201823235cd3844a
https://github.com/Perl/perl5/commit/1563bb1f9b00b7ef96a51f6e201823235cd3844a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 0ecdf421e7173e3428dd33da06482edf34cd031d
https://github.com/Perl/perl5/commit/0ecdf421e7173e3428dd33da06482edf34cd031d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 8042b93727f83d8523ffc5469c4a90c4b712f147
https://github.com/Perl/perl5/commit/8042b93727f83d8523ffc5469c4a90c4b712f147
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 78ff66db94b89ca7739aee822d3885cb303313d9
https://github.com/Perl/perl5/commit/78ff66db94b89ca7739aee822d3885cb303313d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: d69c5406273a24f054ee2d71af987176f7e7f123
https://github.com/Perl/perl5/commit/d69c5406273a24f054ee2d71af987176f7e7f123
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 8f6749bf53dcec3cb993bad75e5b309ef00f62b9
https://github.com/Perl/perl5/commit/8f6749bf53dcec3cb993bad75e5b309ef00f62b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 66bc540e20c7f904474cf0188d78e57e08c19527
https://github.com/Perl/perl5/commit/66bc540e20c7f904474cf0188d78e57e08c19527
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 0f5a350b8316f8125129a273a32fed6838e2d0e3
https://github.com/Perl/perl5/commit/0f5a350b8316f8125129a273a32fed6838e2d0e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 98b4af0fff7b11e6e037e7663d1548f7b3643e14
https://github.com/Perl/perl5/commit/98b4af0fff7b11e6e037e7663d1548f7b3643e14
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 5ca02e08f9c2adeae001192c5933b723ba037943
https://github.com/Perl/perl5/commit/5ca02e08f9c2adeae001192c5933b723ba037943
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: ece3446fca1ba423fa75945749d78fc07da35f48
https://github.com/Perl/perl5/commit/ece3446fca1ba423fa75945749d78fc07da35f48
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: b709f83ce4149c8e488b3818123ef946f9ee1663
https://github.com/Perl/perl5/commit/b709f83ce4149c8e488b3818123ef946f9ee1663
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: dccaa091dfdc4495b4502dc89ad9fa73adb3e68d
https://github.com/Perl/perl5/commit/dccaa091dfdc4495b4502dc89ad9fa73adb3e68d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 267efa9379e13aa3efc5de005accb38c6d7713c6
https://github.com/Perl/perl5/commit/267efa9379e13aa3efc5de005accb38c6d7713c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: cea277c8d9a4f74db9678afaf08a62b0421be2ea
https://github.com/Perl/perl5/commit/cea277c8d9a4f74db9678afaf08a62b0421be2ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 32e307f1362dbd9a70c4e86a19a4acdd5f84134c
https://github.com/Perl/perl5/commit/32e307f1362dbd9a70c4e86a19a4acdd5f84134c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 498387f03795c68f65b7c010c1a984684afde91a
https://github.com/Perl/perl5/commit/498387f03795c68f65b7c010c1a984684afde91a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 445102ab1e7f320b48f05270159771039050415a
https://github.com/Perl/perl5/commit/445102ab1e7f320b48f05270159771039050415a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 8e7347ad7be4c9c4bf3e8412fb81c5beaa6267a3
https://github.com/Perl/perl5/commit/8e7347ad7be4c9c4bf3e8412fb81c5beaa6267a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: f267b2d5e28befe0a1ce9a274cc32c2fadb8aa03
https://github.com/Perl/perl5/commit/f267b2d5e28befe0a1ce9a274cc32c2fadb8aa03
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 9d7f99f1861adb61eed8d59e1723a665b5ffa93a
https://github.com/Perl/perl5/commit/9d7f99f1861adb61eed8d59e1723a665b5ffa93a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: c8bfc14296ada3ab320ea6bd8d146f53b02e26a9
https://github.com/Perl/perl5/commit/c8bfc14296ada3ab320ea6bd8d146f53b02e26a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 31ac6a05a3f10fd8401f2a8c1c5c09462f559bf1
https://github.com/Perl/perl5/commit/31ac6a05a3f10fd8401f2a8c1c5c09462f559bf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 6ed121e58b3658a9ef6ecc4aafbeeaae1e1d3bd9
https://github.com/Perl/perl5/commit/6ed121e58b3658a9ef6ecc4aafbeeaae1e1d3bd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: f7044584dad65e4824877c6ee16fd411ce5baac4
https://github.com/Perl/perl5/commit/f7044584dad65e4824877c6ee16fd411ce5baac4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c3f5777bb38880926e4f84a070cbe6eed109a775
https://github.com/Perl/perl5/commit/c3f5777bb38880926e4f84a070cbe6eed109a775
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5357191bb13de13daedc3367ac806e8118796c70
https://github.com/Perl/perl5/commit/5357191bb13de13daedc3367ac806e8118796c70
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 74f4eeb919a2aa36eb6d0c4347ecd914abf2dcb7
https://github.com/Perl/perl5/commit/74f4eeb919a2aa36eb6d0c4347ecd914abf2dcb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 0bcd9dc256ebd469a8cfd6bfe9ee56802f770a8c
https://github.com/Perl/perl5/commit/0bcd9dc256ebd469a8cfd6bfe9ee56802f770a8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: aabf93734525d380b39dae6ff4a1bfc719f09c4d
https://github.com/Perl/perl5/commit/aabf93734525d380b39dae6ff4a1bfc719f09c4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 80dd7cc96e776775b67be49cc5e9a74a1eadb0ed
https://github.com/Perl/perl5/commit/80dd7cc96e776775b67be49cc5e9a74a1eadb0ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 20924004351bc5c18a6dfdee4755b512ad1f2c87
https://github.com/Perl/perl5/commit/20924004351bc5c18a6dfdee4755b512ad1f2c87
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: e86d987c5f985d8035219b4de70fe2b7c7783ad3
https://github.com/Perl/perl5/commit/e86d987c5f985d8035219b4de70fe2b7c7783ad3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 2804428b82d1189f3c99a11b18f387913a001032
https://github.com/Perl/perl5/commit/2804428b82d1189f3c99a11b18f387913a001032
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 810e7e27ee1e51048839855692b36ed3baaae96c
https://github.com/Perl/perl5/commit/810e7e27ee1e51048839855692b36ed3baaae96c
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 127d3876029eb71233e19c79cdf3c27552b5bda2
https://github.com/Perl/perl5/commit/127d3876029eb71233e19c79cdf3c27552b5bda2
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 19378639b3412a4b591c31d3e0ddd7ad841f4b74
https://github.com/Perl/perl5/commit/19378639b3412a4b591c31d3e0ddd7ad841f4b74
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 5d0a6d094ceae37974c66c094436b37b01adfbb4
https://github.com/Perl/perl5/commit/5d0a6d094ceae37974c66c094436b37b01adfbb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 1cd8111e33b25ffc3c35e2362dea2e336885b8fa
https://github.com/Perl/perl5/commit/1cd8111e33b25ffc3c35e2362dea2e336885b8fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: c7e2859f2f893469e4d575cda3cb72dcbe3527ea
https://github.com/Perl/perl5/commit/c7e2859f2f893469e4d575cda3cb72dcbe3527ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: a687d5bfd0da6d4bd2e42c1fa484b74b48e34e95
https://github.com/Perl/perl5/commit/a687d5bfd0da6d4bd2e42c1fa484b74b48e34e95
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: dde9018439e8d5ee0d28cb53b4f30c814f64c6a5
https://github.com/Perl/perl5/commit/dde9018439e8d5ee0d28cb53b4f30c814f64c6a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 14add1cb108b630373b4abf12f91635f84acdf82
https://github.com/Perl/perl5/commit/14add1cb108b630373b4abf12f91635f84acdf82
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 9c11da0ce2a1ad013090682dc014580748125e12
https://github.com/Perl/perl5/commit/9c11da0ce2a1ad013090682dc014580748125e12
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 541e1115250007dd0b89c3c20d591bda0e8ca286
https://github.com/Perl/perl5/commit/541e1115250007dd0b89c3c20d591bda0e8ca286
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: edfe4827efabb6d114ece464cdf2e0dc7a63884a
https://github.com/Perl/perl5/commit/edfe4827efabb6d114ece464cdf2e0dc7a63884a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 06e27250e48aac7aff7af2375ee12f01b4bb85f6
https://github.com/Perl/perl5/commit/06e27250e48aac7aff7af2375ee12f01b4bb85f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: f76552bcfb89d4c86c13b45c0898242d589262a3
https://github.com/Perl/perl5/commit/f76552bcfb89d4c86c13b45c0898242d589262a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 79ecf9fb83534a80d3d608e30c1dc49088aa364a
https://github.com/Perl/perl5/commit/79ecf9fb83534a80d3d608e30c1dc49088aa364a
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 2bc6ddefd41a00db81e889cddce4042c750c3465
https://github.com/Perl/perl5/commit/2bc6ddefd41a00db81e889cddce4042c750c3465
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 2c608696c1f8157f773ad3c786c36fcd0d84335b
https://github.com/Perl/perl5/commit/2c608696c1f8157f773ad3c786c36fcd0d84335b
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 3f036b80453447078462d26a034f587a2408ce69
https://github.com/Perl/perl5/commit/3f036b80453447078462d26a034f587a2408ce69
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 360bec04f70cb78342d33782694edf4ecd340749
https://github.com/Perl/perl5/commit/360bec04f70cb78342d33782694edf4ecd340749
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: d6876b250ab486943dbc6b7127f2d2238b2e6cb6
https://github.com/Perl/perl5/commit/d6876b250ab486943dbc6b7127f2d2238b2e6cb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 91e70971998c017bf358392288bdeb702ab86de6
https://github.com/Perl/perl5/commit/91e70971998c017bf358392288bdeb702ab86de6
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 3d0acc8a813f3acbe10355d5217d7bfaad9a7a56
https://github.com/Perl/perl5/commit/3d0acc8a813f3acbe10355d5217d7bfaad9a7a56
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 5b8db266513e583d05727abe87252d79aad9fe71
https://github.com/Perl/perl5/commit/5b8db266513e583d05727abe87252d79aad9fe71
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 3f929317dc465cc992392582a6d7072709e0f108
https://github.com/Perl/perl5/commit/3f929317dc465cc992392582a6d7072709e0f108
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 75520745d23e4b73a0e64ae8f6f05b25fbd8013f
https://github.com/Perl/perl5/commit/75520745d23e4b73a0e64ae8f6f05b25fbd8013f
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 03a6332c92d9a4d7e9dd9c2fe5036a82c764e9d9
https://github.com/Perl/perl5/commit/03a6332c92d9a4d7e9dd9c2fe5036a82c764e9d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: fa49a5e94e5dae82bc29e259f2ec0f7d43b57631
https://github.com/Perl/perl5/commit/fa49a5e94e5dae82bc29e259f2ec0f7d43b57631
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 7841bc3e078998ec6a9e13388d79322e56f78533
https://github.com/Perl/perl5/commit/7841bc3e078998ec6a9e13388d79322e56f78533
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 7fd5cc107973635fca561d3b8014fbdbfd3ae711
https://github.com/Perl/perl5/commit/7fd5cc107973635fca561d3b8014fbdbfd3ae711
Author: Karl Williamson <[email protected]>
Date: 2021-04-05 (Mon, 05 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more14
Compare: https://github.com/Perl/perl5/compare/68e7414e29e0...7fd5cc107973
