Re: Patch for Authen::SASL::Perl::DIGEST_MD5

[Graham Barr]

On 4 Mar 2004, at 09:03, Paul Connolly wrote:

Graham & co-
	See below for a patch to DIGEST_MD5.pm - there are two issues
resolved here. Firstly, as reported on this list, the qop value in the
response should not be a quoted value.
	The second fixes bad handling of the qop in the challenge. The
qop challenge is a quoted string of one or more tokens. The only
supported option is 'auth', so the patch checks for this option in the
list (others could be 'auth-int' and 'auth-conf') and always sets qop 
in
the response to the same.
	I've verified this against the Critical Path Directory Server
and against Windows 2003 Active Directory.
Chris, You said a while back that you had some changes for DIGEST_MD5, 
is this fixing the same problem ?

Graham.

Regards,

Paul.

Compare: (<)C:\Perl\site\lib\Authen\SASL\Perl\DIGEST_MD5 103.pm (3693
bytes)
   with: (>)C:\Perl\site\lib\Authen\SASL\Perl\DIGEST_MD5.pm (3819 
bytes)

22c22
< my %qdval; @qdval{qw(username realm nonce cnonce digest-uri qop)} =
();
---
my %qdval; @qdval{qw(username realm nonce cnonce digest-uri)} = ();
54a54,56
  return $self->set_error("Server does not support auth (qop =
$sparams{'qop'})")
  	unless grep {/^auth$/} split /,/, $sparams{'qop'};

61c64
<     qop          => $sparams{'qop'},
---
    qop          => 'auth',