On Thu, Apr 16, 2009 at 10:21 PM, Jason King <ja...@ansipunx.net> wrote: >>> int kstat_get_stability(kstat_ctl_t *kc, const char *ks_module, const >>> char *ks_name, kstat_stability_t *stability) >>> Similar to kernel interface >>> Returns 0 on success, -1 on failure. On failure, errno is set to: >>> ENOENT - kstat does not exist. >> >> Yuk. Why a separate call? Makes life far more complicated, as you have to >> catch kstats going, and really you need to check that the kstat you're >> talking >> to is the same one you thought you were talking to. In fact, rather than >> using >> module/name (you need instance as well) it might be easier to simply use >> the kstat or its KID as the argument to identify a kstat uniquely. > > AFAIK, the current kstat interfaces are effectively frozen.
However, if you shove the stability data into the ks_resv field, then you don't need to change any interfaces, or add any new ones. You just get the data coming back for free. (Setting it is a bit different, you need to add something there. But for reads you can just let interested clients look at that field.) -- -Peter Tribble http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/ _______________________________________________ perf-discuss mailing list perf-discuss@opensolaris.org
