Hi Rafael, Thank you for your suggestions :) Please see my comments below.
> Hi Lejun > > The design doc looks good, here are my comments. > > Sec 2.2: Is there a limit to the number of rules the > user can specify in > the configuration file? There's no explicit limit. The rule matching will be implemented in a hash table manner, so performance should drop dramatically if you have a large number of rules. Of course, more rules means more memory consumption. > Sec 2.3: I'd suggest changing the title of the top > half from "Cause" to > "System wide latencies", to emphasize the differences > between the two > halfs. I wonder if a line or some other visual > separation would be > helpful. "Cause" is the caption of "<System-wide Cause 1>" and "<Per-Process Cause 1>", same as "Average", "Maximum" and "Percentage", so I think it should be there to make it looks consistent. To emphasize the difference, I'm going to add a line below the caption line saying "System wide latencies", so to avoid confusion. > I'd also suggest removing the "(C) 2008 > Intel Copyright" part > of the title - per what was done with PowerTOP, no > other OpenSolaris > utility displays a copyright notice during execution. Yes I can do that. No need to keep people staring at the copyright notice for two hours :) > I tried LatencyTOP on a Linux box and have to confess > that I wasn't very > pleased with the process list at the bottom and how > the user navigates > it. At the very least I'd suggest adding arrows on > each side so the user > quickly understands how to navigate. I'm far from a > human-computer > interaction specialist, but I think the interface > presents some challenges. I'll try to add the arrow and maybe a hint sentence for the beginning. But there's only 24 lines and it's a bit difficult for me to think of a intuitive UI... > I think there's a lot of room for extending the > features of LatencyTOP > as proposed, you exemplified this on the last two > paragraphs. I'm > looking forward to reading the code and trying it on > OpenSolaris. > > Thanks, > Rafael > _______________________________________________ > perf-discuss mailing list > perf-discuss@opensolaris.org -- This message posted from opensolaris.org _______________________________________________ perf-discuss mailing list perf-discuss@opensolaris.org
