Hi Drew, These changes look fine to me. I'm impressed that you went to the trouble to write your own AVL tree implementation; however, I suppose it was required for portability. Solaris has one on the default install, in /usr/include/sys/avl.h and /usr/lib/libavl.so.1.
-j On Mon, Dec 01, 2008 at 12:18:25PM -0800, Andrew Wilson wrote: > This code modifies FileBench to use avl trees to manage filesetentries, > allowing direct selection of existing vs. non existing files and leaf > directories and random access of files and leaf directories. The use of > avl trees and separate trees for existing and non-existing files > significantly reduces the time spent in picking files for those > workloads that alternatively use both types, while simplifying the pick > code. Random file access allows an index obtained from a random variable > to be used to select a file. I have also modified the createfile() code > so it picks files to preallocate on the disk randomly, thus better > scrambling file access even for those workloads that use a round robin > approach to accessing filesetentries. > > The webrev is at: > > http://cr.opensolaris.org/~dreww/randomfileaccess/ > _______________________________________________ > perf-discuss mailing list > perf-discuss@opensolaris.org _______________________________________________ perf-discuss mailing list perf-discuss@opensolaris.org
