There have been several changes to the webrev for 5062435, and so I'm putting it out for a second review. The most important was my ass*u*mption that just because the CPU obeyed TSO rules, that the compiler couldn't screw it up. Unfortunately it's almost impossible to prevent a compiler from reordering stores without declaring everything volatile. So I decided to accept the performance hit in new_cpu_mstate() and call membar_producer() which will generate either a membar #StoreStore, or an sfence.

There are also a variety of other changes and fixes that have been found by many helpful reviewers. If you're planning on reviewing these new changes, please let me know and I'll wait for your review.

   Website for the webrev:

http://www.zenstarstudio.com/opensolaris/webrev.5062435b/

   Thanks!
   -- Ethan

_______________________________________________
perf-discuss mailing list
perf-discuss@opensolaris.org

Reply via email to