Alvaro Retana has entered the following ballot position for draft-ietf-pce-lsp-setup-type-09: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-pce-lsp-setup-type/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- (1) The Length field in S3 has no units. I'm sure people can guess it is in bytes, from the rest of the description, but it should be explicit. (2) The Reserved fields "MUST be set to zero". What happens if they're not? Typically they are also ignored by the receiver... (3) S3: "Each sub-TLV MUST obey the rules for TLV formatting defined in ([RFC5440]). That is, each sub-TLV MUST be padded to a four byte alignment, and the length field of each sub-TLV MUST NOT include the padding bytes." The first sentence is ok. The second one tries to paraphrase what rfc5440 says -- but rfc5440 doesn't say that, it doesn't even use Normative language! This is the text from rfc5440: The Length field defines the length of the value portion in bytes. The TLV is padded to 4-bytes alignment; padding is not included in the Length field (so a 3-byte value would have a length of 3, but the total size of the TLV would be 8 bytes). (3a) The text in this document shouldn't use Normative language to describe what rfc5440 says and specifies. (3b) Note that the text from rfc5440 (specifically the part about "padding is not included in the Length field") is not aligned with the description of the Length field in this document: "The TLV Length field MUST be equal to the size of the appended sub-TLVs plus the size of the PST list (rounded up to the nearest multiple of four) plus four bytes." Rounding up includes the padding. (4) S6: "Each document that introduces a new path setup type to PCEP must include a manageability section." Why is a Normative "MUST" not used? (5) rfc6123 is a Historic document. Maybe a reference to rfc5706 is more appropriate (even in addition to rfc6123). _______________________________________________ Pce mailing list Pce@ietf.org https://www.ietf.org/mailman/listinfo/pce
