On 22.05.2017 17:46, Phil Susi wrote: > On 5/22/2017 11:22 AM, Sebastian Parschauer wrote: >> The flags 'raid' and 'lvm' are not printed for DASD CDL partitions >> but fdasd shows that they are set. In the function dasd_read(), >> the return value of ped_file_system_probe() is checked for NULL >> before setting the flags. This is wrong as we want a file system >> type to be set. So check for not NULL instead. > > It looks to me like that check was refusing to set the raid or lvm flag > if a valid filesystem was detected ( normally there should not be one if > it is really lvm or raid ), and since you reversed that logic, it will > only set the flag if a filesystem *is* detected, which normally will not > be the case, so that should break these flags.
Thanks for the reply. I've checked with zeroing the DASD first and you're right. But that check for NULL can still be a problem for a tool using parted. I'll check with the YaST guys who requested a change here. Cheers, Sebastian
