On Fri, Dec 02, 2016 at 11:35:44AM +0800, Wang Dong wrote: > Hi, > > I think it will be better if you can send your patch with #git send-email. > > It is not convenient to comment your patch if you put it in attaches file. > > So I just paste it out. I got some comments below.;-) > > > On 12/1/2016 7:28 PM, Arvin Schnell wrote:
> > gpt_part_data->boot > > + = gpt_part_data->swap > > + = gpt_part_data->raid > > + = gpt_part_data->bios_grub > > + = gpt_part_data->hp_service > > + = gpt_part_data->msftres > > + = gpt_part_data->msftdata > > + = gpt_part_data->msftrecv > > + = gpt_part_data->prep > > + = gpt_part_data->irst > > + = gpt_part_data->atvrecv = 0; > > + return gpt_partition_set_system (part, part->fs_type); > Lines above except *gpt_part_data->swap exist before. *I didn't see any > changes compared to the source code. An 'int swap' is added to the struct GPTPartitionData in the patch, right at the beginning. > I guess this patch is not based on the master? It is based on master. ciao Arvin -- Arvin Schnell, <[email protected]> Senior Software Engineer, Research & Development SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany
